Skip to contentSkip to conversation

Patch "cifs_dbg() outputs an uninitialized buffer in cifs_readdir()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Feb 24, 2016 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

cifs_dbg() outputs an uninitialized buffer in cifs_readdir()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
cifs_dbg-outputs-an-uninitialized-buffer-in-cifs_readdir.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 01b9b0b28626db4a47d7f48744d70abca9914ef1 Mon Sep 17 00:00:00 2001

From: Vasily Averin <[email protected]>
Date: Thu, 14 Jan 2016 13:41:14 +0300
Subject: cifs_dbg() outputs an uninitialized buffer in cifs_readdir()

From: Vasily Averin <[email protected]>

commit 01b9b0b28626db4a47d7f48744d70abca9914ef1 upstream.

In some cases tmp_bug can be not filled in cifs_filldir and stay uninitialized, therefore its printk with "%s" modifier can leak content of kernelspace memory. If old content of this buffer does not contain '\0' access bejond end of allocated object can crash the host.

---
 fs/cifs/readdir.c |    1 +
 1 file changed, 1 insertion(+)
fs/cifs/readdir.c +1 -0
@@ -847,6 +847,7 @@ int cifs_readdir(struct file *file, stru
 		 * if buggy server returns . and .. late do we want to
 		 * check for that here?
 		 */
+		*tmp_buf = 0;
 		rc = cifs_filldir(current_entry, file, ctx,
 				  tmp_buf, max_len);
 		if (rc) {

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/cifs_dbg-outputs-an-uninitialized-buffer-in-cifs_readdir.patch