Skip to contentSkip to conversation

Patch "iio:adc:ti_am335x_adc Fix buffered mode by identifying as software buffer." has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Feb 24, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio:adc:ti_am335x_adc Fix buffered mode by identifying as software buffer.

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iio-adc-ti_am335x_adc-fix-buffered-mode-by-identifying-as-software-buffer.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9d0be85d4e2cfa2519ae16efe7ff4a7150c43c0b Mon Sep 17 00:00:00 2001

From: Jonathan Cameron <[email protected]>
Date: Fri, 1 Jan 2016 18:05:34 +0000
Subject: iio:adc:ti_am335x_adc Fix buffered mode by identifying as software buffer.

From: Jonathan Cameron <[email protected]>

commit 9d0be85d4e2cfa2519ae16efe7ff4a7150c43c0b upstream.

Whilst this part has a hardware buffer, the identifcation that IIO cares about is the userspace facing end. It this case we push individual elements from the hardware fifo into the software interface (specifically a kfifo) rather than providing direct reads through to a hardware buffer (as we still do in the sca3000 for example).

Technically the original specification as a hardware buffer could be considered wrong, but it didn't matter until the patch listed below.

Result is that any attempt to enable the buffer will return -EINVAL

Fixes 225d59adf1c8 ("iio: Specify supported modes for buffers")
---
 drivers/iio/adc/ti_am335x_adc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ti_am335x_adc.c +1 -1
@@ -289,7 +289,7 @@ static int tiadc_iio_buffered_hardware_s
 		goto error_kfifo_free;
 
 	indio_dev->setup_ops = setup_ops;
-	indio_dev->modes |= INDIO_BUFFER_HARDWARE;
+	indio_dev->modes |= INDIO_BUFFER_SOFTWARE;
 
 	return 0;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/iio-adis_buffer-fix-out-of-bounds-memory-access.patch queue-4.4/iio-add-iio_trigger-dependency-to-stk8ba50.patch queue-4.4/iio-add-has_iomem-dependency-to-vf610_adc.patch queue-4.4/iio-light-acpi-als-report-data-as-processed.patch queue-4.4/iio-dac-mcp4725-set-iio-name-property-in-sysfs.patch queue-4.4/iio-pressure-mpl115-fix-temperature-offset-sign.patch queue-4.4/iio-adc-ti_am335x_adc-fix-buffered-mode-by-identifying-as-software-buffer.patch queue-4.4/iio-light-use-a-signed-return-type-for-ltr501_match_samp_freq.patch queue-4.4/iio-inkern-fix-a-null-dereference-on-error.patch