gpio: pisosr: Use gpiod_set_value_cansleep in pisosr_gpio_refresh()

PATCH In review Axel Lin 2 participants 2 messages Feb 24, 2016 – Feb 25, 2016 GPIO

Share & tools

Axel Lin

author

2016-02-24 13:31 UTC #0 lore raw

PATCH 1/1 gpio: pisosr: Use gpiod_set_value_cansleep in pisosr_gpio_refresh()

This driver has .can_sleep flag set.
So the pisosr_gpio_get() can be called from contexts that can sleep. Thus use the cansleep() variant in pisosr_gpio_refresh().

Signed-off-by Axel Lin <[email protected]>

---
 drivers/gpio/gpio-pisosr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpio/gpio-pisosr.c +2 -2

index f9f1074..597cec6 100644
@@ -46,9 +46,9 @@ static int pisosr_gpio_refresh(struct pisosr_gpio *gpio)
 	mutex_lock(&gpio->lock);
 
 	if (gpio->load_gpio) {
-		gpiod_set_value(gpio->load_gpio, 1);
+		gpiod_set_value_cansleep(gpio->load_gpio, 1);
 		udelay(1); /* registers load time (~10ns) */
-		gpiod_set_value(gpio->load_gpio, 0);
+		gpiod_set_value_cansleep(gpio->load_gpio, 0);
 		udelay(1); /* registers recovery time (~5ns) */
 	}

Signature · 1 line

2.1.4

Linus Walleij

2016-02-25 14:10 UTC #1 lore raw

Quoted 5 lines · Axel Lin

This driver has .can_sleep flag set.
So the pisosr_gpio_get() can be called from contexts that can sleep. Thus use the cansleep() variant in pisosr_gpio_refresh().
Signed-off-by Axel Lin <[email protected]>

Patch applied.

Yours,
Linus Walleij