Skip to contentSkip to conversation

fm10k: remove duplication of the driver summary

PATCH Superseded Jacob Keller 2 participants 3 messages Feb 25, 2016 – Feb 26, 2016

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fm10k: remove duplication of the driver summary

Use DRV_SUMMARY, similar to DRV_VERSION so that we don't have duplicate copies of the summary left in the driver.

---
This is a direct replacement of what is already on the queue. This version drops the summary change and only removes the duplication.

 drivers/net/ethernet/intel/fm10k/fm10k_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/fm10k/fm10k_main.c +3 -3
index 3a81c1451624..7832f9cdf743 100644
@@ -29,15 +29,15 @@
 #include "fm10k.h"
 
 #define DRV_VERSION	"0.19.3-k"
+#define DRV_SUMMARY	"Intel(R) Ethernet Switch Host Interface Driver"
 const char fm10k_driver_version[] = DRV_VERSION;
 char fm10k_driver_name[] = "fm10k";
-static const char fm10k_driver_string[] =
-	"Intel(R) Ethernet Switch Host Interface Driver";
+static const char fm10k_driver_string[] = DRV_SUMMARY;
 static const char fm10k_copyright[] =
 	"Copyright (c) 2013 Intel Corporation.";
 
 MODULE_AUTHOR("Intel Corporation, <[email protected]>");
-MODULE_DESCRIPTION("Intel(R) Ethernet Switch Host Interface Driver");
+MODULE_DESCRIPTION(DRV_SUMMARY);
 MODULE_LICENSE("GPL");
 MODULE_VERSION(DRV_VERSION);
 
Signature · 1 line
2.7.1.429.g45cd78e
#1 lore raw

PATCH v2 1/1 fm10k: remove duplication of the driver summary

Quoted 34 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Jacob Keller
Sent: Thursday, February 25, 2016 3:59 PM
To: Intel Wired LAN
Subject: [Intel-wired-lan] [PATCH v2] fm10k: remove duplication of the driver summary

Use DRV_SUMMARY, similar to DRV_VERSION so that we don't have duplicate
copies of the summary left in the driver.

---
This is a direct replacement of what is already on the queue. This version drops the summary change and only removes the duplication.

 drivers/net/ethernet/intel/fm10k/fm10k_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/fm10k/fm10k_main.c +1 -0
index 3a81c1451624..7832f9cdf743 100644
@@ -29,15 +29,15 @@
 #include "fm10k.h"
 
 #define DRV_VERSION	"0.19.3-k"
+#define DRV_SUMMARY	"Intel(R) Ethernet Switch Host Interface

Driver"
const char fm10k_driver_version[] = DRV_VERSION;
char fm10k_driver_name[] = "fm10k";

drivers/net/ethernet/intel/fm10k/fm10k_main.c +0 -1
-static const char fm10k_driver_string[] =

drivers/net/ethernet/intel/fm10k/fm10k_main.c line 42

Quoted 10 lines
drivers/net/ethernet/intel/fm10k/fm10k_main.c +2 -2
-	"Intel(R) Ethernet Switch Host Interface Driver";
+static const char fm10k_driver_string[] = DRV_SUMMARY;
 static const char fm10k_copyright[] =
 	"Copyright (c) 2013 Intel Corporation.";
 
 MODULE_AUTHOR("Intel Corporation, <[email protected]>");
-MODULE_DESCRIPTION("Intel(R) Ethernet Switch Host Interface Driver");
+MODULE_DESCRIPTION(DRV_SUMMARY);
 MODULE_LICENSE("GPL");
 MODULE_VERSION(DRV_VERSION);

Perhaps consider updating the copyright at the same time you are modifying this file?!?

I suggested a change to "Copyright(c) 2013 - 2016 Intel Corporation."

#2 lore raw

PATCH v2 1/1 fm10k: remove duplication of the driver summary

Quoted 52 lines · Bruce W
Quoted 43 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl. org] On
Behalf Of Jacob Keller
Sent: Thursday, February 25, 2016 3:59 PM
To: Intel Wired LAN
Subject: [Intel-wired-lan] [PATCH v2] fm10k: remove duplication of the
driver summary

Use DRV_SUMMARY, similar to DRV_VERSION so that we don't have duplicate
copies of the summary left in the driver.

---
This is a direct replacement of what is already on the queue. This version drops the summary change and only removes the duplication.

?drivers/net/ethernet/intel/fm10k/fm10k_main.c | 6 +++--- ?1 file changed, 3 insertions(+), 3 deletions(-)

drivers/net/ethernet/intel/fm10k/fm10k_main.c +0 -0
index 3a81c1451624..7832f9cdf743 100644
@@ -29,15 +29,15 @@

?#include "fm10k.h"

?#define DRV_VERSION "0.19.3-k"
+#define DRV_SUMMARY "Intel(R) Ethernet Switch Host
Interface
Driver"
?const char fm10k_driver_version[] = DRV_VERSION;
?char fm10k_driver_name[] = "fm10k";

drivers/net/ethernet/intel/fm10k/fm10k_main.c +1 -2
-static const char fm10k_driver_string[] =
-	"Intel(R) Ethernet Switch Host Interface Driver";
+static const char fm10k_driver_string[] = DRV_SUMMARY;

?static const char fm10k_copyright[] =
? "Copyright (c) 2013 Intel Corporation.";

Quoted 6 lines

?MODULE_AUTHOR("Intel Corporation, <[email protected]>"); -MODULE_DESCRIPTION("Intel(R) Ethernet Switch Host Interface Driver");
+MODULE_DESCRIPTION(DRV_SUMMARY); ?MODULE_LICENSE("GPL"); ?MODULE_VERSION(DRV_VERSION);

Perhaps consider updating the copyright at the same time you are modifying this file?!?

Quoted 2 lines

I suggested a change to "Copyright(c) 2013 - 2016 Intel Corporation."

Sure.

Thanks,
Jake