arm: socfpga: Enabling U-Boot environment support in QSPI

PATCH New Chin Liang See 2 participants 7 messages Feb 24, 2016 – Mar 2, 2016

lore

Share & tools

lore

Chin Liang See

author

2016-02-24 08:50 UTC #0 lore raw

PATCH 1/1 arm: socfpga: Enabling U-Boot environment support in QSPI

Enabling the support of storing U-Boot environment within serial NOR flash. By default, its still store into SDMMC

Signed-off-by Chin Liang See <[email protected]>

Cc Dinh Nguyen <[email protected]>

Cc Pavel Machek <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Stefan Roese <[email protected]>

---
 include/configs/socfpga_common.h | 6 ++++++
 1 file changed, 6 insertions(+)

include/configs/socfpga_common.h +6 -0

index a09e906..c1eef54 100644
@@ -291,6 +291,12 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
 #define CONFIG_ENV_OFFSET		512	/* just after the MBR */
 #endif
 
+/* Environment for QSPI boot */
+#if defined(CONFIG_ENV_IS_IN_SPI_FLASH) && !defined(CONFIG_ENV_OFFSET)
+#define CONFIG_ENV_OFFSET		0x00100000
+#define CONFIG_ENV_SECT_SIZE		(64 * 1024)
+#endif
+
 /*
  * mtd partitioning for serial NOR flash
  *

Signature · 1 line

1.9.2.468.g3f0c02a

Marek Vasut

2016-02-24 17:44 UTC #1 lore raw

PATCH 1/1 arm: socfpga: Enabling U-Boot environment support in QSPI

Quoted 10 lines · Chin Liang See

Enabling the support of storing U-Boot environment within serial NOR flash. By default, its still store into SDMMC
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>

I am fine with the patch, but why did I receive it thrice ? ;-)

Quoted 22 lines

---
 include/configs/socfpga_common.h | 6 ++++++
 1 file changed, 6 insertions(+)

include/configs/socfpga_common.h +6 -0

index a09e906..c1eef54 100644
@@ -291,6 +291,12 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
 #define CONFIG_ENV_OFFSET		512	/* just after the MBR */
 #endif
 
+/* Environment for QSPI boot */
+#if defined(CONFIG_ENV_IS_IN_SPI_FLASH) && !defined(CONFIG_ENV_OFFSET)
+#define CONFIG_ENV_OFFSET		0x00100000
+#define CONFIG_ENV_SECT_SIZE		(64 * 1024)
+#endif
+
 /*
  * mtd partitioning for serial NOR flash
  *

Chin Liang See

author

2016-02-26 13:06 UTC #2 lore raw

PATCH 1/1 arm: socfpga: Enabling U-Boot environment support in QSPI

Quoted 5 lines · Marek Vasut

Quoted 4 lines · Chin Liang See
Enabling the support of storing U-Boot environment within serial NOR flash. By default, its still store into SDMMC

Quoted 9 lines

Quoted 6 lines
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
I am fine with the patch, but why did I receive it thrice ? ;-)

Sorry about this as I thought IT blocked the email sending. I noticed the U-Boot mailing didn't show the patch after 10 mins. I was surprised to see 3 and guess it took longer time to go through IT servers screening :)

Thanks
Chin Liang

Quoted 27 lines

Quoted 26 lines

---
 include/configs/socfpga_common.h | 6 ++++++
 1 file changed, 6 insertions(+)

include/configs/socfpga_common.h +0 -0

index a09e906..c1eef54 100644
@@ -291,6 +291,12 @@ unsigned int
 cm_get_qspi_controller_clk_hz(void);
 #define CONFIG_ENV_OFFSET		512	/* just after

the MBR */
#endif

include/configs/socfpga_common.h +2 -0

+/* Environment for QSPI boot */
+#if defined(CONFIG_ENV_IS_IN_SPI_FLASH) &&

!defined(CONFIG_ENV_OFFSET)

include/configs/socfpga_common.h +4 -0

+#define CONFIG_ENV_OFFSET		0x00100000
+#define CONFIG_ENV_SECT_SIZE		(64 * 1024)
+#endif
+
 /*
  * mtd partitioning for serial NOR flash
  *

Marek Vasut

2016-02-26 18:08 UTC #3 lore raw

PATCH 1/1 arm: socfpga: Enabling U-Boot environment support in QSPI

Quoted 13 lines · Chin Liang See

Quoted 12 lines · Marek Vasut
Quoted 10 lines · Chin Liang See
Enabling the support of storing U-Boot environment within serial NOR flash. By default, its still store into SDMMC
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>

Quoted 7 lines

Quoted 2 lines
I am fine with the patch, but why did I receive it thrice ? ;-)
Sorry about this as I thought IT blocked the email sending. I noticed the U-Boot mailing didn't show the patch after 10 mins. I was surprised to see 3 and guess it took longer time to go through IT servers screening :)

Gotcha!

btw I started screening the patches a bit more. socfpga_sr1500 produces a warning with this patch.

Please use buildman to build your patches, something like:

./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga"

will do the trick.

Signature · 2 lines

Best regards,
Marek Vasut

Chin Liang See

author

2016-03-01 06:38 UTC #4 lore raw

PATCH 1/1 arm: socfpga: Enabling U-Boot environment support in QSPI

Quoted 30 lines · Marek Vasut

Quoted 16 lines · Chin Liang See
Quoted 5 lines · Marek Vasut
Quoted 4 lines · Chin Liang See
Enabling the support of storing U-Boot environment within serial NOR flash. By default, its still store into SDMMC
Quoted 9 lines
Quoted 6 lines
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
I am fine with the patch, but why did I receive it thrice ? ;-)
Quoted 6 lines
Sorry about this as I thought IT blocked the email sending. I noticed
the U-Boot mailing didn't show the patch after 10 mins. I was surprised
to see 3 and guess it took longer time to go through IT servers screening :)
Gotcha!
btw I started screening the patches a bit more. socfpga_sr1500 produces
a warning with this patch.

Quoted 5 lines

Please use buildman to build your patches, something like:
./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga"
will do the trick.

Oops, thanks for reminding this as we talked about this prior my long holiday. I managed to get the buildman works but seems need 2 steps. The first step is without the -defsS and without the "" too.

Thanks
Chin Liang

Quoted 1 line

Marek Vasut

2016-03-01 13:51 UTC #5 lore raw

PATCH 1/1 arm: socfpga: Enabling U-Boot environment support in QSPI

Quoted 33 lines · Chin Liang See

Quoted 32 lines · Marek Vasut
Quoted 16 lines · Chin Liang See
Quoted 5 lines · Marek Vasut
Quoted 4 lines · Chin Liang See
Enabling the support of storing U-Boot environment within serial NOR flash. By default, its still store into SDMMC
Quoted 9 lines
Quoted 6 lines
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
I am fine with the patch, but why did I receive it thrice ? ;-)
Quoted 6 lines
Sorry about this as I thought IT blocked the email sending. I noticed
the U-Boot mailing didn't show the patch after 10 mins. I was surprised
to see 3 and guess it took longer time to go through IT servers screening :)
Gotcha!
btw I started screening the patches a bit more. socfpga_sr1500 produces
a warning with this patch.
Please use buildman to build your patches, something like:

Quoted 7 lines

Quoted 3 lines
./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga"
will do the trick.
Oops, thanks for reminding this as we talked about this prior my long holiday. I managed to get the buildman works but seems need 2 steps. The first step is without the -defsS and without the "" too.

Ah, right. It's really convenient tool, right ? ;-)

Signature · 2 lines

Best regards,
Marek Vasut

Chin Liang See

author

2016-03-02 12:25 UTC #6 lore raw

PATCH 1/1 arm: socfpga: Enabling U-Boot environment support in QSPI

Quoted 39 lines · Marek Vasut

Quoted 38 lines · Chin Liang See
Quoted 36 lines · Marek Vasut
Quoted 17 lines · Chin Liang See
Quoted 12 lines · Marek Vasut
Quoted 10 lines · Chin Liang See
Enabling the support of storing U-Boot environment within serial NOR flash. By default, its still store into SDMMC
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Quoted 3 lines
I am fine with the patch, but why did I receive it thrice ? ; -)
Quoted 6 lines
Sorry about this as I thought IT blocked the email sending. I noticed
the U-Boot mailing didn't show the patch after 10 mins. I was surprised
to see 3 and guess it took longer time to go through IT servers screening :)
Gotcha!
btw I started screening the patches a bit more. socfpga_sr1500 produces
a warning with this patch.
Please use buildman to build your patches, something like:
./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga"
will do the trick.

Quoted 8 lines

Quoted 5 lines
Oops, thanks for reminding this as we talked about this prior my long
holiday. I managed to get the buildman works but seems need 2 steps.
The first step is without the -defsS and without the "" too.
Ah, right. It's really convenient tool, right ? ;-)

Yup, I fully agree :) The same command can be used even we added new boards or socfpga devices.

Thanks
Chin Liang