omxplayer: fix host-user-contaminated QA warnings
PATCH 1/1 omxplayer: fix host-user-contaminated QA warnings
Explicitly chown the installed files to fix host-user-contaminated QA warnings for libavcodec, libavdevice, libavfilter, libavformat, libavutil and libswresample shared libraries.
--- recipes-multimedia/omxplayer/omxplayer_git.bb | 1 + 1 file changed, 1 insertion(+)
recipes-multimedia/omxplayer/omxplayer_git.bb +1 -0
@@ -61,6 +61,7 @@ do_install() { oe_runmake STRIP='echo skipping strip' dist mkdir -p ${D}${datadir}/fonts/truetype/freefont/ install ${S}/fonts/* ${D}${datadir}/fonts/truetype/freefont/ + chown root:root -R ${D} } FILES_${PN} = "${bindir}/omxplayer* \
Signature · 1 line
2.7.1
Quoted 22 lines · Jonathan Liu
Explicitly chown the installed files to fix host-user-contaminated QA warnings for libavcodec, libavdevice, libavfilter, libavformat, libavutil and libswresample shared libraries.
Signed-off-by Jonathan Liu <[email protected]>--- recipes-multimedia/omxplayer/omxplayer_git.bb | 1 + 1 file changed, 1 insertion(+)recipes-multimedia/omxplayer/omxplayer_git.bb +1
-1@@ -61,6 +61,7 @@ do_install() { oe_runmake STRIP='echo skipping strip' dist mkdir -p ${D}${datadir}/fonts/truetype/freefont/ install ${S}/fonts/* ${D}${datadir}/fonts/truetype/freefont/ + chown root:root -R ${D} } FILES_${PN} = "${bindir}/omxplayer* \ --
Quoted 2 lines
2.7.1
Actually the problem here is how the package does the dist target.
Makefile:
...
<-->cp -a ffmpeg_compiled/usr/lib/*.so* $(DIST)/usr/lib/omxplayer/
...
This means that even if ran in a fackroot environment, this will preserve the user id and other file attributes generating the warnings you pointed out.
In order to fix this I would vote for a patch that would change the archive flag to a simple -R (-P is default anyway). What do you think?
As well this patch should go upstream too as I don't see the idea behind copying those while preserving the file attributes.
Quoted 5 lines
--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
--
Andrei Gherzan
Quoted 42 lines · Andrei Gherzan
Quoted 22 lines · Jonathan Liu
Explicitly chown the installed files to fix host-user-contaminated QA warnings for libavcodec, libavdevice, libavfilter, libavformat, libavutil and libswresample shared libraries.
Signed-off-by Jonathan Liu <[email protected]>--- recipes-multimedia/omxplayer/omxplayer_git.bb | 1 + 1 file changed, 1 insertion(+)recipes-multimedia/omxplayer/omxplayer_git.bb +1
-1@@ -61,6 +61,7 @@ do_install() { oe_runmake STRIP='echo skipping strip' dist mkdir -p ${D}${datadir}/fonts/truetype/freefont/ install ${S}/fonts/* ${D}${datadir}/fonts/truetype/freefont/ + chown root:root -R ${D} } FILES_${PN} = "${bindir}/omxplayer* \ --Quoted 2 lines
2.7.1
Actually the problem here is how the package does the dist target.
Makefile:
...
<-->cp -a ffmpeg_compiled/usr/lib/*.so* $(DIST)/usr/lib/omxplayer/
...This means that even if ran in a fackroot environment, this will preserve the user id and other file attributes generating the warnings you pointed out.
In order to fix this I would vote for a patch that would change the archive flag to a simple -R (-P is default anyway). What do you think?
As well this patch should go upstream too as I don't see the idea behind copying those while preserving the file attributes.
Quoted 8 lines
Quoted 5 lines
--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto--
Andrei Gherzan
I have submitted a pull request to omxplayer to use -P. No point using -R as it is just copying libraries rather than directories.
Regards,
Jonathan
Quoted 49 lines · Jonathan Liu
Quoted 48 lines · Andrei Gherzan
Quoted 22 lines · Jonathan Liu
Explicitly chown the installed files to fix host-user-contaminated QA warnings for libavcodec, libavdevice, libavfilter, libavformat, libavutil and libswresample shared libraries.
Signed-off-by Jonathan Liu <[email protected]>--- recipes-multimedia/omxplayer/omxplayer_git.bb | 1 + 1 file changed, 1 insertion(+)recipes-multimedia/omxplayer/omxplayer_git.bb +1
-1@@ -61,6 +61,7 @@ do_install() { oe_runmake STRIP='echo skipping strip' dist mkdir -p ${D}${datadir}/fonts/truetype/freefont/ install ${S}/fonts/* ${D}${datadir}/fonts/truetype/freefont/ + chown root:root -R ${D} } FILES_${PN} = "${bindir}/omxplayer* \ --Quoted 2 lines
2.7.1
Actually the problem here is how the package does the dist target.
Makefile:
...
<-->cp -a ffmpeg_compiled/usr/lib/*.so* $(DIST)/usr/lib/omxplayer/
...This means that even if ran in a fackroot environment, this will preserve the user id and other file attributes generating the warnings you pointed out.
In order to fix this I would vote for a patch that would change the archive flag to a simple -R (-P is default anyway). What do you think?
As well this patch should go upstream too as I don't see the idea behind copying those while preserving the file attributes.
Quoted 5 lines
--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
Quoted 8 lines
Quoted 2 lines
--
Andrei GherzanI have submitted a pull request to omxplayer to use -P. No point using -R as it is just copying libraries rather than directories.
Regards,
Jonathan
Indeed you are right. -P should be just enough. Good job!
Signature · 1 line
Andrei Gherzan