Skip to contentSkip to conversation

scsi: storvsc: Fix a build issue reported by kbuild test robot

PATCH Applied K. Y. Srinivasan 2 participants 2 messages Feb 27, 2016 – Mar 5, 2016 SCSI

lore
Share & tools
lore

K. Y. Srinivasan

author
#0 lore raw

PATCH v4 1/1 scsi: storvsc: Fix a build issue reported by kbuild test robot

tree:   https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2flinux.git&data=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d32796ec3c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ubr4GbBaNS%2ftOz%2buJBk0CL9N0UNG9x2TidLgy6Yovg4%3d master
head:   03c21cb775a313f1ff19be59c5d02df3e3526471
commit: dac582417bc449b1f7f572d3f1dd9d23eec15cc9 storvsc: Properly support Fibre Channel devices
date:   3 weeks ago
config: x86_64-randconfig-s3-01281016 (attached as .config)
reproduce:
        git checkout dac582417bc449b1f7f572d3f1dd9d23eec15cc9
        # save the attached .config to linux build tree
        make ARCH=x86_64

All errors (new ones prefixed by >>):

drivers/built-in.o: In function `storvsc_remove':

Quoted 1 line
Quoted 1 line

storvsc_drv.c:(.text+0x213af7): undefined reference to `fc_remove_host'

drivers/built-in.o: In function `storvsc_drv_init':

Quoted 2 lines
Quoted 2 lines

storvsc_drv.c:(.init.text+0xcbcc): undefined reference to fc_attach_transport' storvsc_drv.c:(.init.text+0xcc06): undefined reference to fc_release_transport'

drivers/built-in.o: In function `storvsc_drv_exit':

Quoted 1 line
Quoted 1 line

storvsc_drv.c:(.exit.text+0x123c): undefined reference to `fc_release_transport'

With this commit, the storvsc driver depends on FC atttributes. Make this dependency explicit.

Signed-off-by K. Y. Srinivasan <[email protected]>
Reported-by Fengguang Wu <[email protected]>

---
v1 - v4: Incorporated suggestions from James Bottomley <[email protected]>

 drivers/scsi/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/scsi/Kconfig +1 -0
index 64eed87..166de0c 100644
@@ -594,6 +594,7 @@ config XEN_SCSI_FRONTEND
 config HYPERV_STORAGE
 	tristate "Microsoft Hyper-V virtual storage driver"
 	depends on SCSI && HYPERV
+	depends on m || SCSI_FC_ATTRS != m
 	default HYPERV
 	help
 	  Select this option to enable the Hyper-V virtual storage driver.
Signature · 1 line
1.7.4.1
Applied
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"kys" == K Y Srinivasan <[email protected]> writes:

kys> With this commit, the storvsc driver depends on FC kys> atttributes. Make this dependency explicit.

Applied to 4.6/scsi-queue.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering