Skip to contentSkip to conversation

Patch "pppoe: fix reference counting in PPPoE proxy" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Feb 29, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

pppoe: fix reference counting in PPPoE proxy

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pppoe-fix-reference-counting-in-pppoe-proxy.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Feb 29 14:33:50 PST 2016

From: Guillaume Nault <[email protected]>
Date: Mon, 15 Feb 2016 17:01:10 +0100
Subject: pppoe: fix reference counting in PPPoE proxy

From: Guillaume Nault <[email protected]>

[ Upstream commit 29e73269aa4d36f92b35610c25f8b01c789b0dc8 ]

Drop reference on the relay_po socket when __pppoe_xmit() succeeds. This is already handled correctly in the error path.

---
 drivers/net/ppp/pppoe.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/net/ppp/pppoe.c +2 -0
@@ -395,6 +395,8 @@ static int pppoe_rcv_core(struct sock *s
 
 		if (!__pppoe_xmit(sk_pppox(relay_po), skb))
 			goto abort_put;
+
+		sock_put(sk_pppox(relay_po));
 	} else {
 		if (sock_queue_rcv_skb(sk, skb))
 			goto abort_kfree;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/pppoe-fix-reference-counting-in-pppoe-proxy.patch