Skip to contentSkip to conversation

Patch "sctp: allow setting SCTP_SACK_IMMEDIATELY by the application" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Feb 29, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

sctp: allow setting SCTP_SACK_IMMEDIATELY by the application

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
sctp-allow-setting-sctp_sack_immediately-by-the-application.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Feb 29 14:33:50 PST 2016

From: Marcelo Ricardo Leitner <[email protected]>
Date: Fri, 22 Jan 2016 18:29:49 -0200
Subject: sctp: allow setting SCTP_SACK_IMMEDIATELY by the application

From: Marcelo Ricardo Leitner <[email protected]>

[ Upstream commit 27f7ed2b11d42ab6d796e96533c2076ec220affc ]

This patch extends commit b93d6471748d ("sctp: implement the sender side for SACK-IMMEDIATELY extension") as it didn't white list SCTP_SACK_IMMEDIATELY on sctp_msghdr_parse(), causing it to be understood as an invalid flag and returning -EINVAL to the application.

Note that the actual handling of the flag is already there in sctp_datamsg_from_user().

https://tools.ietf.org/html/rfc7053#section-7

Fixes b93d6471748d ("sctp: implement the sender side for SACK-IMMEDIATELY extension")
---
 net/sctp/socket.c |    2 ++
 1 file changed, 2 insertions(+)
net/sctp/socket.c +2 -0
@@ -6640,6 +6640,7 @@ static int sctp_msghdr_parse(const struc
 
 			if (cmsgs->srinfo->sinfo_flags &
 			    ~(SCTP_UNORDERED | SCTP_ADDR_OVER |
+			      SCTP_SACK_IMMEDIATELY |
 			      SCTP_ABORT | SCTP_EOF))
 				return -EINVAL;
 			break;
@@ -6663,6 +6664,7 @@ static int sctp_msghdr_parse(const struc
 
 			if (cmsgs->sinfo->snd_flags &
 			    ~(SCTP_UNORDERED | SCTP_ADDR_OVER |
+			      SCTP_SACK_IMMEDIATELY |
 			      SCTP_ABORT | SCTP_EOF))
 				return -EINVAL;
 			break;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/sctp-allow-setting-sctp_sack_immediately-by-the-application.patch queue-4.4/sctp-translate-network-order-to-host-order-when-users-get-a-hmacid.patch