Skip to contentSkip to conversation

Patch "coresight: checking for NULL string in coresight_name_match()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

coresight: checking for NULL string in coresight_name_match()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
coresight-checking-for-null-string-in-coresight_name_match.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From fadf3a44e974b030e7145218ad1ab25e3ef91738 Mon Sep 17 00:00:00 2001

From: Mathieu Poirier <[email protected]>
Date: Thu, 17 Dec 2015 08:47:02 -0700
Subject: coresight: checking for NULL string in coresight_name_match()

From: Mathieu Poirier <[email protected]>

commit fadf3a44e974b030e7145218ad1ab25e3ef91738 upstream.

Connection child names associated to ports can sometimes be NULL, which is the case when booting a system on QEMU or when the Coresight power domain isn't switched on.

This patch is adding a check to make sure a NULL string isn't fed to strcmp(), something that avoid crashing the system.

---
 drivers/hwtracing/coresight/coresight.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwtracing/coresight/coresight.c +1 -1
@@ -548,7 +548,7 @@ static int coresight_name_match(struct d
 	to_match = data;
 	i_csdev = to_coresight_device(dev);
 
-	if (!strcmp(to_match, dev_name(&i_csdev->dev)))
+	if (to_match && !strcmp(to_match, dev_name(&i_csdev->dev)))
 		return 1;
 
 	return 0;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/coresight-checking-for-null-string-in-coresight_name_match.patch