Patch "rtlwifi: rtl8723ae: Fix initialization of module parameters" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
rtlwifi: rtl8723ae: Fix initialization of module parameters
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
rtlwifi-rtl8723ae-fix-initialization-of-module-parameters.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
793b09994211fbe0b5cd5f7b6dd8cc9b6256c3c6Mon Sep 17 00:00:00 2001
From: Larry Finger <[email protected]>
Date: Mon, 14 Dec 2015 16:34:32 -0600
Subject: rtlwifi: rtl8723ae: Fix initialization of module parameters
From: Larry Finger <[email protected]>
commit 793b09994211fbe0b5cd5f7b6dd8cc9b6256c3c6 upstream.
This driver has some errors in the handling of module parameters. These include missing initialization for parameters msi_support and disable_watchdog. In addition, neither of these parameters nor sw_crypto are transferred into the locations used by the driver. A final fix is adding parameter msi to the module named and description macros.
--- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c +9 -0
@@ -150,6 +150,11 @@ int rtl8723e_init_sw_vars(struct ieee802 rtlpriv->psc.inactiveps = rtlpriv->cfg->mod_params->inactiveps; rtlpriv->psc.swctrl_lps = rtlpriv->cfg->mod_params->swctrl_lps; rtlpriv->psc.fwctrl_lps = rtlpriv->cfg->mod_params->fwctrl_lps; + rtlpci->msi_support = rtlpriv->cfg->mod_params->msi_support; + rtlpriv->cfg->mod_params->sw_crypto = + rtlpriv->cfg->mod_params->sw_crypto; + rtlpriv->cfg->mod_params->disable_watchdog = + rtlpriv->cfg->mod_params->disable_watchdog;if (rtlpriv->cfg->mod_params->disable_watchdog)pr_info ("watchdog disabled\n" ); rtlpriv->psc.reg_fwctrl_lps =3 ;
@@ -267,6 +272,8 @@ static struct rtl_mod_params rtl8723e_mo .swctrl_lps = false, .fwctrl_lps = true, .debug = DBG_EMERG, + .msi_support = false, + .disable_watchdog = false, };static struct rtl_hal_cfg rtl8723e_hal_cfg = {
@@ -383,12 +390,14 @@ module_param_named(debug, rtl8723e_mod_pmodule_param_named (ips, rtl8723e_mod_params.inactiveps, bool,0444 );module_param_named (swlps, rtl8723e_mod_params.swctrl_lps, bool,0444 );module_param_named (fwlps, rtl8723e_mod_params.fwctrl_lps, bool,0444 ); +module_param_named (msi, rtl8723e_mod_params.msi_support, bool,0444 );module_param_named (disable_watchdog, rtl8723e_mod_params.disable_watchdog, bool,0444 );MODULE_PARM_DESC (swenc,"Set to 1 for software crypto (default 0)\n" );MODULE_PARM_DESC (ips,"Set to 0 to not use link power save (default 1)\n" );MODULE_PARM_DESC (swlps,"Set to 1 to use SW control power save (default 0)\n" );MODULE_PARM_DESC (fwlps,"Set to 1 to use FW control power save (default 1)\n" ); +MODULE_PARM_DESC (msi,"Set to 1 to use MSI interrupts mode (default 0)\n" );MODULE_PARM_DESC (debug,"Set debug level (0-5) (default 0)" );MODULE_PARM_DESC (disable_watchdog,"Set to 1 to disable the watchdog (default 0)\n" );
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/rtlwifi-rtl8723be-fix-module-parameter-initialization.patch queue-4.4/rtlwifi-rtl8192de-fix-incorrect-module-parameter-descriptions.patch queue-4.4/rtlwifi-rtl8192se-fix-module-parameter-initialization.patch queue-4.4/rtlwifi-rtl8192cu-add-missing-parameter-setup.patch queue-4.4/rtlwifi-rtl8723ae-fix-initialization-of-module-parameters.patch queue-4.4/rtlwifi-rtl_pci-fix-kernel-panic.patch queue-4.4/rtlwifi-rtl8188ee-fix-module-parameter-initialization.patch queue-4.4/rtlwifi-rtl8192ce-fix-handling-of-module-parameters.patch