Skip to contentSkip to conversation

Patch "irqchip/atmel-aic: Fix wrong bit operation for IRQ priority" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

irqchip/atmel-aic: Fix wrong bit operation for IRQ priority

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
irqchip-atmel-aic-fix-wrong-bit-operation-for-irq-priority.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 49f34134aea74f19ca016f055d25ee55ec359dee Mon Sep 17 00:00:00 2001

From: Milo Kim <[email protected]>
Date: Wed, 13 Jan 2016 16:19:50 +0900
Subject: irqchip/atmel-aic: Fix wrong bit operation for IRQ priority

From: Milo Kim <[email protected]>

commit 49f34134aea74f19ca016f055d25ee55ec359dee upstream.

Atmel AIC has common structure for SMR (Source Mode Register).

bit[6:5] Interrupt source type
bit[2:0] Priority level
Other bits are unused.

To update new priority value, bit[2:0] should be cleared first and then new priority level can be written. However, aic_common_set_priority() helper clears source type bits instead of priority bits. This patch fixes wrong mask bit operation.

Fixes b1479ebb7720 "irqchip: atmel-aic: Add atmel AIC/AIC5 drivers"
Cc Jason Cooper <[email protected]>
Cc Marc Zyngier <[email protected]>
Cc Ludovic Desroches <[email protected]>
Cc Nicholas Ferre <[email protected]>
---
 drivers/irqchip/irq-atmel-aic-common.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-atmel-aic-common.c +1 -1
@@ -86,7 +86,7 @@ int aic_common_set_priority(int priority
 	    priority > AT91_AIC_IRQ_MAX_PRIORITY)
 		return -EINVAL;
 
-	*val &= AT91_AIC_PRIOR;
+	*val &= ~AT91_AIC_PRIOR;
 	*val |= priority;
 
 	return 0;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/irqchip-atmel-aic-fix-wrong-bit-operation-for-irq-priority.patch