Skip to contentSkip to conversation

Patch "ACPI / PCI / hotplug: unlock in error path in acpiphp_enable_slot()" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ACPI / PCI / hotplug: unlock in error path in acpiphp_enable_slot()

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
acpi-pci-hotplug-unlock-in-error-path-in-acpiphp_enable_slot.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 2c3033a0664dfae91e1dee7fabac10f24354b958 Mon Sep 17 00:00:00 2001

From: Insu Yun <[email protected]>
Date: Sat, 23 Jan 2016 15:44:19 -0500
Subject: ACPI / PCI / hotplug: unlock in error path in acpiphp_enable_slot()

From: Insu Yun <[email protected]>

commit 2c3033a0664dfae91e1dee7fabac10f24354b958 upstream.

In acpiphp_enable_slot(), there is a missing unlock path when error occurred. It needs to be unlocked before returning an error.

---
 drivers/pci/hotplug/acpiphp_glue.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pci/hotplug/acpiphp_glue.c +3 -1
@@ -1133,8 +1133,10 @@ int acpiphp_enable_slot(struct acpiphp_s
 {
 	pci_lock_rescan_remove();
 
-	if (slot->flags & SLOT_IS_GOING_AWAY)
+	if (slot->flags & SLOT_IS_GOING_AWAY) {
+		pci_unlock_rescan_remove();
 		return -ENODEV;
+	}
 
 	mutex_lock(&slot->crit_sect);
 	/* configure all functions */

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/acpi-pci-hotplug-unlock-in-error-path-in-acpiphp_enable_slot.patch