Skip to contentSkip to conversation

Patch "libceph: don't spam dmesg with stray reply warnings" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

libceph: don't spam dmesg with stray reply warnings

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
libceph-don-t-spam-dmesg-with-stray-reply-warnings.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cd8140c673d9ba9be3591220e1b2226d9e1e40d3 Mon Sep 17 00:00:00 2001

From: Ilya Dryomov <[email protected]>
Date: Fri, 19 Feb 2016 11:38:57 +0100
Subject: libceph: don't spam dmesg with stray reply warnings

From: Ilya Dryomov <[email protected]>

commit cd8140c673d9ba9be3591220e1b2226d9e1e40d3 upstream.

Commit d15f9d694b77 ("libceph: check data_len in ->alloc_msg()") mistakenly bumped the log level on the "tid %llu unknown, skipping" message. Turn it back into a dout() - stray replies are perfectly normal when OSDs flap, crash, get killed for testing purposes, etc.

---
 net/ceph/osd_client.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/ceph/osd_client.c +2 -2
@@ -2843,8 +2843,8 @@ static struct ceph_msg *get_reply(struct
 	mutex_lock(&osdc->request_mutex);
 	req = __lookup_request(osdc, tid);
 	if (!req) {
-		pr_warn("%s osd%d tid %llu unknown, skipping\n",
-			__func__, osd->o_osd, tid);
+		dout("%s osd%d tid %llu unknown, skipping\n", __func__,
+		     osd->o_osd, tid);
 		m = NULL;
 		*skip = 1;
 		goto out;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/libceph-fix-ceph_msg_revoke.patch queue-4.4/tcp-dccp-fix-another-race-at-listener-dismantle.patch queue-4.4/libceph-don-t-spam-dmesg-with-stray-reply-warnings.patch queue-4.4/libceph-don-t-bail-early-from-try_read-when-skipping-a-message.patch queue-4.4/libceph-use-the-right-footer-size-when-skipping-a-message.patch