Patch "libceph: use the right footer size when skipping a message" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
libceph: use the right footer size when skipping a message
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
libceph-use-the-right-footer-size-when-skipping-a-message.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
dbc0d3caff5b7591e0cf8e34ca686ca6f4479ee1Mon Sep 17 00:00:00 2001
From: Ilya Dryomov <[email protected]>
Date: Fri, 19 Feb 2016 11:38:57 +0100
Subject: libceph: use the right footer size when skipping a message
From: Ilya Dryomov <[email protected]>
commit dbc0d3caff5b7591e0cf8e34ca686ca6f4479ee1 upstream.
ceph_msg_footer is 21 bytes long, while ceph_msg_footer_old is only 13. Don't skip too much when CEPH_FEATURE_MSG_AUTH isn't negotiated.
--- net/ceph/messenger.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
net/ceph/messenger.c +9 -2
@@ -1200,6 +1200,13 @@ static bool ceph_msg_data_advance(structreturn new_piece; } +static size_t sizeof_footer (struct ceph_connection *con) +{ +return (con->peer_features &CEPH_FEATURE_MSG_AUTH ) ? +sizeof (struct ceph_msg_footer ) : +sizeof (struct ceph_msg_footer_old ); +} +static void prepare_message_data (struct ceph_msg *msg,u32 data_len) {BUG_ON (!msg);
@@ -2338,7 +2345,7 @@ static int read_partial_message(struct cceph_pr_addr (&con->peer_addr.in_addr), seq, con->in_seq + 1); con->in_base_pos = -front_len - middle_len - data_len - -sizeof (m->footer); +sizeof_footer (con); con->in_tag =CEPH_MSGR_TAG_READY ;return 1 ; }else if ((s64 )seq - (s64 )con->in_seq >1 ) {
@@ -2363,7 +2370,7 @@ static int read_partial_message(struct c/* skip this message */ dout ("alloc_msg said skip message\n" ); con->in_base_pos = -front_len - middle_len - data_len - -sizeof (m->footer); +sizeof_footer (con); con->in_tag =CEPH_MSGR_TAG_READY ; con->in_seq++;return 1 ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/libceph-fix-ceph_msg_revoke.patch queue-4.4/tcp-dccp-fix-another-race-at-listener-dismantle.patch queue-4.4/libceph-don-t-spam-dmesg-with-stray-reply-warnings.patch queue-4.4/libceph-don-t-bail-early-from-try_read-when-skipping-a-message.patch queue-4.4/libceph-use-the-right-footer-size-when-skipping-a-message.patch