Skip to contentSkip to conversation

Patch "perf stat: Do not clean event's private stats" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

perf stat: Do not clean event's private stats

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
perf-stat-do-not-clean-event-s-private-stats.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 3f416f22d1e21709a631189ba169f76fd267b374 Mon Sep 17 00:00:00 2001

From: Jiri Olsa <[email protected]>
Date: Wed, 20 Jan 2016 12:56:34 +0100
Subject: perf stat: Do not clean event's private stats

From: Jiri Olsa <[email protected]>

commit 3f416f22d1e21709a631189ba169f76fd267b374 upstream.

Mel reported stddev reporting was broken due to following commit:

106a94a0f8c2 ("perf stat: Introduce read_counters function")

This commit merged interval and overall counters reading into single read_counters function.

The old interval code cleaned the stddev data for some reason (it's never displayed in interval mode) and the mentioned commit kept on cleaning the stddev data in merged function, which resulted in the stddev not being displayed.

Removing the wrong stddev data cleanup init_stats call.

Reported-and-Tested-by Mel Gorman <[email protected]>
Cc David Ahern <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Fixes 106a94a0f8c2 ("perf stat: Introduce read_counters function")
---
 tools/perf/util/stat.c |    1 -
 1 file changed, 1 deletion(-)
tools/perf/util/stat.c +0 -1
@@ -310,7 +310,6 @@ int perf_stat_process_counter(struct per
 	int i, ret;
 
 	aggr->val = aggr->ena = aggr->run = 0;
-	init_stats(ps->res_stats);
 
 	if (counter->per_pkg)
 		zero_per_pkg(counter);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/perf-stat-do-not-clean-event-s-private-stats.patch