Skip to contentSkip to conversation

Patch "x86/mpx: Fix off-by-one comparison with nr_registers" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

x86/mpx: Fix off-by-one comparison with nr_registers

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
x86-mpx-fix-off-by-one-comparison-with-nr_registers.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9bf148cb0812595bfdf5100bd2c07e9bec9c6ef5 Mon Sep 17 00:00:00 2001

From: Colin Ian King <[email protected]>
Date: Fri, 26 Feb 2016 18:55:31 +0000
Subject: x86/mpx: Fix off-by-one comparison with nr_registers

From: Colin Ian King <[email protected]>

commit 9bf148cb0812595bfdf5100bd2c07e9bec9c6ef5 upstream.

In the unlikely event that regno == nr_registers then we get an array overrun on regoff because the invalid register check is currently off-by-one. Fix this with a check that regno is >= nr_registers instead.

Detected with static analysis using CoverityScan.

Fixes fcc7ffd67991 "x86, mpx: Decode MPX instruction to get bound violation information"
Cc Borislav Petkov <[email protected]>
Cc "Kirill A . Shutemov" <[email protected]>
arch/x86/mm/mpx.c +1 -1
index b2fd67da1701..ef05755a1900 100644
@@ -123,7 +123,7 @@ static int get_reg_offset(struct insn *insn, struct pt_regs *regs,
 		break;
 	}
 
-	if (regno > nr_registers) {
+	if (regno >= nr_registers) {
 		WARN_ONCE(1, "decoded an instruction with an invalid register");
 		return -EINVAL;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/x86-mpx-fix-off-by-one-comparison-with-nr_registers.patch