Skip to contentSkip to conversation

Patch "iwlwifi: mvm: don't allow sched scans without matches to be started" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iwlwifi: mvm: don't allow sched scans without matches to be started

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iwlwifi-mvm-don-t-allow-sched-scans-without-matches-to-be-started.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 00:00:00 2001

From: Luca Coelho <[email protected]>
Date: Tue, 2 Feb 2016 15:11:15 +0200
Subject: iwlwifi: mvm: don't allow sched scans without matches to be started

From: Luca Coelho <[email protected]>

commit 5e56276e7555b34550d51459a801ff75eca8b907 upstream.

The firmware can perform a scheduled scan with not matchsets passed, but it can't send notification that results were found. Since the userspace then cannot know when we got new results and the firmware wouldn't trigger a wake in case we are sleeping, it's better not to allow scans without matchsets.

This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831

---
 drivers/net/wireless/iwlwifi/mvm/scan.c |    4 ++++
 1 file changed, 4 insertions(+)
drivers/net/wireless/iwlwifi/mvm/scan.c +4 -0
@@ -1267,6 +1267,10 @@ int iwl_mvm_sched_scan_start(struct iwl_
 		return -EBUSY;
 	}
 
+	/* we don't support "match all" in the firmware */
+	if (!req->n_match_sets)
+		return -EOPNOTSUPP;
+
 	ret = iwl_mvm_check_running_scans(mvm, type);
 	if (ret)
 		return ret;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/iwlwifi-mvm-don-t-allow-sched-scans-without-matches-to-be-started.patch