armv8: ls2080a: update fdt path for fsl-mc node

PATCH New Stuart Yoder 3 participants 6 messages Mar 2, 2016 – Mar 29, 2016

lore

Share & tools

lore

Stuart Yoder

author

2016-03-02 22:37 UTC #0 lore raw

PATCH 1/1 armv8: ls2080a: update fdt path for fsl-mc node

From: Stuart Yoder <[email protected]>

The fsl-mc node has been moved under /soc, so update the path references accordingly. Backwards compatibility is retained for /fsl-mc.

Delete backwards compatibility for the completely obsolete /fsl,dprc at 0.

Signed-off-by Stuart Yoder <[email protected]>

---
 board/freescale/ls2080a/ls2080a.c       |    6 +++---
 board/freescale/ls2080aqds/ls2080aqds.c |    4 ++--
 board/freescale/ls2080ardb/ls2080ardb.c |    4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

board/freescale/ls2080a/ls2080a.c +3 -3

index 7bce8b0..ace0d79 100644
@@ -87,14 +87,14 @@ void fdt_fixup_board_enet(void *fdt)
 {
 	int offset;
 
-	offset = fdt_path_offset(fdt, "/fsl-mc");
+	offset = fdt_path_offset(fdt, "/soc/fsl-mc");
 
 	/*
 	 * TODO: Remove this when backward compatibility
-	 * with old DT node (fsl,dprc at 0) is no longer needed.
+	 * with old DT node (/fsl-mc) is no longer needed.
 	 */
 	if (offset < 0)
-		offset = fdt_path_offset(fdt, "/fsl,dprc at 0");
+		offset = fdt_path_offset(fdt, "/fsl-mc");
 
 	if (offset < 0) {
 		printf("%s: ERROR: fsl-mc node not found in device tree (error %d)\n",

board/freescale/ls2080aqds/ls2080aqds.c +2 -2

index aa256a2..f3925e2 100644
@@ -258,10 +258,10 @@ void fdt_fixup_board_enet(void *fdt)
 {
 	int offset;
 
-	offset = fdt_path_offset(fdt, "/fsl-mc");
+	offset = fdt_path_offset(fdt, "/soc/fsl-mc");
 
 	if (offset < 0)
-		offset = fdt_path_offset(fdt, "/fsl,dprc at 0");
+		offset = fdt_path_offset(fdt, "/fsl-mc");
 
 	if (offset < 0) {
 		printf("%s: ERROR: fsl-mc node not found in device tree (error %d)\n",

board/freescale/ls2080ardb/ls2080ardb.c +2 -2

index c63b639..6f518b2 100644
@@ -224,10 +224,10 @@ void fdt_fixup_board_enet(void *fdt)
 {
 	int offset;
 
-	offset = fdt_path_offset(fdt, "/fsl-mc");
+	offset = fdt_path_offset(fdt, "/soc/fsl-mc");
 
 	if (offset < 0)
-		offset = fdt_path_offset(fdt, "/fsl,dprc@0");
+		offset = fdt_path_offset(fdt, "/fsl-mc");
 
 	if (offset < 0) {
 		printf("%s: ERROR: fsl-mc node not found in device tree (error %d)\n",

Signature · 1 line

1.7.9.5

Prabhakar Kushwaha

2016-03-03 02:44 UTC #1 lore raw

PATCH 1/1 armv8: ls2080a: update fdt path for fsl-mc node

Quoted 10 lines

-----Original Message-----
From: Stuart Yoder [mailto:stuart.yoder at nxp.com]
Sent: Thursday, March 03, 2016 4:07 AM
To: u-boot at lists.denx.de
Cc: york sun <[email protected]>; Prabhakar Kushwaha <[email protected]>; Yang-Leo Li <[email protected]>; Stuart Yoder <[email protected]>
Subject: [PATCH] armv8: ls2080a: update fdt path for fsl-mc node

Quoted 8 lines

From: Stuart Yoder <[email protected]>
The fsl-mc node has been moved under /soc, so update the path references accordingly. Backwards compatibility is retained for /fsl-mc.
Delete backwards compatibility for the completely obsolete /fsl,dprc at 0.
Signed-off-by Stuart Yoder <[email protected]>

How will backward compatibility maintained for older Linux version which has previous device tree format..

--prabhakar

Stuart Yoder

author

2016-03-03 03:01 UTC #2 lore raw

PATCH 1/1 armv8: ls2080a: update fdt path for fsl-mc node

Quoted 25 lines

-----Original Message-----
From: Prabhakar Kushwaha
Sent: Wednesday, March 02, 2016 8:45 PM
To: Stuart Yoder <[email protected]>; u-boot at lists.denx.de
Cc: york sun <[email protected]>; Yang-Leo Li <[email protected]>; Stuart Yoder <[email protected]>
Subject: RE: [PATCH] armv8: ls2080a: update fdt path for fsl-mc node
Quoted 14 lines
-----Original Message-----
From: Stuart Yoder [mailto:stuart.yoder at nxp.com]
Sent: Thursday, March 03, 2016 4:07 AM
To: u-boot at lists.denx.de
Cc: york sun <[email protected]>; Prabhakar Kushwaha <[email protected]>; Yang-Leo Li <[email protected]>; Stuart Yoder <[email protected]>
Subject: [PATCH] armv8: ls2080a: update fdt path for fsl-mc node
From: Stuart Yoder <[email protected]>
The fsl-mc node has been moved under /soc, so update the path references accordingly. Backwards compatibility is retained for /fsl-mc.

Quoted 6 lines

Quoted 3 lines
Delete backwards compatibility for the completely obsolete /fsl,dprc at 0.
Signed-off-by Stuart Yoder <[email protected]>
How will backward compatibility maintained for older Linux version which has previous device tree format..

As you can see in the patch, we first check /soc/fsl-mc. If that is not there we check /fsl-mc. So, both will work.

Use of /fsl,dprc at 0 I think was Freescale-internal only and there is no actual use of it remaining.

Stuart

york sun

2016-03-22 19:04 UTC #3 lore raw

PATCH 1/1 armv8: ls2080a: update fdt path for fsl-mc node

Quoted 29 lines · Stuart Yoder

Quoted 29 lines
-----Original Message-----
From: Prabhakar Kushwaha
Sent: Wednesday, March 02, 2016 8:45 PM
To: Stuart Yoder <[email protected]>; u-boot at lists.denx.de
Cc: york sun <[email protected]>; Yang-Leo Li <[email protected]>; Stuart Yoder <[email protected]>
Subject: RE: [PATCH] armv8: ls2080a: update fdt path for fsl-mc node
Quoted 17 lines
-----Original Message-----
From: Stuart Yoder [mailto:stuart.yoder at nxp.com]
Sent: Thursday, March 03, 2016 4:07 AM
To: u-boot at lists.denx.de
Cc: york sun <[email protected]>; Prabhakar Kushwaha <[email protected]>; Yang-Leo Li <[email protected]>; Stuart Yoder <[email protected]>
Subject: [PATCH] armv8: ls2080a: update fdt path for fsl-mc node
From: Stuart Yoder <[email protected]>
The fsl-mc node has been moved under /soc, so update the path references accordingly. Backwards compatibility is retained for /fsl-mc.
Delete backwards compatibility for the completely obsolete /fsl,dprc at 0.
Signed-off-by Stuart Yoder <[email protected]>

Quoted 9 lines

Quoted 2 lines
How will backward compatibility maintained for older Linux version which has previous device tree format..
As you can see in the patch, we first check /soc/fsl-mc. If that is not there we check /fsl-mc. So, both will work.
Use of /fsl,dprc at 0 I think was Freescale-internal only and there is no actual use of it remaining.

Prabhakar,

Are you OK with Stuart's answer?

York

Prabhakar Kushwaha

2016-03-23 08:12 UTC #4 lore raw

PATCH 1/1 armv8: ls2080a: update fdt path for fsl-mc node

Quoted 45 lines

-----Original Message-----
From: york sun
Sent: Wednesday, March 23, 2016 12:34 AM
To: Stuart Yoder <[email protected]>; Prabhakar Kushwaha <[email protected]>; u-boot at lists.denx.de
Cc: Yang-Leo Li <[email protected]>
Subject: Re: [PATCH] armv8: ls2080a: update fdt path for fsl-mc node
Quoted 35 lines · Stuart Yoder
Quoted 25 lines
-----Original Message-----
From: Prabhakar Kushwaha
Sent: Wednesday, March 02, 2016 8:45 PM
To: Stuart Yoder <[email protected]>; u-boot at lists.denx.de
Cc: york sun <[email protected]>; Yang-Leo Li <[email protected]>; Stuart Yoder <[email protected]>
Subject: RE: [PATCH] armv8: ls2080a: update fdt path for fsl-mc node
Quoted 14 lines
-----Original Message-----
From: Stuart Yoder [mailto:stuart.yoder at nxp.com]
Sent: Thursday, March 03, 2016 4:07 AM
To: u-boot at lists.denx.de
Cc: york sun <[email protected]>; Prabhakar Kushwaha <[email protected]>; Yang-Leo Li <[email protected]>; Stuart Yoder <[email protected]>
Subject: [PATCH] armv8: ls2080a: update fdt path for fsl-mc node
From: Stuart Yoder <[email protected]>
The fsl-mc node has been moved under /soc, so update the path references accordingly. Backwards compatibility is retained for /fsl-mc.
Quoted 6 lines
Quoted 3 lines
Delete backwards compatibility for the completely obsolete /fsl,dprc at 0.
Signed-off-by Stuart Yoder <[email protected]>
How will backward compatibility maintained for older Linux version which has previous device tree format..
As you can see in the patch, we first check /soc/fsl-mc. If that is not there we check /fsl-mc. So, both will work.

Quoted 8 lines

Quoted 3 lines
Use of /fsl,dprc at 0 I think was Freescale-internal only and there is no actual use of it remaining.
Prabhakar,
Are you OK with Stuart's answer?

Yes York.

--prabhakar

York Sun

2016-03-29 15:40 UTC #5 lore raw

PATCH 1/1 armv8: ls2080a: update fdt path for fsl-mc node

In reply to Stuart Yoder

Quoted 9 lines · Stuart Yoder

From: Stuart Yoder <[email protected]>
The fsl-mc node has been moved under /soc, so update the path references accordingly. Backwards compatibility is retained for /fsl-mc.
Delete backwards compatibility for the completely obsolete /fsl,dprc at 0.

Quoted 6 lines

Signed-off-by Stuart Yoder <[email protected]>

---
 board/freescale/ls2080a/ls2080a.c       |    6 +++---
 board/freescale/ls2080aqds/ls2080aqds.c |    4 ++--
 board/freescale/ls2080ardb/ls2080ardb.c |    4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

Applied to u-boot-fsl-qoriq master. Awaiting upstream.

Thanks.

York