ALSA: hda - hdmi defer to register acomp eld notifier
PATCH 2/2 ALSA: hda - hdmi defer to register acomp eld notifier
From: Libin Yang <[email protected]>
Defer to register acomp eld notifier until hdmi audio driver is fully ready.
After registering eld notifier, gfx driver can use this callback function to notify audio driver the monitor connection event. However this action may happen when audio driver is adding the pins or doing other initialization. This is not always safe, however. For example, using per_pin->lock before the lock is initialized.
Let's register the eld notifier after the initialization is done.
Signed-off-by Libin Yang <[email protected]>
--- sound/pci/hda/patch_hdmi.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
sound/pci/hda/patch_hdmi.c +12 -12
@@ -2936,18 +2936,6 @@ static int patch_generic_hdmi(struct hda_codec *codec) is_broxton(codec)) codec->core.link_power_control =1 ; -if (codec_has_acomp (codec)) { - codec->depop_delay =0 ; - spec->i915_audio_ops.audio_ptr = codec; -/* intel_audio_codec_enable() or intel_audio_codec_disable() -* will call pin_eld_notify with using audio_ptr pointer -* We need make sure audio_ptr is really setup -*/ -wmb (); - spec->i915_audio_ops.pin_eld_notify = intel_pin_eld_notify; -snd_hdac_i915_register_notifier (&spec->i915_audio_ops); - } -if (hdmi_parse_codec (codec) <0 ) {if (spec->i915_bound)snd_hdac_i915_exit (&codec->bus->core);
@@ -2969,6 +2957,18 @@ static int patch_generic_hdmi(struct hda_codec *codec)init_channel_allocations (); +if (codec_has_acomp (codec)) { + codec->depop_delay =0 ; + spec->i915_audio_ops.audio_ptr = codec; +/* intel_audio_codec_enable() or intel_audio_codec_disable() +* will call pin_eld_notify with using audio_ptr pointer +* We need make sure audio_ptr is really setup +*/ +wmb (); + spec->i915_audio_ops.pin_eld_notify = intel_pin_eld_notify; +snd_hdac_i915_register_notifier (&spec->i915_audio_ops); + } +WARN_ON (spec->dyn_pcm_assign && !codec_has_acomp (codec));return 0 ; }
Signature · 1 line
1.9.1