Skip to contentSkip to conversation

kms_frontbuffer_tracking: Remove hardcoded PIPE_A

PATCH In review Gabriel Feceoru 2 participants 2 messages Mar 4, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kms_frontbuffer_tracking: Remove hardcoded PIPE_A

Use the pipe which is given from the possible_crcs for that connected port instead.

On BSW there are constrains for the crtc<-->connector, this fix make this test passing on BSW.

---
 tests/kms_frontbuffer_tracking.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tests/kms_frontbuffer_tracking.c +2 -1
index 634c98b..afdb394 100644
@@ -1432,7 +1432,8 @@ static void setup_crcs(void)
 {
 	enum pixel_format f;
 
-	pipe_crc = igt_pipe_crc_new(0, INTEL_PIPE_CRC_SOURCE_AUTO);
+	int crtc_idx = kmstest_get_crtc_idx(drm.res, prim_mode_params.crtc_id);
+	pipe_crc = igt_pipe_crc_new(crtc_idx, INTEL_PIPE_CRC_SOURCE_AUTO);
 
 	setup_sink_crc();
 
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Em Sex, 2016-03-04 às 12:02 +0200, Gabriel Feceoru escreveu:

Quoted 9 lines

Use the pipe which is given from the possible_crcs for that connected port
instead.

On BSW there are constrains for the crtc<-->connector, this fix make this test
passing on BSW.

Patch pushed. Thanks for catching this!

Quoted 17 lines

---
 tests/kms_frontbuffer_tracking.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)
tests/kms_frontbuffer_tracking.c +0 -0
index 634c98b..afdb394 100644
@@ -1432,7 +1432,8 @@ static void setup_crcs(void)
  {
  	enum pixel_format f;

tests/kms_frontbuffer_tracking.c +1 -1
-	pipe_crc = igt_pipe_crc_new(0, INTEL_PIPE_CRC_SOURCE_AUTO);
+	int crtc_idx = kmstest_get_crtc_idx(drm.res,

prim_mode_params.crtc_id);

tests/kms_frontbuffer_tracking.c +1 -0
+	pipe_crc = igt_pipe_crc_new(crtc_idx,
Quoted 4 lines

INTEL_PIPE_CRC_SOURCE_AUTO);

  setup_sink_crc();

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx