rockchip: make configure_emmc() empty for Firefly-RK3288
Subsystems (3)
PATCH 1/1 rockchip: make configure_emmc() empty for Firefly-RK3288
on v2016.03-rc3, size of SPL image compiled by gcc 5.3.0 is too large for Firefly-RK3288. (it's fine for Rock2)
$ gcc --version gcc (Ubuntu/Linaro 5.3.0-3ubuntu1~14.04) 5.3.0 20151204 Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ ./tools/mkimage -n rk3288 -T rksd -d spl/u-boot-spl-dtb.bin u-boot-spl-dtb.img Warning: SPL image is too large (size 0x80d0) and will not boot
to reduce size of SPL image, this patch makes configure_emmc() empty for Firefly-RK3288 as same as Rock2.
--- arch/arm/mach-rockchip/rk3288-board-spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-rockchip/rk3288-board-spl.c +1 -1
@@ -114,7 +114,7 @@ static void configure_l2ctlr(void)#ifdef CONFIG_SPL_MMC_SUPPORT static int configure_emmc (struct udevice *pinctrl) { -#ifndef CONFIG_TARGET_ROCK2 +#if !defined(CONFIG_TARGET_ROCK2 ) && !defined(CONFIG_TARGET_FIREFLY_RK3288 )struct gpio_desc desc;int ret;
Signature · 1 line
2.7.2
PATCH 1/1 rockchip: make configure_emmc() empty for Firefly-RK3288
Quoted 12 lines · FUKAUMI Naoki
on v2016.03-rc3, size of SPL image compiled by gcc 5.3.0 is too large for Firefly-RK3288. (it's fine for Rock2)
$ gcc --version gcc (Ubuntu/Linaro 5.3.0-3ubuntu1~14.04) 5.3.0 20151204 Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.$ ./tools/mkimage -n rk3288 -T rksd -d spl/u-boot-spl-dtb.bin u-boot-spl-dtb.img Warning: SPL image is too large (size 0x80d0) and will not boot
Quoted 7 lines
to reduce size of SPL image, this patch makes
configure_emmc()empty for Firefly-RK3288 as same as Rock2.Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm/mach-rockchip/rk3288-board-spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 2 lines · FUKAUMI Naoki
on v2016.03-rc3, size of SPL image compiled by gcc 5.3.0 is too large for Firefly-RK3288. (it's fine for Rock2)
...
Quoted 5 lines
to reduce size of SPL image, this patch makes
configure_emmc()empty for Firefly-RK3288 as same as Rock2.Signed-off-by FUKAUMI Naoki <[email protected]>Acked-by Simon Glass <[email protected]>
Fixed booting on my Firefly-RK3288.
Quoted 9 lines
--- arch/arm/mach-rockchip/rk3288-board-spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/mach-rockchip/rk3288-board-spl.c +0
-0
arch/arm/mach-rockchip/rk3288-board-spl.c static void configure_l2ctlr(void) · line 120
Quoted 8 lines
arch/arm/mach-rockchip/rk3288-board-spl.c +1
-1@@ -114,7 +114,7 @@ static void configure_l2ctlr(void)#ifdef CONFIG_SPL_MMC_SUPPORT static int configure_emmc (struct udevice *pinctrl) { -#ifndef CONFIG_TARGET_ROCK2 +#if !defined(CONFIG_TARGET_ROCK2 ) && !defined(CONFIG_TARGET_FIREFLY_RK3288 )struct gpio_desc desc;int ret;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160308/8b6bc896/attachment.sig>
Quoted 7 lines · Vagrant Cascadian
Quoted 2 lines · FUKAUMI Naoki
on v2016.03-rc3, size of SPL image compiled by gcc 5.3.0 is too large for Firefly-RK3288. (it's fine for Rock2)
...
Quoted 3 lines
to reduce size of SPL image, this patch makes
configure_emmc()empty for Firefly-RK3288 as same as Rock2.
Quoted 6 lines
Quoted 2 lines
Signed-off-by FUKAUMI Naoki <[email protected]>Acked-by Simon Glass <[email protected]>Fixed booting on my Firefly-RK3288.
Tested-by Vagrant Cascadian <[email protected]>
Applied to u-boot-rockchip, thanks!