Skip to contentSkip to conversation

OMAP3: am3517_evm: Add BCH8 ECC and UBIFS NAND support

PATCH New Derald D. Woods 3 participants 13 messages Mar 5, 2016 – Mar 8, 2016

lore
Share & tools
lore

Derald D. Woods

author
#0 lore raw

v2 cover OMAP3: am3517_evm: Add BCH8 ECC and UBIFS NAND support

This patch series updates NAND support for the LogicPD AM3517 EVM/EXP development boards and their corresponding System On Modules.

OMAP3: am3517_evm: Use BCH8 ECC for NAND

 include/configs/am3517_evm.h | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

OMAP3: am3517_evm: Add NAND MTD partitions with UBI/UBIFS support

 configs/am3517_evm_defconfig |   2 +
 include/configs/am3517_evm.h | 309 +++++++++++++++++++++----------------------
 2 files changed, 153 insertions(+), 158 deletions(-)
author
#1 lore raw

PATCH v2 1/2 OMAP3: am3517_evm: Use BCH8 ECC for NAND

Select 8-bit BCH ecc-scheme with s/w based error correction
- OMAP_ECC_BCH8_CODE_HW_DETECTION_SW

Signed-off-by Derald D. Woods <[email protected]>
---
 include/configs/am3517_evm.h | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)
include/configs/am3517_evm.h +16 -7
index 4d662ad..98a59c5 100644
@@ -328,8 +328,8 @@
 #define CONFIG_SPL_FRAMEWORK
 #define CONFIG_SPL_BOARD_INIT
 #define CONFIG_SPL_NAND_SIMPLE
-#define CONFIG_SPL_TEXT_BASE		0x40200800
-#define CONFIG_SPL_MAX_SIZE		(54 * 1024)	/* 8 KB for stack */
+#define CONFIG_SPL_TEXT_BASE		0x40200000
+#define CONFIG_SPL_MAX_SIZE		(64 * 1024)
 
 #define CONFIG_SPL_BSS_START_ADDR	0x80000000
 #define CONFIG_SPL_BSS_MAX_SIZE		0x80000		/* 512 KB */

@@ -354,17 +354,26 @@
 #define CONFIG_SPL_LDSCRIPT		"$(CPUDIR)/omap-common/u-boot-spl.lds"
 
 /* NAND boot config */
+#define CONFIG_BCH
+#define CONFIG_SYS_NAND_BUSWIDTH_16BIT
 #define CONFIG_SYS_NAND_5_ADDR_CYCLE
 #define CONFIG_SYS_NAND_PAGE_COUNT	64
 #define CONFIG_SYS_NAND_PAGE_SIZE	2048
 #define CONFIG_SYS_NAND_OOBSIZE		64
-#define CONFIG_SYS_NAND_BLOCK_SIZE	(128*1024)
+#define CONFIG_SYS_NAND_BLOCK_SIZE	(128 * 1024)
 #define CONFIG_SYS_NAND_BAD_BLOCK_POS	NAND_LARGE_BADBLOCK_POS
-#define CONFIG_SYS_NAND_ECCPOS		{2, 3, 4, 5, 6, 7, 8, 9,\
-						10, 11, 12, 13}
+#define CONFIG_SYS_NAND_ECCPOS		{ 2,  3,  4,  5,  6,  7,  8,  9, 10, \
+					 11, 12, 13, 14, 16, 17, 18, 19, 20, \
+					 21, 22, 23, 24, 25, 26, 27, 28, 30, \
+					 31, 32, 33, 34, 35, 36, 37, 38, 39, \
+					 40, 41, 42, 44, 45, 46, 47, 48, 49, \
+					 50, 51, 52, 53, 54, 55, 56 }
+
 #define CONFIG_SYS_NAND_ECCSIZE		512
-#define CONFIG_SYS_NAND_ECCBYTES	3
-#define CONFIG_NAND_OMAP_ECCSCHEME	OMAP_ECC_HAM1_CODE_HW
+#define CONFIG_SYS_NAND_ECCBYTES	13
+#define CONFIG_NAND_OMAP_ECCSCHEME	OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
+#define CONFIG_SYS_NAND_MAX_OOBFREE	2
+#define CONFIG_SYS_NAND_MAX_ECCPOS	56
 #define CONFIG_SYS_NAND_U_BOOT_START	CONFIG_SYS_TEXT_BASE
 #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
Signature · 1 line
2.7.2
#2 lore raw

PATCH 1/2 OMAP3: am3517_evm: Use BCH8 ECC for NAND

Quoted 4 lines · Derald D. Woods

Select 8-bit BCH ecc-scheme with s/w based error correction
- OMAP_ECC_BCH8_CODE_HW_DETECTION_SW

Signed-off-by Derald D. Woods <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160307/b6cb7eb1/attachment.sig>
#3 lore raw

PATCH 1/2 OMAP3: am3517_evm: Use BCH8 ECC for NAND

In reply to Derald D. Woods
Quoted 5 lines · Derald D. Woods

Select 8-bit BCH ecc-scheme with s/w based error correction
- OMAP_ECC_BCH8_CODE_HW_DETECTION_SW

Signed-off-by Derald D. Woods <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160308/dfd00c56/attachment.sig>
author
#4 lore raw

PATCH v2 2/2 OMAP3: am3517_evm: Add NAND MTD partitions with UBI/UBIFS support

In reply to Derald D. Woods

- Add required UBI/UBIFS config definitions
- Add reasonable MTD partition layout
- Remove JFFS2 config definitions
- Drop some CFI verbage and definitions
- Make comment 'one-liners' truly one line
- Improve readability and content arrangement

Signed-off-by Derald D. Woods <[email protected]>
---
 configs/am3517_evm_defconfig |   2 +
 include/configs/am3517_evm.h | 309 +++++++++++++++++++++----------------------
 2 files changed, 153 insertions(+), 158 deletions(-)
configs/am3517_evm_defconfig +2 -0
index cde84fe..c7699e0 100644
@@ -4,9 +4,11 @@ CONFIG_TARGET_AM3517_EVM=y
 CONFIG_SPL=y
 CONFIG_FIT=y
 CONFIG_SYS_PROMPT="AM3517_EVM # "
+CONFIG_SYS_EXTRA_OPTIONS="NAND"
 # CONFIG_CMD_IMI is not set
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_FPGA is not set
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_GPIO=y
 CONFIG_SYS_NS16550=y
include/configs/am3517_evm.h +151 -158

446 lines not on this page · raw message

Signature · 1 line
2.7.2
#5 lore raw

PATCH 2/2 OMAP3: am3517_evm: Add NAND MTD partitions with UBI/UBIFS support

Quoted 8 lines · Derald D. Woods

- Add required UBI/UBIFS config definitions
- Add reasonable MTD partition layout
- Remove JFFS2 config definitions
- Drop some CFI verbage and definitions
- Make comment 'one-liners' truly one line
- Improve readability and content arrangement

Signed-off-by Derald D. Woods <[email protected]>
Reviewed-by Tom Rini <[email protected]>

... but we shouldn't be adding more extra options, we should be converting to Kconfig. Any chance you can find some time to work on starting to convert some of that over for this board at least? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160307/cc23f8bf/attachment.sig>
#6 lore raw

PATCH 2/2 OMAP3: am3517_evm: Add NAND MTD partitions with UBI/UBIFS support

Quoted 10 lines · Tom Rini
Quoted 7 lines · Derald D. Woods

- Add required UBI/UBIFS config definitions
- Add reasonable MTD partition layout
- Remove JFFS2 config definitions
- Drop some CFI verbage and definitions
- Make comment 'one-liners' truly one line
- Improve readability and content arrangement

Quoted 8 lines
Quoted 1 line
Signed-off-by Derald D. Woods <[email protected]>
Reviewed-by Tom Rini <[email protected]>

... but we shouldn't be adding more extra options, we should be converting to Kconfig. Any chance you can find some time to work on starting to convert some of that over for this board at least? Thanks!

Have any OMAP3-ish boards fully converted over fully Kconfig?

Quoted 2 lines

--
Tom

#7 lore raw

PATCH 2/2 OMAP3: am3517_evm: Add NAND MTD partitions with UBI/UBIFS support

Quoted 13 lines · Adam Ford
Quoted 12 lines · Tom Rini
Quoted 8 lines · Derald D. Woods

- Add required UBI/UBIFS config definitions
- Add reasonable MTD partition layout
- Remove JFFS2 config definitions
- Drop some CFI verbage and definitions
- Make comment 'one-liners' truly one line
- Improve readability and content arrangement

Signed-off-by Derald D. Woods <[email protected]>
Quoted 7 lines
Quoted 5 lines
Reviewed-by Tom Rini <[email protected]>

... but we shouldn't be adding more extra options, we should be converting to Kconfig. Any chance you can find some time to work on starting to convert some of that over for this board at least? Thanks!

Have any OMAP3-ish boards fully converted over fully Kconfig?

Nothing has been fully converted over to Kconfig, everything is at the same'ish level. You're thinking DM I think :)

I'm not blocking this patch going in on Kconfig'ing stuff, either.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160307/02bc1682/attachment.sig>
author
#8 lore raw

PATCH v2 2/2 OMAP3: am3517_evm: Add NAND MTD partitions with UBI/UBIFS support

In reply to Tom Rini
Quoted 9 lines · Tom Rini
Quoted 7 lines · Derald D. Woods

- Add required UBI/UBIFS config definitions
- Add reasonable MTD partition layout
- Remove JFFS2 config definitions
- Drop some CFI verbage and definitions
- Make comment 'one-liners' truly one line
- Improve readability and content arrangement

Quoted 10 lines
Quoted 1 line
Signed-off-by Derald D. Woods <[email protected]>
Reviewed-by Tom Rini <[email protected]>

... but we shouldn't be adding more extra options, we should be converting to Kconfig. Any chance you can find some time to work on starting to convert some of that over for this board at least? Thanks!

Signature · 1 line
Tom

What is the best example of it being done correctly? For OMAP3, I have an older BeagleBoard Rev. C4 and the AM3517 EXP to work with. I also have a SAMA5D3 xplained, with an Atmel SoC, and the iMX233 OlinuXino MAXI.

--
Derald

#9 lore raw

PATCH 2/2 OMAP3: am3517_evm: Add NAND MTD partitions with UBI/UBIFS support

Quoted 19 lines · Derald D. Woods
Quoted 17 lines · Tom Rini
Quoted 8 lines · Derald D. Woods

- Add required UBI/UBIFS config definitions
- Add reasonable MTD partition layout
- Remove JFFS2 config definitions
- Drop some CFI verbage and definitions
- Make comment 'one-liners' truly one line
- Improve readability and content arrangement

Signed-off-by Derald D. Woods <[email protected]>
Reviewed-by Tom Rini <[email protected]>

... but we shouldn't be adding more extra options, we should be converting to Kconfig. Any chance you can find some time to work on starting to convert some of that over for this board at least? Thanks!

Quoted 10 lines
Quoted 2 lines

--
Tom

What is the best example of it being done correctly? For OMAP3, I have an older BeagleBoard Rev. C4 and the AM3517 EXP to work with. I also have a SAMA5D3 xplained, with an Atmel SoC, and the iMX233 OlinuXino MAXI.

I know I am behind on helping with these boards, but moving out of my house takes a lot of time, but I would like to help port any/all Logic PD boards that TI doesn't do.

Adam

Quoted 3 lines

--
Derald

#10 lore raw

PATCH 2/2 OMAP3: am3517_evm: Add NAND MTD partitions with UBI/UBIFS support

In reply to Derald D. Woods
Quoted 14 lines · Derald D. Woods
Quoted 13 lines · Tom Rini
Quoted 8 lines · Derald D. Woods

- Add required UBI/UBIFS config definitions
- Add reasonable MTD partition layout
- Remove JFFS2 config definitions
- Drop some CFI verbage and definitions
- Make comment 'one-liners' truly one line
- Improve readability and content arrangement

Signed-off-by Derald D. Woods <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Quoted 8 lines
Quoted 3 lines

... but we shouldn't be adding more extra options, we should be converting to Kconfig. Any chance you can find some time to work on starting to convert some of that over for this board at least? Thanks!

What is the best example of it being done correctly? For OMAP3, I have an older BeagleBoard Rev. C4 and the AM3517 EXP to work with. I also have a SAMA5D3 xplained, with an Atmel SoC, and the iMX233 OlinuXino MAXI.

In this case it's not about board, but about options. CONFIG_NAND needs to go away in favour of NAND being an option in drivers/mtd/nand/Kconfig, and include/configs/ cleaned out. ./tools/moveconfig.py can help here.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160307/457adff2/attachment.sig>
author
#11 lore raw

PATCH v2 2/2 OMAP3: am3517_evm: Add NAND MTD partitions with UBI/UBIFS support

Quoted 24 lines · Tom Rini
Quoted 14 lines · Derald D. Woods
Quoted 13 lines · Tom Rini
Quoted 8 lines · Derald D. Woods

- Add required UBI/UBIFS config definitions
- Add reasonable MTD partition layout
- Remove JFFS2 config definitions
- Drop some CFI verbage and definitions
- Make comment 'one-liners' truly one line
- Improve readability and content arrangement

Signed-off-by Derald D. Woods <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Quoted 8 lines
Quoted 3 lines

... but we shouldn't be adding more extra options, we should be converting to Kconfig. Any chance you can find some time to work on starting to convert some of that over for this board at least? Thanks!

What is the best example of it being done correctly? For OMAP3, I have an older BeagleBoard Rev. C4 and the AM3517 EXP to work with. I also have a SAMA5D3 xplained, with an Atmel SoC, and the iMX233 OlinuXino MAXI.

Quoted 7 lines

In this case it's not about board, but about options. CONFIG_NAND needs to go away in favour of NAND being an option in drivers/mtd/nand/Kconfig, and include/configs/ cleaned out. ./tools/moveconfig.py can help here.

Signature · 1 line
Tom

Thanks. That clarifies things a bit. This will nudge me more towards proper config generation with Kconfig.

Signature · 1 line
Derald
#12 lore raw

PATCH 2/2 OMAP3: am3517_evm: Add NAND MTD partitions with UBI/UBIFS support

In reply to Derald D. Woods
Quoted 9 lines · Derald D. Woods

- Add required UBI/UBIFS config definitions
- Add reasonable MTD partition layout
- Remove JFFS2 config definitions
- Drop some CFI verbage and definitions
- Make comment 'one-liners' truly one line
- Improve readability and content arrangement

Signed-off-by Derald D. Woods <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160308/bb4f9cbc/attachment.sig>