Patch "ALSA: hdspm: Fix wrong boolean ctl value accesses" has been added to the 3.10-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ALSA: hdspm: Fix wrong boolean ctl value accesses
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-hdspm-fix-wrong-boolean-ctl-value-accesses.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
537e48136295c5860a92138c5ea3959b9542868bMon Sep 17 00:00:00 2001
From: Takashi Iwai <[email protected]>
Date: Mon, 29 Feb 2016 14:25:16 +0100
Subject: ALSA: hdspm: Fix wrong boolean ctl value accesses
From: Takashi Iwai <[email protected]>
commit 537e48136295c5860a92138c5ea3959b9542868b upstream.
snd-hdspm driver accesses enum item values (int) instead of boolean values (long) wrongly for some ctl elements. This patch fixes them.
--- sound/pci/rme9652/hdspm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
sound/pci/rme9652/hdspm.c +4 -4
@@ -2091,7 +2091,7 @@ static int snd_hdspm_put_system_sample_r {struct hdspm *hdspm =snd_kcontrol_chip (kcontrol); -hdspm_set_dds_value (hdspm, ucontrol->value.enumerated.item[0 ]); +hdspm_set_dds_value (hdspm, ucontrol->value.integer.value[0 ]);return 0 ; }
@@ -4199,7 +4199,7 @@ static int snd_hdspm_get_tco_word_term(s {struct hdspm *hdspm =snd_kcontrol_chip (kcontrol); - ucontrol->value.enumerated.item[0 ] = hdspm->tco->term; + ucontrol->value.integer.value[0 ] = hdspm->tco->term;return 0 ; }
@@ -4210,8 +4210,8 @@ static int snd_hdspm_put_tco_word_term(s {struct hdspm *hdspm =snd_kcontrol_chip (kcontrol); -if (hdspm->tco->term != ucontrol->value.enumerated.item[0 ]) { - hdspm->tco->term = ucontrol->value.enumerated.item[0 ]; +if (hdspm->tco->term != ucontrol->value.integer.value[0 ]) { + hdspm->tco->term = ucontrol->value.integer.value[0 ];hdspm_tco_write (hdspm);
Patches currently in stable-queue which might be from [email protected] are
queue-3.10/alsa-hdspm-fix-zero-division.patch queue-3.10/alsa-ctl-fix-ioctls-for-x32-abi.patch queue-3.10/alsa-hdspm-fix-wrong-boolean-ctl-value-accesses.patch queue-3.10/alsa-hdsp-fix-wrong-boolean-ctl-value-accesses.patch queue-3.10/alsa-seq-oss-don-t-drain-at-closing-a-client.patch queue-3.10/alsa-timer-fix-ioctls-for-x32-abi.patch queue-3.10/alsa-timer-fix-broken-compat-timer-user-status-ioctl.patch queue-3.10/alsa-rawmidi-fix-ioctls-x32-abi.patch