Skip to contentSkip to conversation

Patch "ubi: Fix out of bounds write in volume update code" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 7, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ubi: Fix out of bounds write in volume update code

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ubi-fix-out-of-bounds-write-in-volume-update-code.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From e4f6daac20332448529b11f09388f1d55ef2084c Mon Sep 17 00:00:00 2001

From: Richard Weinberger <[email protected]>
Date: Sun, 21 Feb 2016 10:53:03 +0100
Subject: ubi: Fix out of bounds write in volume update code

From: Richard Weinberger <[email protected]>

commit e4f6daac20332448529b11f09388f1d55ef2084c upstream.

ubi_start_leb_change() allocates too few bytes. ubi_more_leb_change_data() will write up to req->upd_bytes + ubi->min_io_size bytes.

---
 drivers/mtd/ubi/upd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/ubi/upd.c +1 -1
@@ -193,7 +193,7 @@ int ubi_start_leb_change(struct ubi_devi
 	vol->changing_leb = 1;
 	vol->ch_lnum = req->lnum;
 
-	vol->upd_buf = vmalloc(req->bytes);
+	vol->upd_buf = vmalloc(ALIGN((int)req->bytes, ubi->min_io_size));
 	if (!vol->upd_buf)
 		return -ENOMEM;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/ubi-fix-out-of-bounds-write-in-volume-update-code.patch