Skip to contentSkip to conversation

xmlrpc: fix bug in setting XMLRPCServer.single_use

PATCH Superseded Ed Bartosh 1 participant 1 message Mar 9, 2016

v2 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

Ed Bartosh

author
#0 lore raw

PATCH v2 1/1 xmlrpc: fix bug in setting XMLRPCServer.single_use

XMLRPCServer.single_use attribute was always set to False. This caused xmlrpc server to keep running after build is done as BitBakeServerCommands.removeClient only shuts down server if its single_use attribute is set to True.

---
 bitbake/lib/bb/server/xmlrpc.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
bitbake/lib/bb/server/xmlrpc.py +1 -3
index 1ceca51..7528138 100644
@@ -191,8 +191,7 @@ class XMLRPCServer(SimpleXMLRPCServer, BaseImplServer):
         Constructor
         """
         BaseImplServer.__init__(self)
-        if (interface[1] == 0):     # anonymous port, not getting reused
-            self.single_use = True
+        self.single_use = interface[1] == 0 # anonymous port, not getting reused
         # Use auto port configuration
         if (interface[1] == -1):
             interface = (interface[0], 0)
@@ -205,7 +204,6 @@ class XMLRPCServer(SimpleXMLRPCServer, BaseImplServer):
         self.commands = BitBakeServerCommands(self)
         self.autoregister_all_functions(self.commands, "")
         self.interface = interface
-        self.single_use = False
 
     def addcooker(self, cooker):
         BaseImplServer.addcooker(self, cooker)
Signature · 1 line
2.1.4