imx: mx6ul: skip setting ahb rate

PATCH New Peng Fan 2 participants 5 messages Mar 9, 2016 – Mar 25, 2016 Arm (32-bit)

lore

Share & tools

lore

Peng Fan

author

2016-03-09 08:44 UTC #0 lore raw

PATCH 1/3 imx: mx6ul: skip setting ahb rate

To i.MX6UL, default ARM rate and AHB rate is 396M and 198M, no need to set them.

Signed-off-by Peng Fan <[email protected]>

Cc Stefano Babic <[email protected]>

---
 arch/arm/cpu/armv7/mx6/soc.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

arch/arm/cpu/armv7/mx6/soc.c +12 -7

index bdd41b0..f29901f 100644
@@ -328,13 +328,18 @@ int arch_cpu_init(void)
 	 */
 	init_bandgap();
 
-	/*
-	 * When low freq boot is enabled, ROM will not set AHB
-	 * freq, so we need to ensure AHB freq is 132MHz in such
-	 * scenario.
-	 */
-	if (mxc_get_clock(MXC_ARM_CLK) == 396000000)
-		set_ahb_rate(132000000);
+	if (!IS_ENABLED(CONFIG_MX6UL)) {
+		/*
+		 * When low freq boot is enabled, ROM will not set AHB
+		 * freq, so we need to ensure AHB freq is 132MHz in such
+		 * scenario.
+		 *
+		 * To i.MX6UL, when power up, default ARM core and
+		 * AHB rate is 396M and 132M.
+		 */
+		if (mxc_get_clock(MXC_ARM_CLK) == 396000000)
+			set_ahb_rate(132000000);
+	}
 
 		/* Set perclk to source from OSC 24MHz */
 #if defined(CONFIG_MX6SL)

Signature · 1 line

2.6.2

Peng Fan

author

2016-03-25 09:16 UTC #1 lore raw

PATCH 1/3 imx: mx6ul: skip setting ahb rate

Hi Stefano,

Gentle Ping on the three patches.

Thanks,
Peng.

Quoted 42 lines · Peng Fan

To i.MX6UL, default ARM rate and AHB rate is 396M and 198M, no need to set them.

Signed-off-by Peng Fan <[email protected]>

Cc Stefano Babic <[email protected]>

---
arch/arm/cpu/armv7/mx6/soc.c | 19 ++++++++++++-------

1 file changed, 12 insertions(+), 7 deletions(-)

arch/arm/cpu/armv7/mx6/soc.c +12 -7

index bdd41b0..f29901f 100644
@@ -328,13 +328,18 @@ int arch_cpu_init(void)
 	 */
 	init_bandgap();
 
-	/*
-	 * When low freq boot is enabled, ROM will not set AHB
-	 * freq, so we need to ensure AHB freq is 132MHz in such
-	 * scenario.
-	 */
-	if (mxc_get_clock(MXC_ARM_CLK) == 396000000)
-		set_ahb_rate(132000000);
+	if (!IS_ENABLED(CONFIG_MX6UL)) {
+		/*
+		 * When low freq boot is enabled, ROM will not set AHB
+		 * freq, so we need to ensure AHB freq is 132MHz in such
+		 * scenario.
+		 *
+		 * To i.MX6UL, when power up, default ARM core and
+		 * AHB rate is 396M and 132M.
+		 */
+		if (mxc_get_clock(MXC_ARM_CLK) == 396000000)
+			set_ahb_rate(132000000);
+	}
 
 		/* Set perclk to source from OSC 24MHz */
 #if defined(CONFIG_MX6SL)

Signature · 1 line

2.6.2

Stefano Babic

2016-03-25 12:57 UTC #2 lore raw

PATCH 1/3 imx: mx6ul: skip setting ahb rate

Quoted 44 lines · Peng Fan

Hi Stefano,

Gentle Ping on the three patches.

Thanks,
Peng.

Quoted 37 lines · Peng Fan

To i.MX6UL, default ARM rate and AHB rate is 396M and 198M, no need to set them.

Signed-off-by Peng Fan <[email protected]>

Cc Stefano Babic <[email protected]>

---
arch/arm/cpu/armv7/mx6/soc.c | 19 ++++++++++++-------

1 file changed, 12 insertions(+), 7 deletions(-)

arch/arm/cpu/armv7/mx6/soc.c +12 -7

index bdd41b0..f29901f 100644
@@ -328,13 +328,18 @@ int arch_cpu_init(void)
 	 */
 	init_bandgap();
 
-	/*
-	 * When low freq boot is enabled, ROM will not set AHB
-	 * freq, so we need to ensure AHB freq is 132MHz in such
-	 * scenario.
-	 */
-	if (mxc_get_clock(MXC_ARM_CLK) == 396000000)
-		set_ahb_rate(132000000);
+	if (!IS_ENABLED(CONFIG_MX6UL)) {
+		/*
+		 * When low freq boot is enabled, ROM will not set AHB
+		 * freq, so we need to ensure AHB freq is 132MHz in such
+		 * scenario.
+		 *
+		 * To i.MX6UL, when power up, default ARM core and
+		 * AHB rate is 396M and 132M.
+		 */
+		if (mxc_get_clock(MXC_ARM_CLK) == 396000000)
+			set_ahb_rate(132000000);
+	}

Quoted 5 lines

Quoted 5 lines
arch/arm/cpu/armv7/mx6/soc.c +0 -0
 		/* Set perclk to source from OSC 24MHz */
 #if defined(CONFIG_MX6SL)
Signature · 1 line
2.6.2

Appplied (whole series) to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Peng Fan

author

2016-03-09 08:44 UTC #3 lore raw

PATCH 2/3 imx: mx6ul configure the PMIC_STBY_REQ pin as open drain

In reply to Peng Fan

Configure the PMIC_STBY_REQ pin as open drain 100K according to the design team's requirement for the PMIC_STBY_REQ pin for i.MX 6UltraLite TO1.0.

Signed-off-by Peng Fan <[email protected]>

Cc Stefano Babic <[email protected]>

---
 arch/arm/cpu/armv7/mx6/soc.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

arch/arm/cpu/armv7/mx6/soc.c +11 -1

index f29901f..d4b22ad 100644
@@ -341,7 +341,17 @@ int arch_cpu_init(void)
 			set_ahb_rate(132000000);
 	}
 
-		/* Set perclk to source from OSC 24MHz */
+	if (IS_ENABLED(CONFIG_MX6UL) && is_soc_rev(CHIP_REV_1_0) == 0) {
+		/*
+		 * According to the design team's requirement on i.MX6UL,
+		 * the PMIC_STBY_REQ PAD should be configured as open
+		 * drain 100K (0x0000b8a0).
+		 * Only exists on TO1.0
+		 */
+		writel(0x0000b8a0, IOMUXC_BASE_ADDR + 0x29c);
+	}
+
+	/* Set perclk to source from OSC 24MHz */
 #if defined(CONFIG_MX6SL)
 	set_preclk_from_osc();
 #endif

Signature · 1 line

2.6.2

Peng Fan

author

2016-03-09 08:44 UTC #4 lore raw

PATCH 3/3 imx: print ARM clock for clocks command

In reply to Peng Fan

Default print ARM clock for clocks command.
Test on i.MX6UL 14x14 evk board:
"
=> clocks

PLL_SYS         792 MHz
PLL_BUS         528 MHz
PLL_OTG         480 MHz

PLL_NET 50 MHz

ARM 396000 kHz
"

Signed-off-by Peng Fan <[email protected]>

Cc Stefano Babic <[email protected]>

---
 arch/arm/cpu/armv7/mx6/clock.c | 1 +
 1 file changed, 1 insertion(+)

arch/arm/cpu/armv7/mx6/clock.c +1 -0

index 88380a6..3b53842 100644
@@ -1183,6 +1183,7 @@ int do_mx6_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	printf("PLL_NET    %8d MHz\n", freq / 1000000);
 
 	printf("\n");
+	printf("ARM        %8d kHz\n", mxc_get_clock(MXC_ARM_CLK) / 1000);
 	printf("IPG        %8d kHz\n", mxc_get_clock(MXC_IPG_CLK) / 1000);
 	printf("UART       %8d kHz\n", mxc_get_clock(MXC_UART_CLK) / 1000);
 #ifdef CONFIG_MXC_SPI

Signature · 1 line

2.6.2