livepatch: Fix the error message about unresolvable ambiguity

klp_find_callback() stops the search when sympos is not defined and a second symbol of the same name is found. It means that the current error message about the unresolvable ambiguity always prints "(2 matches)".

Let's remove this information. The total number of occurrences is not much helpful. The author of the patch still must put a non-trivial effort into searching the right position in the object file.

Signed-off-by Petr Mladek <[email protected]>

---
 kernel/livepatch/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

kernel/livepatch/core.c +0 -0

index bc2c85c064c1..f2eda09e8357 100644

Quoted 18 lines · Petr Mladek

klp_find_callback() stops the search when sympos is not defined and a second symbol of the same name is found. It means that the current error message about the unresolvable ambiguity always prints "(2 matches)".

Let's remove this information. The total number of occurrences is not much helpful. The author of the patch still must put a non-trivial effort into searching the right position in the object file.

Signed-off-by Petr Mladek <[email protected]>

---
 kernel/livepatch/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

kernel/livepatch/core.c +0 -0

index bc2c85c064c1..f2eda09e8357 100644

kernel/livepatch/core.c static int klp_find_object_symbol(const char *objname, const char *name, · line 193

Quoted 6 lines

kernel/livepatch/core.c +1 -2

@@ -190,8 +190,8 @@ static int klp_find_object_symbol(const char *objname, const char *name,
 	if (args.addr == 0)
 		pr_err("symbol '%s' not found in symbol table\n", name);
 	else if (args.count > 1 && sympos == 0) {
-		pr_err("unresolvable ambiguity (%lu matches) on symbol '%s' in object '%s'\n",
-		       args.count, name, objname);
+		pr_err("unresolvable ambiguity on symbol '%s' in object '%s'\n",

While you're at it, can you improve the grammar: s/on/for/ ?

"unresolvable ambiguity *for* symbol..."

Either way,

Acked-by Josh Poimboeuf <[email protected]>

Signature · 1 line

Josh

klp_find_callback() stops the search when sympos is not defined and a second symbol of the same name is found. It means that the current error message about the unresolvable ambiguity always prints "(2 matches)".

Let's remove this information. The total number of occurrences is not much helpful. The author of the patch still must put a non-trivial effort into searching the right position in the object file.

Signed-off-by Petr Mladek <[email protected]>