Skip to contentSkip to conversation

Big Endian build cleanups

PATCH In review Vineet Gupta 2 participants 5 messages Mar 11, 2016 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

cover Big Endian build cleanups

Vineet Gupta (2):
ARC: [BE] Select correct CROSS_COMPILE prefix
ARC: [*defconfig] No need to specify CONFIG_CROSS_COMPILE

 arch/arc/Makefile                          | 4 ++++
 arch/arc/configs/axs101_defconfig          | 1 -
 arch/arc/configs/axs103_defconfig          | 1 -
 arch/arc/configs/axs103_smp_defconfig      | 1 -
 arch/arc/configs/nsim_700_defconfig        | 1 -
 arch/arc/configs/nsim_hs_defconfig         | 1 -
 arch/arc/configs/nsim_hs_smp_defconfig     | 1 -
 arch/arc/configs/nsimosci_defconfig        | 1 -
 arch/arc/configs/nsimosci_hs_defconfig     | 1 -
 arch/arc/configs/nsimosci_hs_smp_defconfig | 1 -
 arch/arc/configs/tb10x_defconfig           | 1 -
 arch/arc/configs/vdk_hs38_defconfig        | 1 -
 arch/arc/configs/vdk_hs38_smp_defconfig    | 1 -
 13 files changed, 4 insertions(+), 12 deletions(-)
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/2 ARC: [BE] Select correct CROSS_COMPILE prefix

This allows CONFIG_CPU_BIG_ENDIAN=y to build correctly out of the box, w/o any other tweaks.

Cc Noam Camus <noamc at ezchip.com>
Cc Alexey Brodkin <abrodkin at synopsys.com>
Cc Anton Kolesov <akolesov at synosys.com>
Signed-off-by Vineet Gupta <vgupta at synopsys.com>
---
 arch/arc/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
arch/arc/Makefile +4 -0
index c8230f3395f2..babc09c61c6c 100644
@@ -9,7 +9,11 @@
 UTS_MACHINE := arc
 
 ifeq ($(CROSS_COMPILE),)
+ifndef CONFIG_CPU_BIG_ENDIAN
 CROSS_COMPILE := arc-linux-
+else
+CROSS_COMPILE := arceb-linux-
+endif
 endif
 
 KBUILD_DEFCONFIG := nsim_700_defconfig
Signature · 1 line
2.5.0
Acked-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] ARC: [BE] Select correct CROSS_COMPILE prefix

Hi Vineet,

Quoted 8 lines · Vineet Gupta

This allows CONFIG_CPU_BIG_ENDIAN=y to build correctly out of the box, w/o any other tweaks.

Cc Noam Camus <noamc at ezchip.com>
Cc Alexey Brodkin <abrodkin at synopsys.com>
Cc Anton Kolesov <akolesov at synosys.com>
Signed-off-by Vineet Gupta <vgupta at synopsys.com>

---

Acked-by Alexey Brodkin <abrodkin at synopsys.com>
#3 lore raw

PATCH 2/2 ARC: [*defconfig] No need to specify CONFIG_CROSS_COMPILE

In reply to Vineet Gupta

The problem is with CONFIG_CPU_BIG_ENDIAN=y we still needed .config fixup to override the the defconfig prefix to arceb-linux-

So remove these from defconfig and let user pass this via CROSS_COMPILE environment var or use the default for ENDIAN (per previous patch)

No other arch carries them in defconfigs anyways !

Cc Noam Camus <noamc at ezchip.com>
Cc Alexey Brodkin <abrodkin at synopsys.com>
Cc Anton Kolesov <akolesov at synosys.com>
Signed-off-by Vineet Gupta <vgupta at synopsys.com>
---
 arch/arc/configs/axs101_defconfig          | 1 -
 arch/arc/configs/axs103_defconfig          | 1 -
 arch/arc/configs/axs103_smp_defconfig      | 1 -
 arch/arc/configs/nsim_700_defconfig        | 1 -
 arch/arc/configs/nsim_hs_defconfig         | 1 -
 arch/arc/configs/nsim_hs_smp_defconfig     | 1 -
 arch/arc/configs/nsimosci_defconfig        | 1 -
 arch/arc/configs/nsimosci_hs_defconfig     | 1 -
 arch/arc/configs/nsimosci_hs_smp_defconfig | 1 -
 arch/arc/configs/tb10x_defconfig           | 1 -
 arch/arc/configs/vdk_hs38_defconfig        | 1 -
 arch/arc/configs/vdk_hs38_smp_defconfig    | 1 -
 12 files changed, 12 deletions(-)
arch/arc/configs/axs101_defconfig +0 -1
index 5d4e2a07ad3e..6cdffea3a914 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
arch/arc/configs/axs103_defconfig +0 -1
index 87ee46b237ef..f8b396c9aedb 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
arch/arc/configs/axs103_smp_defconfig +0 -1
index d80daf4f7e73..56128ea2b748 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
arch/arc/configs/nsim_700_defconfig +0 -1
index f41095340b6a..7314f538847b 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_SWAP is not set
arch/arc/configs/nsim_hs_defconfig +0 -1
index cfaa33cb5921..a99dc7a3f0af 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_SWAP is not set
arch/arc/configs/nsim_hs_smp_defconfig +0 -1
index bb2a8dc778b5..59f221fc9a41 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_SWAP is not set
arch/arc/configs/nsimosci_defconfig +0 -1
index 646182e93753..0972e753101a 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_SWAP is not set
arch/arc/configs/nsimosci_hs_defconfig +0 -1
index ceca2541950d..24d9d0e18232 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_SWAP is not set
arch/arc/configs/nsimosci_hs_smp_defconfig +0 -1
index 4b6da90f6f26..6746d01b6d7b 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
arch/arc/configs/tb10x_defconfig +0 -1
index 9b342eaf95ae..4c5118384eb5 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_DEFAULT_HOSTNAME="tb10x"
 CONFIG_SYSVIPC=y
arch/arc/configs/vdk_hs38_defconfig +0 -1
index a07f20de221b..c0d6a010751a 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_CROSS_MEMORY_ATTACH is not set
arch/arc/configs/vdk_hs38_smp_defconfig +0 -1
index 735985974a31..52ec315dc5c9 100644
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="arc-linux-"
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_DEFAULT_HOSTNAME="ARCLinux"
 # CONFIG_CROSS_MEMORY_ATTACH is not set
Signature · 1 line
2.5.0
Acked-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] ARC: [*defconfig] No need to specify CONFIG_CROSS_COMPILE

Hi Vineet,

Quoted 6 lines · Vineet Gupta

The problem is with CONFIG_CPU_BIG_ENDIAN=y we still needed .config fixup to override the the defconfig prefix to arceb-linux-

So remove these from defconfig and let user pass this via CROSS_COMPILE environment var or use the default for ENDIAN (per previous patch)

Quoted 7 lines

No other arch carries them in defconfigs anyways !

Cc Noam Camus <noamc at ezchip.com>
Cc Alexey Brodkin <abrodkin at synopsys.com>
Cc Anton Kolesov <akolesov at synosys.com>
Signed-off-by Vineet Gupta <vgupta at synopsys.com>

---

Acked-by Alexey Brodkin <abrodkin at synopsys.com>