staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c

PATCH In review Juliana Rodrigues 2 participants 4 messages Mar 13, 2016 Staging

lore

Share & tools

lore

Juliana Rodrigues

author

2016-03-13 01:33 UTC #0 lore raw

PATCH 1/1 staging: dgnc: fixed spaces before and after "|" in dgnc_cls.c

This patch fixes the following issue while maintains 80 characters per line:

CHECK: spaces preferred around that '|' (ctx:VxV)
+ writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),

Signed-off-by Juliana Rodrigues <[email protected]>

---
 drivers/staging/dgnc/dgnc_cls.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

drivers/staging/dgnc/dgnc_cls.c +4 -2

index 51db98b..6e1e475 100644
@@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t *ch)
 	/* Clear out UART and FIFO */
 	readb(&ch->ch_cls_uart->txrx);
 
-	writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),
-	       &ch->ch_cls_uart->isr_fcr);
+	writeb((UART_FCR_ENABLE_FIFO |
+		UART_FCR_CLEAR_RCVR  |
+		UART_FCR_CLEAR_XMIT),
+		&ch->ch_cls_uart->isr_fcr);
 	udelay(10);
 
 	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);

Signature · 1 line

2.7.2

Julia Lawall

2016-03-13 03:41 UTC #1 lore raw

Quoted 15 lines · Juliana Rodrigues

This patch fixes the following issue while maintains 80 characters per line:
CHECK: spaces preferred around that '|' (ctx:VxV)
+ writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),
Signed-off-by Juliana Rodrigues <[email protected]>
---
 drivers/staging/dgnc/dgnc_cls.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/dgnc/dgnc_cls.c +0 -0
index 51db98b..6e1e475 100644

drivers/staging/dgnc/dgnc_cls.c static void cls_uart_init(struct channel_t *ch) · line 1173

Quoted 8 lines

drivers/staging/dgnc/dgnc_cls.c +3 -2

@@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t *ch)
 	/* Clear out UART and FIFO */
 	readb(&ch->ch_cls_uart->txrx);
 
-	writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),
-	       &ch->ch_cls_uart->isr_fcr);
+	writeb((UART_FCR_ENABLE_FIFO |
+		UART_FCR_CLEAR_RCVR  |
+		UART_FCR_CLEAR_XMIT),

It doesn't fit on one line any more? Note that the () around the first argument are not necessary either, if that would help to get it to fit into one line.

julia

Quoted 14 lines

drivers/staging/dgnc/dgnc_cls.c +1 -0

+		&ch->ch_cls_uart->isr_fcr);
 	udelay(10);
 
 	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);

Signature · 8 lines

2.7.2

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160313013258.GA17143%40spock.
For more options, visit https://groups.google.com/d/optout.

Juliana Rodrigues

author

2016-03-13 04:11 UTC #2 lore raw

Em Dom, 2016-03-13 às 04:40 +0100, Julia Lawall escreveu:

Quoted 52 lines · Juliana Rodrigues

Quoted 2 lines
This patch fixes the following issue while maintains 80 characters
per line:
Quoted 3 lines

CHECK: spaces preferred around that '|' (ctx:VxV)
+
writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT) ,
Review
Quoted 7 lines
Signed-off-by Juliana Rodrigues <[email protected]>
---
drivers/staging/dgnc/dgnc_cls.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/staging/dgnc/dgnc_cls.c
drivers/staging/dgnc/dgnc_cls.c static void cls_uart_init(struct channel_t
Quoted 4 lines
index 51db98b..6e1e475 100644
drivers/staging/dgnc/dgnc_cls.c +0 -0
@@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t
*ch)
Quoted 4 lines
drivers/staging/dgnc/dgnc_cls.c +0 -0
        /* Clear out UART and FIFO */
        readb(&ch->ch_cls_uart->txrx);
-     writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR _XMIT),
Quoted 4 lines
-            &ch->ch_cls_uart->isr_fcr);
+     writeb((UART_FCR_ENABLE_FIFO |
+             UART_FCR_CLEAR_RCVR |
+             UART_FCR_CLEAR_XMIT),
It doesn't fit on one line any more? Note that the () around the first
argument are not necessary either, if that would help to get it to fit
into one line.
julia
Quoted 4 lines
+             &ch->ch_cls_uart->isr_fcr); udelay(10);

       ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY |
CH_TX_FIFO_LWM);
Quoted 5 lines
--
2.7.2

--
You received this message because you are subscribed to the Google

Quoted 9 lines

Groups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected].
Quoted 1 line
To post to this group, send email to outreachy-kernel@googlegroups.
com.
Quoted 1 line
To view this discussion on the web visit https://groups.google.com/
d/msgid/outreachy-kernel/20160313013258.GA17143%40spock.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.

Thanks, Julia. I'll take a look. :)

Julia Lawall

2016-03-13 04:13 UTC #3 lore raw

Quoted 56 lines · Juliana Rodrigues

Em Dom, 2016-03-13 às 04:40 +0100, Julia Lawall escreveu:
Quoted 55 lines · Juliana Rodrigues
Quoted 2 lines
This patch fixes the following issue while maintains 80 characters
per line:
Quoted 3 lines

CHECK: spaces preferred around that '|' (ctx:VxV)
+
writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT) ,
Review
Quoted 7 lines
Signed-off-by Juliana Rodrigues <[email protected]>
---
drivers/staging/dgnc/dgnc_cls.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/staging/dgnc/dgnc_cls.c
drivers/staging/dgnc/dgnc_cls.c static void cls_uart_init(struct channel_t
Quoted 4 lines
index 51db98b..6e1e475 100644
drivers/staging/dgnc/dgnc_cls.c +0 -0
@@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t
*ch)
Quoted 4 lines
drivers/staging/dgnc/dgnc_cls.c +0 -0
        /* Clear out UART and FIFO */
        readb(&ch->ch_cls_uart->txrx);
-     writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR _XMIT),
Quoted 4 lines
-            &ch->ch_cls_uart->isr_fcr);
+     writeb((UART_FCR_ENABLE_FIFO |
+             UART_FCR_CLEAR_RCVR |
+             UART_FCR_CLEAR_XMIT),
It doesn't fit on one line any more? Note that the () around the first
argument are not necessary either, if that would help to get it to fit
into one line.
julia
Quoted 4 lines
+             &ch->ch_cls_uart->isr_fcr); udelay(10);

       ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY |
CH_TX_FIFO_LWM);
Quoted 5 lines
--
2.7.2

--
You received this message because you are subscribed to the Google
Groups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected].

Quoted 8 lines

Quoted 6 lines
Quoted 1 line
To post to this group, send email to outreachy-kernel@googlegroups.
com.
Quoted 1 line
To view this discussion on the web visit https://groups.google.com/
d/msgid/outreachy-kernel/20160313013258.GA17143%40spock.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.
Thanks, Julia. I'll take a look. :)

While you don't want to top post, it would be helpful to respond directly under the relevant text, so one doesn't have to hunt for the actual message.

Sorry to be so picky, but there are a lot of small details to make the precess efficient.

julia