Skip to contentSkip to conversation

staging: unisys: visornic: Fixed Checkpatch Warnings

PATCH In review Gavin O'Leary 2 participants 2 messages Mar 17, 2016 Staging

lore
Share & tools
lore

Gavin O'Leary

author
#0 lore raw

PATCH 1/1 staging: unisys: visornic: Fixed Checkpatch Warnings

Fixed the coding style checkpatch warnings.

Signed-off-by Gavin O'Leary <[email protected]>
---
 drivers/staging/unisys/visornic/visornic_main.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/staging/unisys/visornic/visornic_main.c +10 -6
index 0519470..0366624 100644
@@ -1218,8 +1218,9 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
 		/* length rcvd is greater than firstfrag in this skb rcv buf  */
 		skb->tail += RCVPOST_BUF_SIZE;	/* amount in skb->data */
 		skb->data_len = skb->len - RCVPOST_BUF_SIZE;	/* amount that
-								   will be in
-								   frag_list */
+								 *  will be in
+								 *  frag_list
+								 */
 	} else {
 		/* data fits in this skb - no chaining - do
 		 * PRECAUTIONARY check

@@ -1315,12 +1316,14 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
 				}
 				if (found_mc)
 					break;	/* accept packet, dest
-						   matches a multicast
-						   address */
+						 *  matches a multicast
+						 *  address
+						 */
 			}
 		} else if (skb->pkt_type == PACKET_HOST) {
 			break;	/* accept packet, h_dest must match vnic
-				   mac address */
+				 * mac address
+				 */
 		} else if (skb->pkt_type == PACKET_OTHERHOST) {
 			/* something is not right */
 			dev_err(&devdata->netdev->dev,

@@ -1619,7 +1622,8 @@ service_resp_queue(struct uiscmdrsp *cmdrsp, struct visornic_devdata *devdata,
 	struct net_device *netdev;
 
 	/* TODO: CLIENT ACQUIRE -- Don't really need this at the
-	 * moment */
+	 * moment
+	 */
 	for (;;) {
 		if (!visorchannel_signalremove(devdata->dev->visorchannel,
 					       IOCHAN_FROM_IOPART,
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 1 line · Gavin O'Leary

Fixed the coding style checkpatch warnings.

Which ones? Always be specific. And only fix one type of thing at a time.

Quoted 11 lines
Signed-off-by Gavin O'Leary <[email protected]>
---
 drivers/staging/unisys/visornic/visornic_main.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/staging/unisys/visornic/visornic_main.c +0 -0
index 0519470..0366624 100644

drivers/staging/unisys/visornic/visornic_main.c visornic_rx(struct uiscmdrsp *cmdrsp) · line 1223

Quoted 8 lines
drivers/staging/unisys/visornic/visornic_main.c +3 -2
@@ -1218,8 +1218,9 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
 		/* length rcvd is greater than firstfrag in this skb rcv buf  */
 		skb->tail += RCVPOST_BUF_SIZE;	/* amount in skb->data */
 		skb->data_len = skb->len - RCVPOST_BUF_SIZE;	/* amount that
-								   will be in
-								   frag_list */
+								 *  will be in
+								 *  frag_list
+								 */

Tell me that looks better :(

Please fix this properly.

thanks,

greg k-h