drivers: staging: unisys: visornic: Fixed block comment coding style warnings

PATCH In review Gavin O'Leary 2 participants 2 messages Mar 17, 2016 Staging

lore

Share & tools

lore

Gavin O'Leary

author

2016-03-17 02:02 UTC #0 lore raw

PATCH 1/1 drivers: staging: unisys: visornic: Fixed block comment coding style warnings

Fixed block comment checkpatch warnings.

Signed-off-by Gavin O'Leary <[email protected]>

---
 drivers/staging/unisys/visornic/visornic_main.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

drivers/staging/unisys/visornic/visornic_main.c +6 -5

index 0519470..eefbacc 100644
@@ -1315,12 +1315,14 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
 				}
 				if (found_mc)
 					break;	/* accept packet, dest
-						   matches a multicast
-						   address */
+						 * matches a multicast
+						 * address
+						 */
 			}
 		} else if (skb->pkt_type == PACKET_HOST) {
 			break;	/* accept packet, h_dest must match vnic
-				   mac address */
+				 * mac address
+				 */
 		} else if (skb->pkt_type == PACKET_OTHERHOST) {
 			/* something is not right */
 			dev_err(&devdata->netdev->dev,

@@ -1618,8 +1620,7 @@ service_resp_queue(struct uiscmdrsp *cmdrsp, struct visornic_devdata *devdata,
 	unsigned long flags;
 	struct net_device *netdev;
 
-	/* TODO: CLIENT ACQUIRE -- Don't really need this at the
-	 * moment */
+	/* TODO: CLIENT ACQUIRE -- Don't really need this at the moment */
 	for (;;) {
 		if (!visorchannel_signalremove(devdata->dev->visorchannel,
 					       IOCHAN_FROM_IOPART,

Signature · 1 line

1.9.1

Greg KH

maintainer

2016-03-17 02:06 UTC #1 lore raw

Quoted 12 lines · Gavin O'Leary

Fixed block comment checkpatch warnings.
Signed-off-by Gavin O'Leary <[email protected]>
---
 drivers/staging/unisys/visornic/visornic_main.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/staging/unisys/visornic/visornic_main.c +0 -0
index 0519470..eefbacc 100644

drivers/staging/unisys/visornic/visornic_main.c visornic_rx(struct uiscmdrsp *cmdrsp) · line 1320

Quoted 8 lines

drivers/staging/unisys/visornic/visornic_main.c +3 -2

@@ -1315,12 +1315,14 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
 				}
 				if (found_mc)
 					break;	/* accept packet, dest
-						   matches a multicast
-						   address */
+						 * matches a multicast
+						 * address
+						 */

That looks horrible, don't you think?

drivers/staging/unisys/visornic/visornic_main.c visornic_rx(struct uiscmdrsp *cmdrsp) · line 1325

Quoted 6 lines

drivers/staging/unisys/visornic/visornic_main.c +2 -1

 			}
 		} else if (skb->pkt_type == PACKET_HOST) {
 			break;	/* accept packet, h_dest must match vnic
-				   mac address */
+				 * mac address
+				 */

Same here.

Please fix up to look better, that's your goal, right?

thanks,

greg k-h