Skip to contentSkip to conversation

staging: unisys: visornic: Made comments look nicer

PATCH In review Gavin O'Leary 2 participants 2 messages Mar 17, 2016 Staging

lore
Share & tools
lore

Gavin O'Leary

author
#0 lore raw

PATCH 1/1 staging: unisys: visornic: Made comments look nicer

Made comments not break coding style guidlines and easier to read.

Signed-off-by Gavin O'Leary <[email protected]>
---
 drivers/staging/unisys/visornic/visornic_main.c | 29 +++++++++++++++----------
 1 file changed, 17 insertions(+), 12 deletions(-)
drivers/staging/unisys/visornic/visornic_main.c +17 -12
index 0519470..50ad44e 100644
@@ -1215,11 +1215,13 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
 					"repost_return failed");
 			return rx_count;
 		}
-		/* length rcvd is greater than firstfrag in this skb rcv buf  */
-		skb->tail += RCVPOST_BUF_SIZE;	/* amount in skb->data */
-		skb->data_len = skb->len - RCVPOST_BUF_SIZE;	/* amount that
-								   will be in
-								   frag_list */
+		/* length rcvd is greater than firstfrag in this skb rcv buf*/
+
+		/*amount in skb->data */
+		skb->tail += RCVPOST_BUF_SIZE;
+
+		/* amount that will be in frag_list */
+		skb->data_len = skb->len - RCVPOST_BUF_SIZE;
 	} else {
 		/* data fits in this skb - no chaining - do
 		 * PRECAUTIONARY check

@@ -1313,14 +1315,18 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
 						break;
 					}
 				}
+
+				/* accept packet, dest matches a multicast
+				 * address
+				 */
 				if (found_mc)
-					break;	/* accept packet, dest
-						   matches a multicast
-						   address */
+					break;
 			}
+
+		/* accept packet, dest matches a multicast address */
 		} else if (skb->pkt_type == PACKET_HOST) {
-			break;	/* accept packet, h_dest must match vnic
-				   mac address */
+			break;
+
 		} else if (skb->pkt_type == PACKET_OTHERHOST) {
 			/* something is not right */
 			dev_err(&devdata->netdev->dev,

@@ -1618,8 +1624,7 @@ service_resp_queue(struct uiscmdrsp *cmdrsp, struct visornic_devdata *devdata,
 	unsigned long flags;
 	struct net_device *netdev;
 
-	/* TODO: CLIENT ACQUIRE -- Don't really need this at the
-	 * moment */
+	/* TODO: CLIENT ACQUIRE -- Don't really need this at the moment */
 	for (;;) {
 		if (!visorchannel_signalremove(devdata->dev->visorchannel,
 					       IOCHAN_FROM_IOPART,
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 12 lines · Gavin O'Leary

Made comments not break coding style guidlines and easier to read.

Signed-off-by Gavin O'Leary <[email protected]>
---
 drivers/staging/unisys/visornic/visornic_main.c | 29 +++++++++++++++----------
 1 file changed, 17 insertions(+), 12 deletions(-)
drivers/staging/unisys/visornic/visornic_main.c +0 -0
index 0519470..50ad44e 100644

drivers/staging/unisys/visornic/visornic_main.c visornic_rx(struct uiscmdrsp *cmdrsp) · line 1219

Quoted 10 lines
drivers/staging/unisys/visornic/visornic_main.c +2 -5
@@ -1215,11 +1215,13 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
 					"repost_return failed");
 			return rx_count;
 		}
-		/* length rcvd is greater than firstfrag in this skb rcv buf  */
-		skb->tail += RCVPOST_BUF_SIZE;	/* amount in skb->data */
-		skb->data_len = skb->len - RCVPOST_BUF_SIZE;	/* amount that
-								   will be in
-								   frag_list */
+		/* length rcvd is greater than firstfrag in this skb rcv buf*/
+

Why the blank line?

drivers/staging/unisys/visornic/visornic_main.c visornic_rx(struct uiscmdrsp *cmdrsp) · line 1220

Quoted 1 line
drivers/staging/unisys/visornic/visornic_main.c +1 -0
+		/*amount in skb->data */

/* amount...

Quoted 8 lines
drivers/staging/unisys/visornic/visornic_main.c +4 -0
+		skb->tail += RCVPOST_BUF_SIZE;
+
+		/* amount that will be in frag_list */
+		skb->data_len = skb->len - RCVPOST_BUF_SIZE;
 	} else {
 		/* data fits in this skb - no chaining - do
 		 * PRECAUTIONARY check

drivers/staging/unisys/visornic/visornic_main.c visornic_rx(struct uiscmdrsp *cmdrsp) · line 1321

Quoted 7 lines
drivers/staging/unisys/visornic/visornic_main.c +4 -0
@@ -1313,14 +1315,18 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
 						break;
 					}
 				}
+
+				/* accept packet, dest matches a multicast
+				 * address
+				 */

Not correct format :(

drivers/staging/unisys/visornic/visornic_main.c visornic_rx(struct uiscmdrsp *cmdrsp) · line 1326

Quoted 8 lines
drivers/staging/unisys/visornic/visornic_main.c +3 -3
 				if (found_mc)
-					break;	/* accept packet, dest
-						   matches a multicast
-						   address */
+					break;
 			}
+
+		/* accept packet, dest matches a multicast address */

Why say it twice?

drivers/staging/unisys/visornic/visornic_main.c visornic_rx(struct uiscmdrsp *cmdrsp) · line 1323

Quoted 3 lines
drivers/staging/unisys/visornic/visornic_main.c +0 -2
 		} else if (skb->pkt_type == PACKET_HOST) {
-			break;	/* accept packet, h_dest must match vnic
-				   mac address */

You dropped this comment?

Please relax, take a day off, and don't rush this, there's nothing I can do with any patches at the moment with the merge window being opened until 2 weeks from now anyway.

greg k-h