Skip to contentSkip to conversation

irqchip: tegra: Switch to use irq_domain_free_irqs_common

PATCH New Axel Lin 2 participants 2 messages Mar 20, 2016

Subsystems (2)
Tegra architecture support irqchip drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 irqchip: tegra: Switch to use irq_domain_free_irqs_common

Current code calls irq_domain_alloc_irqs_parent() in .alloc, so it should call irq_domain_free_irqs_parent() accordingly in .free. Fix it by switching to use irq_domain_free_irqs_common() instead of open-coded.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/irqchip/irq-tegra.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
drivers/irqchip/irq-tegra.c +1 -13
index 121ec30..50be963 100644
@@ -275,22 +275,10 @@ static int tegra_ictlr_domain_alloc(struct irq_domain *domain,
 					    &parent_fwspec);
 }
 
-static void tegra_ictlr_domain_free(struct irq_domain *domain,
-				    unsigned int virq,
-				    unsigned int nr_irqs)
-{
-	unsigned int i;
-
-	for (i = 0; i < nr_irqs; i++) {
-		struct irq_data *d = irq_domain_get_irq_data(domain, virq + i);
-		irq_domain_reset_irq_data(d);
-	}
-}
-
 static const struct irq_domain_ops tegra_ictlr_domain_ops = {
 	.translate	= tegra_ictlr_domain_translate,
 	.alloc		= tegra_ictlr_domain_alloc,
-	.free		= tegra_ictlr_domain_free,
+	.free		= irq_domain_free_irqs_common,
 };
 
 static int __init tegra_ictlr_init(struct device_node *node,
Signature · 1 line
2.1.4
merge bot
#1 lore raw

[tip:irq/urgent] irqchip/tegra: Switch to use irq_domain_free_irqs_common

irqchip/tegra: Switch to use irq_domain_free_irqs_common
Commit-ID:  46f920d8a970cf102e18f25814a4ff4729ad8537
Gitweb:     http://git.kernel.org/tip/46f920d8a970cf102e18f25814a4ff4729ad8537
Author:     Axel Lin <[email protected]>
AuthorDate: Sun, 20 Mar 2016 20:44:05 +0800
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Sun, 20 Mar 2016 20:08:28 +0100

irqchip/tegra: Switch to use irq_domain_free_irqs_common

Current code calls irq_domain_alloc_irqs_parent() in .alloc, so it should call irq_domain_free_irqs_parent() accordingly in .free. Fix it by switching to use irq_domain_free_irqs_common() instead of the open-coded private implementation.

Signed-off-by Axel Lin <[email protected]>
Cc Alexandre Courbot <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Marc Zyngier <[email protected]>
Cc Thierry Reding <[email protected]>
Cc [email protected]
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Thomas Gleixner <[email protected]>
---
 drivers/irqchip/irq-tegra.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
drivers/irqchip/irq-tegra.c +1 -13
index 121ec30..50be963 100644
@@ -275,22 +275,10 @@ static int tegra_ictlr_domain_alloc(struct irq_domain *domain,
 					    &parent_fwspec);
 }
 
-static void tegra_ictlr_domain_free(struct irq_domain *domain,
-				    unsigned int virq,
-				    unsigned int nr_irqs)
-{
-	unsigned int i;
-
-	for (i = 0; i < nr_irqs; i++) {
-		struct irq_data *d = irq_domain_get_irq_data(domain, virq + i);
-		irq_domain_reset_irq_data(d);
-	}
-}
-
 static const struct irq_domain_ops tegra_ictlr_domain_ops = {
 	.translate	= tegra_ictlr_domain_translate,
 	.alloc		= tegra_ictlr_domain_alloc,
-	.free		= tegra_ictlr_domain_free,
+	.free		= irq_domain_free_irqs_common,
 };
 
 static int __init tegra_ictlr_init(struct device_node *node,