gnome-bluetooth: inherit gobject-introspection class
PATCH 1/2 gnome-bluetooth: inherit gobject-introspection class
This fixes introspection support.
--- meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb +1 -1
@@ -11,7 +11,7 @@ SECTION = "x11/gnome" DEPENDS = "systemd gtk+3 libnotify libcanberra" DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}" -inherit gnomebase gtk-icon-cache distro_features_check +inherit gnomebase gtk-icon-cache distro_features_check gobject-introspection REQUIRED_DISTRO_FEATURES = "systemd" SRC_URI[archive.md5sum] = "75d09c924468ec0c687f9ab3acf7f113"
Signature · 1 line
2.7.0
PATCH 2/2 gnome-bluetooth: replace systemd dependency with udev
Now we have an up to date standalone libudev (via eudev), so systemd is no longer required.
--- meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb +1 -4
@@ -6,13 +6,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \ SECTION = "x11/gnome" -# systemd is needed because it has a necessary version of libudev -# Effectively this means that systemd must be in DISTRO_FEATURES -DEPENDS = "systemd gtk+3 libnotify libcanberra" +DEPENDS = "udev gtk+3 libnotify libcanberra" DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}" inherit gnomebase gtk-icon-cache distro_features_check gobject-introspection -REQUIRED_DISTRO_FEATURES = "systemd" SRC_URI[archive.md5sum] = "75d09c924468ec0c687f9ab3acf7f113" SRC_URI[archive.sha256sum] = "d8df073c331df0f97261869fb77ffcdbf4e3e4eaf460d3c3ed2b16e03d9c5398"
Signature · 1 line
2.7.0
Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev
Quoted 13 lines · Alexander Kanavin
Now we have an up to date standalone libudev (via eudev), so systemd is no longer required.
Signed-off-by Alexander Kanavin <[email protected]>--- meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb +0
-0
meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \ · line 12
Quoted 10 lines
meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb +1
-3@@ -6,13 +6,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \ SECTION = "x11/gnome" -# systemd is needed because it has a necessary version of libudev -# Effectively this means that systemd must be in DISTRO_FEATURES -DEPENDS = "systemd gtk+3 libnotify libcanberra" +DEPENDS = "udev gtk+3 libnotify libcanberra" DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}" inherit gnomebase gtk-icon-cache distro_features_check gobject-introspection
So you can remove distro_features_check inherit as well, right?
Quoted 12 lines
meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb +0
-1-REQUIRED_DISTRO_FEATURES = "systemd" SRC_URI[archive.md5sum] = "75d09c924468ec0c687f9ab3acf7f113" SRC_URI[archive.sha256sum] = "d8df073c331df0f97261869fb77ffcdbf4e3e4eaf460d3c3ed2b16e03d9c5398"Signature · 7 lines
2.7.0 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev
Quoted 3 lines · Martin Jansa
Quoted 1 line
inherit gnomebase gtk-icon-cache
distro_features_checkgobject-introspectionSo you can remove
distro_features_checkinherit as well, right?
Yeah, I guess. Feel free to amend.
Alex
Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev
Quoted 7 lines · On Mon, 21 Mar 2016 16:45:02 Alexander Kanavin wrote:
Quoted 4 lines · Martin Jansa
Quoted 2 lines
inherit gnomebase gtk-icon-cache
distro_features_checkgobject-introspection>So you can remove
distro_features_checkinherit as well, right?Yeah, I guess. Feel free to amend.
The reviewer is asking you to do that, although perhaps not in so many words. Can you, please?
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev
Quoted 11 lines · Paul Eggleton
Quoted 7 lines · On Mon, 21 Mar 2016 16:45:02 Alexander Kanavin wrote:
Quoted 4 lines · Martin Jansa
Quoted 2 lines
inherit gnomebase gtk-icon-cache
distro_features_checkgobject-introspection>So you can remove
distro_features_checkinherit as well, right?Yeah, I guess. Feel free to amend.
The reviewer is asking you to do that, although perhaps not in so many words. Can you, please?
Normally I agree with Paul, in this case I made exception and amended it myself when chrry-picking.
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev
In reply to Paul EggletonQuoted 7 lines
Quoted 3 lines
Quoted 1 line
So you can remove
distro_features_checkinherit as well, right?Yeah, I guess. Feel free to amend.
The reviewer is asking you to do that, although perhaps not in so many words.
Can you, please?
I don't believe I should, if the review consists of a single trivial nitpick from the person who also does the actual commits to master. It's less friction and noise for both of us this way.
Alex
Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev
Quoted 11 lines · On Tue, 22 Mar 2016 18:25:25 [email protected] wrote:
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
So you can remove
distro_features_checkinherit as well, right?Yeah, I guess. Feel free to amend.
The reviewer is asking you to do that, although perhaps not in so many words.
Can you, please?I don't believe I should, if the review consists of a single trivial nitpick from the person who also does the actual commits to master. It's less friction and noise for both of us this way.
On the other hand, giving more work to our maintainers is not a good strategy if you want them to stay around.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre