patch "staging: comedi: ni_mio_common: fix the ni_write[blw]() functions" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
staging: comedi: ni_mio_common: fix the ni_write[blw]() functions
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
bd3a3cd6c27b117fb9a43a38c8072c95332beeccMon Sep 17 00:00:00 2001
From: H Hartley Sweeten <[email protected]>
Date: Tue, 22 Mar 2016 10:04:48 -0700
Subject: staging: comedi: ni_mio_common: fix the ni_write[blw]() functions
Memory mapped io (dev->mmio) should not also be writing to the ioport (dev->iobase) registers. Add the missing 'else' to these functions.
--- drivers/staging/comedi/drivers/ni_mio_common.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/comedi/drivers/ni_mio_common.c +6 -6
@@ -246,24 +246,24 @@ static void ni_writel(struct comedi_device *dev, uint32_t data, int reg) {if (dev->mmio)writel (data, dev->mmio + reg); - -outl (data, dev->iobase + reg); +else +outl (data, dev->iobase + reg); }static void ni_writew (struct comedi_device *dev,uint16_t data,int reg) {if (dev->mmio)writew (data, dev->mmio + reg); - -outw (data, dev->iobase + reg); +else +outw (data, dev->iobase + reg); }static void ni_writeb (struct comedi_device *dev,uint8_t data,int reg) {if (dev->mmio)writeb (data, dev->mmio + reg); - -outb (data, dev->iobase + reg); +else +outb (data, dev->iobase + reg); }static uint32_t ni_readl (struct comedi_device *dev,int reg)
Signature · 1 line
2.7.4