Skip to contentSkip to conversation

tests: don't skip kms_panel_fitting when non-eDP connected

PATCH In review Jani Nikula 3 participants 3 messages Mar 23, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests: don't skip kms_panel_fitting when non-eDP connected

kms_panel_fitting skips if there's a non-eDP display connected. Fix it.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93012

---
 tests/kms_panel_fitting.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/kms_panel_fitting.c +3 -2
index 829d9cdd0631..1f9412f6e2d5 100644
@@ -150,8 +150,9 @@ static void test_panel_fitting(data_t *d)
 	for_each_connected_output(display, output) {
 		drmModeModeInfo *mode, native_mode;
 
-		igt_require(output->config.connector->connector_type ==
-			DRM_MODE_CONNECTOR_eDP);
+		if (output->config.connector->connector_type !=
+		    DRM_MODE_CONNECTOR_eDP)
+			continue;
 
 		pipe = output->config.pipe;
 		igt_output_set_pipe(output, pipe);
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Is there a reason why other connectors do not support panel fitting?

Removed the check and using a HDMI connector the test passes...

Quoted 31 lines · Jani Nikula

kms_panel_fitting skips if there's a non-eDP display connected. Fix it.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93012

---
 tests/kms_panel_fitting.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/kms_panel_fitting.c +3 -2
index 829d9cdd0631..1f9412f6e2d5 100644
@@ -150,8 +150,9 @@ static void test_panel_fitting(data_t *d)
 	for_each_connected_output(display, output) {
 		drmModeModeInfo *mode, native_mode;
 
-		igt_require(output->config.connector->connector_type ==
-			DRM_MODE_CONNECTOR_eDP);
+		if (output->config.connector->connector_type !=
+		    DRM_MODE_CONNECTOR_eDP)
+			continue;
 
 		pipe = output->config.pipe;
 		igt_output_set_pipe(output, pipe);
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 1 line · Marius Vlad

Is there a reason why other connectors do not support panel fitting?

LVDS supports it, and with this [1] DSI too. No clue why the test checks for eDP only. What it really should be testing is the presence of the "scaling mode" property, and then it magically works on everything.

There have also been a few half hearted attempts at adding panel fitter support for external displays, but those didn't really go anywhere. My plan for this is that we'd add a "fixed mode" property to all connectors, and then the user could set that to whatever actual display timings they want to use, and the normal mode would then provide the pfit source size just like it does for connectors where we currently enable the panel fitter.

[1] https://lists.freedesktop.org/archives/intel-gfx/2016-March/089786.html

Quoted 42 lines

Removed the check and using a HDMI connector the test passes...

Quoted 31 lines · Jani Nikula

kms_panel_fitting skips if there's a non-eDP display connected. Fix it.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93012

---
 tests/kms_panel_fitting.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/kms_panel_fitting.c +3 -2
index 829d9cdd0631..1f9412f6e2d5 100644
@@ -150,8 +150,9 @@ static void test_panel_fitting(data_t *d)
 	for_each_connected_output(display, output) {
 		drmModeModeInfo *mode, native_mode;
 
-		igt_require(output->config.connector->connector_type ==
-			DRM_MODE_CONNECTOR_eDP);
+		if (output->config.connector->connector_type !=
+		    DRM_MODE_CONNECTOR_eDP)
+			continue;
 
 		pipe = output->config.pipe;
 		igt_output_set_pipe(output, pipe);
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx