Skip to contentSkip to conversation

drm/amd: Beef up ACP Kconfig menu text

PATCH Applied Borislav Petkov 2 participants 2 messages Mar 25, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd: Beef up ACP Kconfig menu text

From: Borislav Petkov <[email protected]>

The current "text" needs a user to use a crystal ball in order to find out what this ACP thing is.

Use the text from

a8fe58cec351 ("drm/amd: add ACP driver support")

to make it a bit more understandable to the rest of the world.

Cc Alex Deucher <[email protected]>
Cc Chunming Zhou <[email protected]>
Cc Jammy Zhou <[email protected]>
Cc Maruthi Bayyavarapu <[email protected]>
Cc Murali Krishna Vemuri <[email protected]>
---
 drivers/gpu/drm/amd/acp/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/acp/Kconfig +6 -2
index 0f734ee05274..ca77ec10147c 100644
@@ -1,10 +1,14 @@
-menu "ACP Configuration"
+menu "ACP (Audio CoProcessor) Configuration"
 
 config DRM_AMD_ACP
-       bool "Enable ACP IP support"
+       bool "Enable AMD Audio CoProcessor IP support"
        select MFD_CORE
        select PM_GENERIC_DOMAINS if PM
        help
 	Choose this option to enable ACP IP support for AMD SOCs.
+	This adds the ACP (Audio CoProcessor) IP driver and wires
+	it up into the amdgpu driver.  The ACP block provides the DMA
+	engine for the i2s-based ALSA driver. It is required for audio
+	on APUs which utilize an i2s codec.
 
 endmenu
Signature · 6 lines
2.7.3

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Applied
#1 lore raw
Quoted 9 lines · Borislav Petkov

From: Borislav Petkov <[email protected]>

The current "text" needs a user to use a crystal ball in order to find out what this ACP thing is.

Use the text from

a8fe58cec351 ("drm/amd: add ACP driver support")

Quoted 8 lines

to make it a bit more understandable to the rest of the world.

Cc Alex Deucher <[email protected]>
Cc Chunming Zhou <[email protected]>
Cc Jammy Zhou <[email protected]>
Cc Maruthi Bayyavarapu <[email protected]>
Cc Murali Krishna Vemuri <[email protected]>

Applied. Thanks!

Alex

Quoted 32 lines
---
 drivers/gpu/drm/amd/acp/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/acp/Kconfig +6 -3
index 0f734ee05274..ca77ec10147c 100644
@@ -1,10 +1,14 @@
-menu "ACP Configuration"
+menu "ACP (Audio CoProcessor) Configuration"
 
 config DRM_AMD_ACP
-       bool "Enable ACP IP support"
+       bool "Enable AMD Audio CoProcessor IP support"
        select MFD_CORE
        select PM_GENERIC_DOMAINS if PM
        help
        Choose this option to enable ACP IP support for AMD SOCs.
+       This adds the ACP (Audio CoProcessor) IP driver and wires
+       it up into the amdgpu driver.  The ACP block provides the DMA
+       engine for the i2s-based ALSA driver. It is required for audio
+       on APUs which utilize an i2s codec.
 
 endmenu
--

2.7.3

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel