Skip to contentSkip to conversation

Documentation/IRQ-domain.txt: Document irq_domain_create_{linear, tree}

PATCH In review Jianyu Zhan 4 participants 5 messages Mar 26, 2016 – Mar 31, 2016 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation/IRQ-domain.txt: Document irq_domain_create_{linear, tree}

They have the same functionalities as irq_domain_add_{linear, tree}, except fro accepting different first argument.

---
 Documentation/IRQ-domain.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/IRQ-domain.txt +12 -0
index 8d990bd..89dda22 100644
@@ -70,6 +70,7 @@ of the reverse map types are described below:
 
 ==== Linear ====
 irq_domain_add_linear()
+irq_domain_create_linear()
 
 The linear reverse map maintains a fixed size table indexed by the
 hwirq number.  When a hwirq is mapped, an irq_desc is allocated for
@@ -81,10 +82,16 @@ map are fixed time lookup for IRQ numbers, and irq_descs are only
 allocated for in-use IRQs.  The disadvantage is that the table must be
 as large as the largest possible hwirq number.
 
+irq_domain_add_linear() and irq_domain_create_linear() are functionally
+equivalent, except for the first argument is different - the former
+accepts an Open Firmware specific 'struct device_node', while the latter
+accepts a more general abstration 'struct fwnode_handle'.
+
 The majority of drivers should use the linear map.
 
 ==== Tree ====
 irq_domain_add_tree()
+irq_domain_create_tree()
 
 The irq_domain maintains a radix tree map from hwirq numbers to Linux
 IRQs.  When an hwirq is mapped, an irq_desc is allocated and the
@@ -95,6 +102,11 @@ since it doesn't need to allocate a table as large as the largest
 hwirq number.  The disadvantage is that hwirq to IRQ number lookup is
 dependent on how many entries are in the table.
 
+irq_domain_add_tree() and irq_domain_create_tree() are functionally
+equivalent, except for the first argument is different - the former
+accepts an Open Firmware specific 'struct device_node', while the latter
+accepts a more general abstration 'struct fwnode_handle'.
+
 Very few drivers should need this mapping.
 
 ==== No Map ===-
Signature · 1 line
2.4.3
reviewer
#1 lore raw
Quoted 21 lines · Jianyu Zhan

They have the same functionalities as irq_domain_add_{linear, tree}, except fro accepting different first argument.

---
 Documentation/IRQ-domain.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/IRQ-domain.txt +1 -0
index 8d990bd..89dda22 100644
@@ -70,6 +70,7 @@ of the reverse map types are described below:
 
 ==== Linear ====
 irq_domain_add_linear()
+irq_domain_create_linear()
 
 The linear reverse map maintains a fixed size table indexed by the
 hwirq number.  When a hwirq is mapped, an irq_desc is allocated for

Documentation/IRQ-domain.txt map are fixed time lookup for IRQ numbers, and irq_descs are only · line 88

Quoted 7 lines
Documentation/IRQ-domain.txt +4 -0
@@ -81,10 +82,16 @@ map are fixed time lookup for IRQ numbers, and irq_descs are only
 allocated for in-use IRQs.  The disadvantage is that the table must be
 as large as the largest possible hwirq number.
 
+irq_domain_add_linear() and irq_domain_create_linear() are functionally
+equivalent, except for the first argument is different - the former
+accepts an Open Firmware specific 'struct device_node', while the latter
+accepts a more general abstration 'struct fwnode_handle'.

abstraction

Quoted 10 lines
Documentation/IRQ-domain.txt +2 -0
+
 The majority of drivers should use the linear map.
 
 ==== Tree ====
 irq_domain_add_tree()
+irq_domain_create_tree()
 
 The irq_domain maintains a radix tree map from hwirq numbers to Linux
 IRQs.  When an hwirq is mapped, an irq_desc is allocated and the

Documentation/IRQ-domain.txt since it doesn't need to allocate a table as large as the largest · line 108

Quoted 7 lines
Documentation/IRQ-domain.txt +4 -0
@@ -95,6 +102,11 @@ since it doesn't need to allocate a table as large as the largest
 hwirq number.  The disadvantage is that hwirq to IRQ number lookup is
 dependent on how many entries are in the table.
 
+irq_domain_add_tree() and irq_domain_create_tree() are functionally
+equivalent, except for the first argument is different - the former
+accepts an Open Firmware specific 'struct device_node', while the latter
+accepts a more general abstration 'struct fwnode_handle'.

ditto

Quoted 5 lines
Documentation/IRQ-domain.txt +1 -0
+
 Very few drivers should need this mapping.
 
 ==== No Map ===-
Signature · 1 line
~Randy
#2 lore raw

PATCH 1/1 Documentation/IRQ-domain.txt: Document irq_domain_create_{linear, tree}

They have the same functionalities as irq_domain_add_{linear, tree}, except fro accepting different first argument.

---
v1->v2:
Fix spelling error.

 Documentation/IRQ-domain.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/IRQ-domain.txt +12 -0
index 8d990bd..89dda22 100644
@@ -70,6 +70,7 @@ of the reverse map types are described below:
 
 ==== Linear ====
 irq_domain_add_linear()
+irq_domain_create_linear()
 
 The linear reverse map maintains a fixed size table indexed by the
 hwirq number.  When a hwirq is mapped, an irq_desc is allocated for
@@ -81,10 +82,16 @@ map are fixed time lookup for IRQ numbers, and irq_descs are only
 allocated for in-use IRQs.  The disadvantage is that the table must be
 as large as the largest possible hwirq number.
 
+irq_domain_add_linear() and irq_domain_create_linear() are functionally
+equivalent, except for the first argument is different - the former
+accepts an Open Firmware specific 'struct device_node', while the latter
+accepts a more general abstraction 'struct fwnode_handle'.
+
 The majority of drivers should use the linear map.
 
 ==== Tree ====
 irq_domain_add_tree()
+irq_domain_create_tree()
 
 The irq_domain maintains a radix tree map from hwirq numbers to Linux
 IRQs.  When an hwirq is mapped, an irq_desc is allocated and the
@@ -95,6 +102,11 @@ since it doesn't need to allocate a table as large as the largest
 hwirq number.  The disadvantage is that hwirq to IRQ number lookup is
 dependent on how many entries are in the table.
 
+irq_domain_add_tree() and irq_domain_create_tree() are functionally
+equivalent, except for the first argument is different - the former
+accepts an Open Firmware specific 'struct device_node', while the latter
+accepts a more general abstraction 'struct fwnode_handle'.
+
 Very few drivers should need this mapping.
 
 ==== No Map ===-
Signature · 1 line
2.4.3
Acked-by on v1 1/1
#3 lore raw
Quoted 10 lines · Jianyu Zhan

They have the same functionalities as irq_domain_add_{linear, tree}, except fro accepting different first argument.

---
v1->v2:
Fix spelling error.

 Documentation/IRQ-domain.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)
	M.
Signature · 1 line
Jazz is not dead. It just smells funny...