Skip to contentSkip to conversation

gdb-cross-canadian: disable conflicting PACKAGECONFIG variables

PATCH In review Jonathan Liu 2 participants 4 messages Mar 27, 2016 – Apr 1, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gdb-cross-canadian: disable conflicting PACKAGECONFIG variables

The PACKAGECONFIG variables in gdb-common.inc don't work correctly for the cross recipes so they need to be disabled.

Python support was not being enabled because the python PACKAGECONFIG added --without-python to OE_EXTRACONF.

The recipe depends on nativesdk-readline and the readline PACKAGECONFIG just adds an unnecessary extra dependency on readline. The --with-system-readline configure argument is explicitly added to EXTRA_OECONF to ensure we link to nativesdk-readline.

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +6 -1
index ae97759..952f28f 100644
@@ -13,7 +13,12 @@ RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python-
 
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
-EXTRA_OECONF_append = " --with-python=${WORKDIR}/python"
+EXTRA_OECONF += "--with-python=${WORKDIR}/python"
+EXTRA_OECONF += "--with-system-readline"
+
+# Disable conflicting PACKAGECONFIG variables in gdb-common.inc
+PACKAGECONFIG[python] = ""
+PACKAGECONFIG[readline] = ""
 
 SSTATE_DUPWHITELIST += "${STAGING_DATADIR}/gdb"
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 21 lines · Jonathan Liu

The PACKAGECONFIG variables in gdb-common.inc don't work correctly for the cross recipes so they need to be disabled.

Python support was not being enabled because the python PACKAGECONFIG added --without-python to OE_EXTRACONF.

The recipe depends on nativesdk-readline and the readline PACKAGECONFIG just adds an unnecessary extra dependency on readline. The --with-system-readline configure argument is explicitly added to EXTRA_OECONF to ensure we link to nativesdk-readline.

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +0 -0
index ae97759..952f28f 100644

meta/recipes-devtools/gdb/gdb-cross-canadian.inc RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python- · line 16

Quoted 5 lines
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +1 -1
@@ -13,7 +13,12 @@ RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python-
 
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
-EXTRA_OECONF_append = " --with-python=${WORKDIR}/python"
+EXTRA_OECONF += "--with-python=${WORKDIR}/python"

should this point to a valid python location ?

Quoted 16 lines
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +5 -1
+EXTRA_OECONF += "--with-system-readline"
+
+# Disable conflicting PACKAGECONFIG variables in gdb-common.inc
+PACKAGECONFIG[python] = ""
+PACKAGECONFIG[readline] = ""
 
 SSTATE_DUPWHITELIST += "${STAGING_DATADIR}/gdb"
 
--

2.7.4

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw

Hi Khem,

Quoted 23 lines · Khem Raj
Quoted 22 lines · Jonathan Liu

The PACKAGECONFIG variables in gdb-common.inc don't work correctly for the cross recipes so they need to be disabled.

Python support was not being enabled because the python PACKAGECONFIG added --without-python to OE_EXTRACONF.

The recipe depends on nativesdk-readline and the readline PACKAGECONFIG just adds an unnecessary extra dependency on readline. The --with-system-readline configure argument is explicitly added to EXTRA_OECONF to ensure we link to nativesdk-readline.

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +0 -0
index ae97759..952f28f 100644
@@ -13,7 +13,12 @@ RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python-
 
Quoted 6 lines

meta/recipes-devtools/gdb/gdb-cross-canadian.inc RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python- · line 16

Quoted 4 lines
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +1 -1
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
-EXTRA_OECONF_append = " --with-python=${WORKDIR}/python"
+EXTRA_OECONF += "--with-python=${WORKDIR}/python"

should this point to a valid python location ?

${WORKDIR}/python is created by do_configure_prepend()

Quoted 11 lines
Quoted 11 lines
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +5 -1
+EXTRA_OECONF += "--with-system-readline"
+
+# Disable conflicting PACKAGECONFIG variables in gdb-common.inc
+PACKAGECONFIG[python] = ""
+PACKAGECONFIG[readline] = ""
 
 SSTATE_DUPWHITELIST += "${STAGING_DATADIR}/gdb"
 
--

2.7.4

Regards,
Jonathan

#3 lore raw
Quoted 7 lines · Jonathan Liu
Quoted 4 lines

meta/recipes-devtools/gdb/gdb-cross-canadian.inc RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python- · line 16

Quoted 2 lines
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +1 -1
-EXTRA_OECONF_append = " --with-python=${WORKDIR}/python"
+EXTRA_OECONF += "--with-python=${WORKDIR}/python"

should this point to a valid python location ?

${WORKDIR}/python is created by do_configure_prepend()

Will it look for this location during execution ?
and will it work when gdb-cross is built from sstate into a different workdir ?