Skip to contentSkip to conversation

cookerdata: Improve handling of ParseError

PATCH New Richard Purdie 1 participant 1 message Mar 28, 2016

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

PATCH 1/1 cookerdata: Improve handling of ParseError

If local.conf contains an invalid line, e.g.:

APPEND += " igor"

(note the leading space) then nasty tracebacks are shown which confuse the user. Change so the parse error is simply shown without a traceback, improving the user experience.

[YOCTO #9332]

Signed-off-by Richard Purdie <[email protected]>
bitbake/lib/bb/cookerdata.py +3 -1
index 9f40674..c5fdf66 100644
@@ -182,7 +182,7 @@ def catch_parse_error(func):
             parselog.critical(traceback.format_exc())
             parselog.critical("Unable to parse %s: %s" % (fn, exc))
             sys.exit(1)
-        except (bb.parse.ParseError, bb.data_smart.ExpansionError) as exc:
+        except bb.data_smart.ExpansionError as exc:
             import traceback
 
             bbdir = os.path.dirname(__file__) + os.sep

@@ -193,6 +193,8 @@ def catch_parse_error(func):
                 if not fn.startswith(bbdir):
                     break
             parselog.critical("Unable to parse %s", fn, exc_info=(exc_class, exc, tb))
+        except bb.parse.ParseError as exc:
+            parselog.critical(str(exc))
             sys.exit(1)
     return wrapped