Add generic PM domain support for Tegra
Subsystems (3)
v8 cover Add generic PM domain support for Tegra
Adds generic PM domain support for Tegra SoCs but this series only enables support for it on Tegra 64-bit devices. There is no reason why this cannot be enable for Tegra 32-bit devices, but to keep the patch series to a minimum only 64-bit devices are enabled so far.
This series has been boot tested on Tegra210 as well as various 32-bit Tegra platforms.
Summary of changes since V7:
- Minor update to DT documentation per Rob H's feedback.
Summary of changes since V6:
- Dropped removal of PM domains, while infrastructure for removing PM domains has been sorted out [4]. Please note that because the PMC driver is never removed, we can simply create the PM domains at the very end of the PMC probe and WARN if any of the PM domains cannot be instantiated.
- Dropped support for subdomains because there is currently no need to support subdomains for Tegra and this simplifies the code substantially.
- Updated DT bindings for Tegra powergates based upon feedback from Thierry Reding.
- Added patch to remove "#power-domain-cells" that in the Tegra210 device-tree source that was added incorrectly.
Summary of changes since V5 [2]:
- Split series into 2 series, separating PMC fixes [3] from genpd changes
- This series is based upon fixes series (which is now in -next)
- Added patch to fix removal of genpd subdomain
- Added patch to get last genpd that was added
- Fixed locking in function to remove genpd
- Updated Tegra PMC driver to ensure power-domains cannot be controlled by both legacy Tegra APIs and generic PM domain framework
- Removed powergate list from Tegra PMC driver and updated removal of power domains to use new genpd APIs.
Summary of changes since V4 [1]:
- Re-worked fix to handle base address on probe failure
- Added patch to lock around simultaneuous accesses to PMC registers
- Added patch to change powergate and rail IDs to unsigned type
- Added patch to fix testing of powergate state
- Updated patch to check for valid powergates to use a bitmap
- Updated Tegra DT PMC bindings per Rob H's feedback
- Updated Tegra power domains binding per Thierry's feedback
- Updated Tegra generic power domain support per Thierry's feedback
Summary of changes since V3 [0]:
- Dropped tegra124 support for now
- Removed MC flush support per feedback from Thierry
- Cleaned up the PMC changes per feedback from Thierry
- Added support for tegra210
[0] http://comments.gmane.org/gmane.linux.ports.tegra/22944
[1] http://marc.info/?l=linux-tegra&m=144924153600529&w=2
[2] http://marc.info/?l=linux-tegra&m=145399885003830&w=2
[3] http://marc.info/?l=linux-tegra&m=145521381331144&w=2
[4] http://marc.info/?l=linux-pm&m=145709064407085&w=2
Jon Hunter (4):
ARM64: tegra: Remove unused #power-domain-cells property
Documentation: DT: bindings: Add power domain info for NVIDIA PMC
soc: tegra: pmc: Add generic PM domain support
ARM64: tegra: select PM_GENERIC_DOMAINS
.../bindings/arm/tegra/nvidia,tegra20-pmc.txt | 80 ++++ arch/arm64/Kconfig.platforms | 2 + arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 - drivers/soc/tegra/pmc.c | 485 ++++++++++++++++++--- include/soc/tegra/pmc.h | 1 + 5 files changed, 507 insertions(+), 63 deletions(-)
Signature · 1 line
2.1.4
A message that is not in the archive (sent off-list or not yet received): 1459329316-27293-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
PATCH v8 1/4 ARM64: tegra: Remove unused #power-domain-cells property
Remove the "#power-domain-cells" property which was incorrectly included by commit e53095857166 ("arm64: tegra: Add Tegra210 support").
--- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/nvidia/tegra210.dtsi +0 -2
@@ -580,8 +580,6 @@ reg = <0x0 0x7000e400 0x0 0x400>; clocks = <&tegra_car TEGRA210_CLK_PCLK>, <&clk32k_in>; clock-names = "pclk", "clk32k_in"; - - #power-domain-cells = <1>; }; fuse@0,7000f800 {
Signature · 1 line
2.1.4
A message that is not in the archive (sent off-list or not yet received): 1459329316-27293-2-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Thierry Reding
AppliedRe: [PATCH V8 1/4] ARM64: tegra: Remove unused #power-domain-cells property
Quoted 8 lines · Jon Hunter
Remove the "#power-domain-cells" property which was incorrectly included by commit
e53095857166("arm64: tegra: Add Tegra210 support").Signed-off-by Jon Hunter <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 -- 1 file changed, 2 deletions(-)
Applied, thanks.
Thierry
PATCH v8 3/4 soc: tegra: pmc: Add generic PM domain support
In reply to a message not in the archiveAdds generic PM support to the PMC driver where the PM domains are populated from device-tree and the PM domain consumer devices are bound to their relevant PM domains via device-tree as well.
Update the tegra_powergate_sequence_power_up() API so that internally it calls the same tegra_powergate_xxx functions that are used by the tegra generic power domain code for consistency.
To ensure that the Tegra power domains (a.k.a powergates) cannot be controlled via both the legacy tegra_powergate_xxx functions as well as the generic PM domain framework, add a bit map for available powergates that can be controlled via the legacy powergate functions.
Move the majority of the tegra_powergate_remove_clamping() function to a sub-function, so that this can be used by both the legacy and generic power domain code.
This is based upon work by Thierry Reding <[email protected]> and Vince Hsu <[email protected]>.
--- drivers/soc/tegra/pmc.c | 485 ++++++++++++++++++++++++++++++++++++++++++------ include/soc/tegra/pmc.h | 1 + 2 files changed, 425 insertions(+), 61 deletions(-)
drivers/soc/tegra/pmc.c +424 -61
@@ -31,10 +31,13 @@#include <linux/iopoll.h> #include <linux/of.h> #include <linux/of_address.h> +#include <linux/of_platform.h> #include <linux/platform_device.h> +#include <linux/pm_domain.h> #include <linux/reboot.h> #include <linux/reset.h> #include <linux/seq_file.h> +#include <linux/slab.h> #include <linux/spinlock.h> #include <soc/tegra/common.h>
@@ -102,6 +105,16 @@#define GPU_RG_CNTRL 0x2d4 +struct tegra_powergate { +struct generic_pm_domain genpd; +struct tegra_pmc *pmc; +unsigned int id; +struct clk **clks; +unsigned int num_clks; +struct reset_control **resets; +unsigned int num_resets; +}; +struct tegra_pmc_soc {unsigned int num_powergates;const char *const *powergates;
@@ -132,6 +145,7 @@ struct tegra_pmc_soc {* @cpu_pwr_good_en: CPU power good signal is enabled * @lp0_vec_phys: physical base address of the LP0 warm boot code * @lp0_vec_size: size of the LP0 warm boot code +* @powergates_available: Bitmap of available power gates * @powergates_lock: mutex for power gate register access */ struct tegra_pmc {
@@ -156,6 +170,7 @@ struct tegra_pmc {bool cpu_pwr_good_en;u32 lp0_vec_phys;u32 lp0_vec_size; +DECLARE_BITMAP (powergates_available,TEGRA_POWERGATE_MAX );struct mutex powergates_lock; };
@@ -165,6 +180,12 @@ static struct tegra_pmc *pmc = &(struct tegra_pmc) { .suspend_mode = TEGRA_SUSPEND_NONE, }; +static inline struct tegra_powergate * +to_powergate (struct generic_pm_domain *domain) +{ + return container_of(domain, struct tegra_powergate, genpd); +} +static u32 tegra_pmc_readl (unsigned long offset) {return readl (pmc->base + offset);
@@ -188,6 +209,31 @@ static inline bool tegra_powergate_is_valid(int id)return (pmc->soc && pmc->soc->powergates[id]); } +static inline bool tegra_powergate_is_available (int id) +{ +return test_bit (id, pmc->powergates_available); +} + +static int tegra_powergate_lookup (struct tegra_pmc *pmc,const char *name) +{ +unsigned int i; + +if (!pmc || !pmc->soc || !name) +return -EINVAL ; + +for (i =0 ; i < pmc->soc->num_powergates; i++) { +if (!tegra_powergate_is_valid (i)) +continue ; + +if (!strcmp (name, pmc->soc->powergates[i])) +return i; + } + +dev_err (pmc->dev,"powergate %s not found\n" , name); + +return -ENODEV ; +} +/** * tegra_powergate_set() - set the state of a partition * @id: partition ID
@@ -218,13 +264,219 @@ static int tegra_powergate_set(unsigned int id, bool new_state)return err; } +static int __tegra_powergate_remove_clamping (unsigned int id) +{ +u32 mask; + +mutex_lock (&pmc->powergates_lock); + +/* +* On Tegra124 and later, the clamps for the GPU are controlled by a +* separate register (with different semantics). +*/ +if (id ==TEGRA_POWERGATE_3D ) { +if (pmc->soc->has_gpu_clamps) { +tegra_pmc_writel (0 ,GPU_RG_CNTRL ); + goto out; + } + } + +/* +* Tegra 2 has a bug where PCIE and VDE clamping masks are +* swapped relatively to the partition ids +*/ +if (id ==TEGRA_POWERGATE_VDEC ) + mask = (1 <<TEGRA_POWERGATE_PCIE ); +else if (id ==TEGRA_POWERGATE_PCIE ) + mask = (1 <<TEGRA_POWERGATE_VDEC ); +else + mask = (1 << id); + +tegra_pmc_writel (mask,REMOVE_CLAMPING ); + +out: +mutex_unlock (&pmc->powergates_lock); + +return 0 ; +} + +static void tegra_powergate_disable_clocks (struct tegra_powergate *pg) +{ +unsigned int i; + +for (i =0 ; i < pg->num_clks; i++) +clk_disable_unprepare (pg->clks[i]); +} + +static int tegra_powergate_enable_clocks (struct tegra_powergate *pg) +{ +unsigned int i; +int err; + +for (i =0 ; i < pg->num_clks; i++) { + err =clk_prepare_enable (pg->clks[i]); +if (err) + goto out; + } + +return 0 ; + +out: +while (i--) +clk_disable_unprepare (pg->clks[i]); + +return err; +} + +static int tegra_powergate_reset_assert (struct tegra_powergate *pg) +{ +unsigned int i; +int err; + +for (i =0 ; i < pg->num_resets; i++) { + err =reset_control_assert (pg->resets[i]); +if (err) +return err; + } + +return 0 ; +} + +static int tegra_powergate_reset_deassert (struct tegra_powergate *pg) +{ +unsigned int i; +int err; + +for (i =0 ; i < pg->num_resets; i++) { + err =reset_control_deassert (pg->resets[i]); +if (err) +return err; + } + +return 0 ; +} + +static int tegra_powergate_power_up (struct tegra_powergate *pg, +bool disable_clocks) +{ +int err; + + err =tegra_powergate_reset_assert (pg); +if (err) +return err; + +usleep_range (10 ,20 ); + + err =tegra_powergate_set (pg->id, true); +if (err <0 ) +return err; + +usleep_range (10 ,20 ); + + err =tegra_powergate_enable_clocks (pg); +if (err) + goto disable_clks; + +usleep_range (10 ,20 ); + + err =__tegra_powergate_remove_clamping (pg->id); +if (err) + goto disable_clks; + +usleep_range (10 ,20 ); + + err =tegra_powergate_reset_deassert (pg); +if (err) + goto powergate_off; + +usleep_range (10 ,20 ); + +if (disable_clocks) +tegra_powergate_disable_clocks (pg); + +return 0 ; + +disable_clks: +tegra_powergate_disable_clocks (pg); +usleep_range (10 ,20 ); +powergate_off: +tegra_powergate_set (pg->id, false); + +return err; +} + +static int tegra_powergate_power_down (struct tegra_powergate *pg) +{ +int err; + + err =tegra_powergate_enable_clocks (pg); +if (err) +return err; + +usleep_range (10 ,20 ); + + err =tegra_powergate_reset_assert (pg); +if (err) + goto disable_clks; + +usleep_range (10 ,20 ); + +tegra_powergate_disable_clocks (pg); + +usleep_range (10 ,20 ); + + err =tegra_powergate_set (pg->id, false); +if (err) + goto assert_resets; + +return 0 ; + +assert_resets: +tegra_powergate_enable_clocks (pg); +usleep_range (10 ,20 ); +tegra_powergate_reset_deassert (pg); +usleep_range (10 ,20 ); +disable_clks: +tegra_powergate_disable_clocks (pg); + +return err; +} + +static int tegra_genpd_power_on (struct generic_pm_domain *domain) +{ +struct tegra_powergate *pg =to_powergate (domain); +struct tegra_pmc *pmc = pg->pmc; +int err; + + err =tegra_powergate_power_up (pg, true); +if (err) +dev_err (pmc->dev,"failed to turn on PM domain %s: %d\n" , + pg->genpd.name, err); + +return err; +} + +static int tegra_genpd_power_off (struct generic_pm_domain *domain) +{ +struct tegra_powergate *pg =to_powergate (domain); +struct tegra_pmc *pmc = pg->pmc; +int err; + + err =tegra_powergate_power_down (pg); +if (err) +dev_err (pmc->dev,"failed to turn off PM domain %s: %d\n" , + pg->genpd.name, err); + +return err; +} +/** * tegra_powergate_power_on() - power on partition * @id: partition ID */ int tegra_powergate_power_on (unsigned int id) { -if (!tegra_powergate_is_valid (id)) +if (!tegra_powergate_is_available (id))return -EINVAL ;return tegra_powergate_set (id, true);
@@ -236,7 +488,7 @@ int tegra_powergate_power_on(unsigned int id)*/ int tegra_powergate_power_off (unsigned int id) { -if (!tegra_powergate_is_valid (id)) +if (!tegra_powergate_is_available (id))return -EINVAL ;return tegra_powergate_set (id, false);
@@ -267,41 +519,10 @@ int tegra_powergate_is_powered(unsigned int id)*/ int tegra_powergate_remove_clamping (unsigned int id) { -u32 mask; - -if (!tegra_powergate_is_valid (id)) +if (!tegra_powergate_is_available (id))return -EINVAL ; -mutex_lock (&pmc->powergates_lock); - -/* -* On Tegra124 and later, the clamps for the GPU are controlled by a -* separate register (with different semantics). -*/ -if (id ==TEGRA_POWERGATE_3D ) { -if (pmc->soc->has_gpu_clamps) { -tegra_pmc_writel (0 ,GPU_RG_CNTRL ); - goto out; - } - } - -/* -* Tegra 2 has a bug where PCIE and VDE clamping masks are -* swapped relatively to the partition ids -*/ -if (id ==TEGRA_POWERGATE_VDEC ) - mask = (1 <<TEGRA_POWERGATE_PCIE ); -else if (id ==TEGRA_POWERGATE_PCIE ) - mask = (1 <<TEGRA_POWERGATE_VDEC ); -else - mask = (1 << id); - -tegra_pmc_writel (mask,REMOVE_CLAMPING ); - -out: -mutex_unlock (&pmc->powergates_lock); - -return 0 ; +return __tegra_powergate_remove_clamping (id); }EXPORT_SYMBOL (tegra_powergate_remove_clamping);
@@ -316,35 +537,20 @@ EXPORT_SYMBOL(tegra_powergate_remove_clamping);int tegra_powergate_sequence_power_up (unsigned int id,struct clk *clk,struct reset_control *rst) { -int ret; - -reset_control_assert (rst); - - ret =tegra_powergate_power_on (id); -if (ret) - goto err_power; - - ret =clk_prepare_enable (clk); -if (ret) - goto err_clk; - -usleep_range (10 ,20 ); +struct tegra_powergate pg; +int err; - ret =tegra_powergate_remove_clamping (id); -if (ret) - goto err_clamp; + pg.id = id; + pg.clks = &clk; + pg.num_clks =1 ; + pg.resets = &rst; + pg.num_resets =1 ; -usleep_range (10 ,20 ); -reset_control_deassert (rst); - -return 0 ; + err =tegra_powergate_power_up (&pg, false); +if (err) +pr_err ("failed to turn on partition %d: %d\n" , id, err); -err_clamp: -clk_disable_unprepare (clk); -err_clk: -tegra_powergate_power_off (id); -err_power: -return ret; +return err; }EXPORT_SYMBOL (tegra_powergate_sequence_power_up);
@@ -486,6 +692,155 @@ static int tegra_powergate_debugfs_init(void)return 0 ; } +static int tegra_powergate_of_get_clks (struct tegra_powergate *pg, +struct device_node *np) +{ +struct clk *clk; +unsigned int i, count; +int err; + + count =of_count_phandle_with_args (np,"clocks" ,"#clock-cells" ); +if (count ==0 ) +return -ENODEV ; + + pg->clks =kcalloc (count,sizeof (clk),GFP_KERNEL ); +if (!pg->clks) +return -ENOMEM ; + +for (i =0 ; i < count; i++) { + pg->clks[i] =of_clk_get (np, i); +if (IS_ERR (pg->clks[i])) { + err =PTR_ERR (pg->clks[i]); + goto err; + } + } + + pg->num_clks = count; + +return 0 ; + +err: +while (i--) +clk_put (pg->clks[i]); +kfree (pg->clks); + +return err; +} + +static int tegra_powergate_of_get_resets (struct tegra_powergate *pg, +struct device_node *np) +{ +struct reset_control *rst; +unsigned int i, count; +int err; + + count =of_count_phandle_with_args (np,"resets" ,"#reset-cells" ); +if (count ==0 ) +return -ENODEV ; + + pg->resets =kcalloc (count,sizeof (rst),GFP_KERNEL ); +if (!pg->resets) +return -ENOMEM ; + +for (i =0 ; i < count; i++) { + pg->resets[i] =of_reset_control_get_by_index (np, i); +if (IS_ERR (pg->resets[i])) { + err =PTR_ERR (pg->resets[i]); + goto error; + } + } + + pg->num_resets = count; + +return 0 ; + +error: +while (i--) +reset_control_put (pg->resets[i]); +kfree (pg->resets); + +return err; +} + +static void tegra_powergate_add (struct tegra_pmc *pmc,struct device_node *np) +{ +struct tegra_powergate *pg; +bool off; +int id; + + pg =kzalloc (sizeof (*pg),GFP_KERNEL ); +if (!pg) + goto error; + + id =tegra_powergate_lookup (pmc, np->name); +if (id <0 ) + goto free_mem; + +/* +* Clear the bit for this powergate so it cannot be managed +* directly via the legacy APIs for controlling powergates. +*/ +clear_bit (id, pmc->powergates_available); + + pg->id = id; + pg->genpd.name = np->name; + pg->genpd.power_off = tegra_genpd_power_off; + pg->genpd.power_on = tegra_genpd_power_on; + pg->pmc = pmc; + +if (tegra_powergate_of_get_clks (pg, np)) + goto set_available; + +if (tegra_powergate_of_get_resets (pg, np)) + goto remove_clks; + + off = !tegra_powergate_is_powered (pg->id); + +pm_genpd_init (&pg->genpd,NULL , off); + +if (of_genpd_add_provider_simple (np, &pg->genpd)) + goto remove_resets; + +dev_dbg (pmc->dev,"added power domain %s\n" , pg->genpd.name); + +return ; + +remove_resets: +while (pg->num_resets--) +reset_control_put (pg->resets[pg->num_resets]); +kfree (pg->resets); + +remove_clks: +while (pg->num_clks--) +clk_put (pg->clks[pg->num_clks]); +kfree (pg->clks); + +set_available: +set_bit (id, pmc->powergates_available); + +free_mem: +kfree (pg); + +error: +dev_err (pmc->dev,"failed to create power domain for %s\n" , np->name); +} + +static void tegra_powergate_init (struct tegra_pmc *pmc) +{ +struct device_node *np, *child; + + np =of_get_child_by_name (pmc->dev->of_node,"powergates" ); +if (!np) +return ; + +for_each_child_of_node (np, child) { +tegra_powergate_add (pmc, child); +of_node_put (child); + } + +of_node_put (np); +} +static int tegra_io_rail_prepare (unsigned int id,unsigned long *request,unsigned long *status,unsigned int *bit) {
@@ -887,6 +1242,8 @@ static int tegra_pmc_probe(struct platform_device *pdev)return err; } +tegra_powergate_init (pmc); +mutex_lock (&pmc->powergates_lock);iounmap (pmc->base); pmc->base = base;
@@ -1120,6 +1477,7 @@ static int __init tegra_pmc_early_init(void)const struct of_device_id *match;struct device_node *np;struct resource regs; +unsigned int i;bool invert;u32 value;
@@ -1169,6 +1527,11 @@ static int __init tegra_pmc_early_init(void)return -ENXIO ; } +/* Create a bit-map of the available and valid partitions */ +for (i =0 ; i < pmc->soc->num_powergates; i++) +if (pmc->soc->powergates[i]) +set_bit (i, pmc->powergates_available); +mutex_init (&pmc->powergates_lock);/*
include/soc/tegra/pmc.h +1 -0
@@ -72,6 +72,7 @@ int tegra_pmc_cpu_remove_clamping(unsigned int cpuid);#define TEGRA_POWERGATE_AUD 27#define TEGRA_POWERGATE_DFD 28#define TEGRA_POWERGATE_VE2 29 +#define TEGRA_POWERGATE_MAX TEGRA_POWERGATE_VE2#define TEGRA_POWERGATE_3D0 TEGRA_POWERGATE_3D
Signature · 1 line
2.1.4
PATCH v8 4/4 ARM64: tegra: select PM_GENERIC_DOMAINS
In reply to a message not in the archiveEnable PM_GENERIC_DOMAINS for tegra 64-bit devices. To ensure that devices dependent upon a particular power-domain are only probed when that power domain has been powered up, requires that PM is made mandatory for tegra 64-bit devices and so select this option for tegra as well.
--- arch/arm64/Kconfig.platforms | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/Kconfig.platforms +2 -0
@@ -129,6 +129,8 @@ config ARCH_TEGRA select GENERIC_CLOCKEVENTS select HAVE_CLK select PINCTRL + select PM + select PM_GENERIC_DOMAINS select RESET_CONTROLLER help This enables support for the NVIDIA Tegra SoC family.
Signature · 6 lines
2.1.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 1459329316-27293-5-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Thierry Reding
AppliedRe: [PATCH V8 4/4] ARM64: tegra: select PM_GENERIC_DOMAINS
Quoted 10 lines · Jon Hunter
Enable
PM_GENERIC_DOMAINSfor tegra 64-bit devices. To ensure that devices dependent upon a particular power-domain are only probed when that power domain has been powered up, requires that PM is made mandatory for tegra 64-bit devices and so select this option for tegra as well.Signed-off-by Jon Hunter <[email protected]>Reviewed-by Ulf Hansson <[email protected]>--- arch/arm64/Kconfig.platforms | 2 ++ 1 file changed, 2 insertions(+)
Applied, thanks.
Thierry
Ulf Hansson
Reviewed-byQuoted 70 lines · Jon Hunter
Adds generic PM domain support for Tegra SoCs but this series only enables support for it on Tegra 64-bit devices. There is no reason why this cannot be enable for Tegra 32-bit devices, but to keep the patch series to a minimum only 64-bit devices are enabled so far.
This series has been boot tested on Tegra210 as well as various 32-bit Tegra platforms.
Summary of changes since V7:
- Minor update to DT documentation per Rob H's feedback.Summary of changes since V6:
- Dropped removal of PM domains, while infrastructure for removing PM domains has been sorted out [4]. Please note that because the PMC driver is never removed, we can simply create the PM domains at the very end of the PMC probe and WARN if any of the PM domains cannot be instantiated.
- Dropped support for subdomains because there is currently no need to support subdomains for Tegra and this simplifies the code substantially.
- Updated DT bindings for Tegra powergates based upon feedback from Thierry Reding.
- Added patch to remove "#power-domain-cells" that in the Tegra210 device-tree source that was added incorrectly.Summary of changes since V5 [2]:
- Split series into 2 series, separating PMC fixes [3] from genpd changes
- This series is based upon fixes series (which is now in -next)
- Added patch to fix removal of genpd subdomain
- Added patch to get last genpd that was added
- Fixed locking in function to remove genpd
- Updated Tegra PMC driver to ensure power-domains cannot be controlled by both legacy Tegra APIs and generic PM domain framework
- Removed powergate list from Tegra PMC driver and updated removal of power domains to use new genpd APIs.Summary of changes since V4 [1]:
- Re-worked fix to handle base address on probe failure
- Added patch to lock around simultaneuous accesses to PMC registers
- Added patch to change powergate and rail IDs to unsigned type
- Added patch to fix testing of powergate state
- Updated patch to check for valid powergates to use a bitmap
- Updated Tegra DT PMC bindings per Rob H's feedback
- Updated Tegra power domains binding per Thierry's feedback
- Updated Tegra generic power domain support per Thierry's feedbackSummary of changes since V3 [0]:
- Dropped tegra124 support for now
- Removed MC flush support per feedback from Thierry
- Cleaned up the PMC changes per feedback from Thierry
- Added support for tegra210[0] http://comments.gmane.org/gmane.linux.ports.tegra/22944
[1] http://marc.info/?l=linux-tegra&m=144924153600529&w=2
[2] http://marc.info/?l=linux-tegra&m=145399885003830&w=2
[3] http://marc.info/?l=linux-tegra&m=145521381331144&w=2
[4] http://marc.info/?l=linux-pm&m=145709064407085&w=2Jon Hunter (4):
ARM64: tegra: Remove unused #power-domain-cells property
Documentation: DT: bindings: Add power domain info for NVIDIA PMC
soc: tegra: pmc: Add generic PM domain support
ARM64: tegra: selectPM_GENERIC_DOMAINS.../bindings/arm/tegra/nvidia,tegra20-pmc.txt | 80 ++++ arch/arm64/Kconfig.platforms | 2 + arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 - drivers/soc/tegra/pmc.c | 485 ++++++++++++++++++--- include/soc/tegra/pmc.h | 1 + 5 files changed, 507 insertions(+), 63 deletions(-)
Quoted 3 lines
--
2.1.4
For the series:
Kind regards
Uffe
Jon Hunter
maintainerPATCH v8 2/4 Documentation: DT: bindings: Add power domain info for NVIDIA PMC
In reply to Jon HunterAdd power-domain binding documentation for the NVIDIA PMC driver in order to support generic power-domains.
--- .../bindings/arm/tegra/nvidia,tegra20-pmc.txt | 80 ++++++++++++++++++++++ 1 file changed, 80 insertions(+)
Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.txt +80 -0
@@ -1,5 +1,7 @@ NVIDIA Tegra Power Management Controller (PMC) +== Power Management Controller Node == + The PMC block interacts with an external Power Management Unit. The PMC mostly controls the entry and exit of the system from different sleep modes. It provides power-gating controllers for SoC and CPU power-islands.
@@ -70,6 +72,11 @@ Optional properties for hardware-triggered thermal reset (inside 'i2c-thermtrip' Defaults to 0. Valid values are described in section 12.5.2 "Pinmux Support" of the Tegra4 Technical Reference Manual. +Optional nodes: +- powergates : This node contains a hierarchy of power domain nodes, which + should match the powergates on the Tegra SoC. See "Powergate + Nodes" below. + Example: / SoC dts including file
@@ -115,3 +122,76 @@ pmc@7000f400 { }; ... }; + + +== Powergate Nodes == + +Each of the powergate nodes represents a power-domain on the Tegra SoC +that can be power-gated by the Tegra PMC. The name of the powergate node +should be one of the below. Note that not every powergate is applicable +to all Tegra devices and the following list shows which powergates are +applicable to which devices. Please refer to the Tegra TRM for more +details on the various powergates. + + Name Description Devices Applicable + 3d 3D Graphics Tegra20/114/124/210 + 3d0 3D Graphics 0 Tegra30 + 3d1 3D Graphics 1 Tegra30 + aud Audio Tegra210 + dfd Debug Tegra210 + dis Display A Tegra114/124/210 + disb Display B Tegra114/124/210 + heg 2D Graphics Tegra30/114/124/210 + iram Internal RAM Tegra124/210 + mpe MPEG Encode All + nvdec NVIDIA Video Decode Engine Tegra210 + nvjpg NVIDIA JPEG Engine Tegra210 + pcie PCIE Tegra20/30/124/210 + sata SATA Tegra30/124/210 + sor Display interfaces Tegra124/210 + ve2 Video Encode Engine 2 Tegra210 + venc Video Encode Engine All + vdec Video Decode Engine Tegra20/30/114/124 + vic Video Imaging Compositor Tegra124/210 + xusba USB Partition A Tegra114/124/210 + xusbb USB Partition B Tegra114/124/210 + xusbc USB Partition C Tegra114/124/210 + +Required properties: + - clocks: Must contain an entry for each clock required by the PMC for + controlling a power-gate. See ../clocks/clock-bindings.txt for details. + - resets: Must contain an entry for each reset required by the PMC for + controlling a power-gate. See ../reset/reset.txt for details. + - #power-domain-cells: Must be 0. + +Example: + + pmc: pmc@7000e400 { + compatible = "nvidia,tegra210-pmc"; + reg = <0x0 0x7000e400 0x0 0x400>; + clocks = <&tegra_car TEGRA210_CLK_PCLK>, <&clk32k_in>; + clock-names = "pclk", "clk32k_in"; + + powergates { + pd_audio: aud { + clocks = <&tegra_car TEGRA210_CLK_APE>, + <&tegra_car TEGRA210_CLK_APB2APE>; + resets = <&tegra_car 198>; + #power-domain-cells = <0>; + }; + }; + }; + + +== Powergate Clients == + +Hardware blocks belonging to a power domain should contain a "power-domains" +property that is a phandle pointing to the corresponding powergate node. + +Example: + + adma: adma@702e2000 { + ... + power-domains = <&pd_audio>; + ... + };
Signature · 1 line
2.1.4
Quoted 7 lines · Jon Hunter
Adds generic PM domain support for Tegra SoCs but this series only enables support for it on Tegra 64-bit devices. There is no reason why this cannot be enable for Tegra 32-bit devices, but to keep the patch series to a minimum only 64-bit devices are enabled so far.
This series has been boot tested on Tegra210 as well as various 32-bit Tegra platforms.
Kevin