drm: bridge/dw-hdmi: Remove pre_enable/post_disable dummy funcs
Subsystems (3)
PATCH 1/1 drm: bridge/dw-hdmi: Remove pre_enable/post_disable dummy funcs
We don't need to keep empty callbacks for the (pre/post) enable/disable drm_bridge ops anymore. Remove the nop callback used here for pre_enable and post_disable ops.
--- drivers/gpu/drm/bridge/dw-hdmi.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/gpu/drm/bridge/dw-hdmi.c +0 -7
@@ -1413,11 +1413,6 @@ static void dw_hdmi_bridge_enable(struct drm_bridge *bridge)mutex_unlock (&hdmi->mutex); } -static void dw_hdmi_bridge_nop (struct drm_bridge *bridge) -{ -/* do nothing */ -} -static enum drm_connector_status dw_hdmi_connector_detect (struct drm_connector *connector,bool force) {
@@ -1536,8 +1531,6 @@ static const struct drm_connector_helper_funcs dw_hdmi_connector_helper_funcs =static const struct drm_bridge_funcs dw_hdmi_bridge_funcs = { .enable = dw_hdmi_bridge_enable, .disable = dw_hdmi_bridge_disable, - .pre_enable = dw_hdmi_bridge_nop, - .post_disable = dw_hdmi_bridge_nop, .mode_set = dw_hdmi_bridge_mode_set, };
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter
AppliedQuoted 5 lines · Archit Taneja
We don't need to keep empty callbacks for the (pre/post) enable/disable
drm_bridgeops anymore. Remove the nop callback used here forpre_enableandpost_disableops.Signed-off-by Archit Taneja <[email protected]>
Applied to drm-misc, thanks.
-Daniel
Quoted 33 lines
--- drivers/gpu/drm/bridge/dw-hdmi.c | 7 ------- 1 file changed, 7 deletions(-)drivers/gpu/drm/bridge/dw-hdmi.c +0
-7@@ -1413,11 +1413,6 @@ static void dw_hdmi_bridge_enable(struct drm_bridge *bridge)mutex_unlock (&hdmi->mutex); } -static void dw_hdmi_bridge_nop (struct drm_bridge *bridge) -{ -/* do nothing */ -} -static enum drm_connector_status dw_hdmi_connector_detect (struct drm_connector *connector,bool force) {@@ -1536,8 +1531,6 @@ static const struct drm_connector_helper_funcs dw_hdmi_connector_helper_funcs =static const struct drm_bridge_funcs dw_hdmi_bridge_funcs = { .enable = dw_hdmi_bridge_enable, .disable = dw_hdmi_bridge_disable, - .pre_enable = dw_hdmi_bridge_nop, - .post_disable = dw_hdmi_bridge_nop, .mode_set = dw_hdmi_bridge_mode_set, };Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Archit,
Thank you for the patch.
Quoted 5 lines · On Wednesday 30 Mar 2016 14:53:24 Archit Taneja wrote:
We don't need to keep empty callbacks for the (pre/post) enable/disable
drm_bridgeops anymore. Remove the nop callback used here forpre_enableandpost_disableops.Signed-off-by Archit Taneja <[email protected]>
Quoted 29 lines
--- drivers/gpu/drm/bridge/dw-hdmi.c | 7 ------- 1 file changed, 7 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/bridge/dw-hdmi.cindex 9795b724..c9d9412 100644drivers/gpu/drm/bridge/dw-hdmi.c +0
-5@@ -1413,11 +1413,6 @@ static void dw_hdmi_bridge_enable(struct drm_bridge *bridge) mutex_unlock(&hdmi->mutex); } -static void dw_hdmi_bridge_nop (struct drm_bridge *bridge) -{ -/* do nothing */ -} -static enum drm_connector_status dw_hdmi_connector_detect (struct drm_connector *connector,bool force) {@@ -1536,8 +1531,6 @@ static const struct drm_connector_helper_funcs
dw_hdmi_connector_helper_funcs= static const structdrm_bridge_funcsdw_hdmi_bridge_funcs= {drivers/gpu/drm/bridge/dw-hdmi.c +0
-2.enable = dw_hdmi_bridge_enable, .disable = dw_hdmi_bridge_disable, - .pre_enable = dw_hdmi_bridge_nop, - .post_disable = dw_hdmi_bridge_nop, .mode_set = dw_hdmi_bridge_mode_set, };
Signature · 8 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel