opkg-build: Exit when fail to list files.

PATCH New Aníbal Limón 1 participant 1 message Mar 31, 2016

Share & tools

Aníbal Limón

author

2016-03-31 21:25 UTC #0 lore raw

PATCH 1/1 opkg-build: Exit when fail to list files.

We have an issue when ls segfaults in some cases [1] so it's better to detect the failure at this level instead of continue the build process.

[YOCTO #8926]

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8926#c0

Signed-off-by Aníbal Limón <[email protected]>

---
 opkg-build | 8 ++++++++
 1 file changed, 8 insertions(+)

opkg-build +8 -0

index 98008b6..a9ccad2 100755
@@ -53,6 +53,10 @@ pkg_appears_sane() {
 		echo "*** Warning: The following files have names ending in '~'.
 You probably want to remove them: " >&2
 		ls -ld $tilde_files
+		if [ $? -ne 0 ]; then
+			echo "*** Error: Fail to list files have names ending in '~'."
+			exit 1
+		fi
 		echo >&2
 	    else
 		echo "*** Removing the following files: $tilde_files"

@@ -66,6 +70,10 @@ You probably want to remove them: " >&2
 		echo "*** Warning: The following files have a UID greater than 99.
 You probably want to chown these to a system user: " >&2
 		ls -ld $large_uid_files
+		if [ $? -ne 0 ]; then
+			echo "*** Error: Fail to list files have a UID greater than 99."
+			exit 1
+		fi
 		echo >&2
 	fi

Signature · 1 line

2.1.4