Skip to contentSkip to conversation

kms_atomic: Skip rather than fail on non-atomic drivers

PATCH In review Matt Roper 2 participants 3 messages Apr 4, 2016 – Apr 5, 2016

lore
Share & tools
lore

Matt Roper

author
#0 lore raw

PATCH 1/1 kms_atomic: Skip rather than fail on non-atomic drivers

i915 does not yet support the atomic modesetting interface by default; at the moment it must be turned on explicitly via an 'i915.nuclear_pageflip' kernel command line option. We should skip (rather than fail) this IGT test when running on kernels that don't advertise support for atomic modesetting.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93014

---
 tests/kms_atomic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_atomic.c +1 -1
index 2f3080a..6a6cfa7 100644
@@ -723,7 +723,7 @@ static void atomic_setup(struct kms_atomic_state *state)
 	desc->fd = drm_open_driver_master(DRIVER_INTEL);
 	igt_assert_fd(desc->fd);
 
-	do_or_die(drmSetClientCap(desc->fd, DRM_CLIENT_CAP_ATOMIC, 1));
+	igt_skip_on(drmSetClientCap(desc->fd, DRM_CLIENT_CAP_ATOMIC, 1));
 
 	res = drmModeGetResources(desc->fd);
 	res_plane = drmModeGetPlaneResources(desc->fd);
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 5 lines · Matt Roper

i915 does not yet support the atomic modesetting interface by default; at the moment it must be turned on explicitly via an 'i915.nuclear_pageflip' kernel command line option. We should skip (rather than fail) this IGT test when running on kernels that don't advertise support for atomic modesetting.

That was certainly the intention.

Cheers,
Daniel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#2 lore raw
Quoted 9 lines · Daniel Stone

Hi,

Quoted 5 lines · Matt Roper

i915 does not yet support the atomic modesetting interface by default; at the moment it must be turned on explicitly via an 'i915.nuclear_pageflip' kernel command line option. We should skip (rather than fail) this IGT test when running on kernels that don't advertise support for atomic modesetting.

Quoted 6 lines

That was certainly the intention.

Cheers,
Daniel

Thanks for the review; pushed.

Matt

Signature · 9 lines
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx