Skip to contentSkip to conversation

cpufreq: logging consistency changes

PATCH In review Joe Perches 5 participants 13 messages Apr 5, 2016 – Apr 22, 2016

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover cpufreq: logging consistency changes

Trivial consistency changes.

Joe Perches (3):
intel_pstate: Use pr_fmt
cpufreq: Convert printk(KERN_<LEVEL> to pr_<level>
cpufreq: Use consistent prefixing via pr_fmt

 drivers/cpufreq/acpi-cpufreq.c            | 16 +++---
 drivers/cpufreq/cpufreq-nforce2.c         | 28 +++++------
 drivers/cpufreq/e_powersaver.c            | 62 ++++++++++-------------
 drivers/cpufreq/elanfreq.c                |  4 +-
 drivers/cpufreq/ia64-acpi-cpufreq.c       | 10 ++--
 drivers/cpufreq/intel_pstate.c            | 18 ++++---
 drivers/cpufreq/longhaul.c                | 84 +++++++++++++------------------
 drivers/cpufreq/loongson2_cpufreq.c       |  7 ++-
 drivers/cpufreq/maple-cpufreq.c           | 11 ++--
 drivers/cpufreq/omap-cpufreq.c            |  7 ++-
 drivers/cpufreq/p4-clockmod.c             | 19 ++-----
 drivers/cpufreq/pmac32-cpufreq.c          | 14 +++---
 drivers/cpufreq/pmac64-cpufreq.c          | 47 +++++++++--------
 drivers/cpufreq/powernow-k6.c             | 16 +++---
 drivers/cpufreq/powernow-k7.c             | 70 +++++++++++---------------
 drivers/cpufreq/pxa2xx-cpufreq.c          | 18 +++----
 drivers/cpufreq/s3c2412-cpufreq.c         | 15 +++---
 drivers/cpufreq/s3c2440-cpufreq.c         |  6 ++-
 drivers/cpufreq/s3c24xx-cpufreq-debugfs.c |  4 +-
 drivers/cpufreq/s3c24xx-cpufreq.c         | 59 +++++++++++-----------
 drivers/cpufreq/s5pv210-cpufreq.c         | 10 ++--
 drivers/cpufreq/sc520_freq.c              | 10 ++--
 drivers/cpufreq/speedstep-centrino.c      |  6 +--
 drivers/cpufreq/speedstep-ich.c           |  8 +--
 drivers/cpufreq/speedstep-lib.c           | 11 ++--
 drivers/cpufreq/speedstep-smi.c           |  7 +--
 26 files changed, 269 insertions(+), 298 deletions(-)
Signature · 1 line
2.8.0.rc4.16.g56331f8
#1 lore raw

PATCH 1/3 intel_pstate: Use pr_fmt

Prefix the output using the more common kernel style.

---
 drivers/cpufreq/intel_pstate.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/cpufreq/intel_pstate.c +10 -8
index a382195..e674db8 100644
@@ -10,6 +10,8 @@
  * of the License.
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/kernel_stat.h>
 #include <linux/module.h>
@@ -436,7 +438,7 @@ static ssize_t store_no_turbo(struct kobject *a, struct attribute *b,
 
 	update_turbo_state();
 	if (limits->turbo_disabled) {
-		pr_warn("intel_pstate: Turbo disabled by BIOS or unavailable on processor\n");
+		pr_warn("Turbo disabled by BIOS or unavailable on processor\n");
 		return -EPERM;
 	}
 
@@ -1107,7 +1109,7 @@ static int intel_pstate_init_cpu(unsigned int cpunum)
 
 	intel_pstate_busy_pid_reset(cpu);
 
-	pr_debug("intel_pstate: controlling: cpu %d\n", cpunum);
+	pr_debug("controlling: cpu %d\n", cpunum);
 
 	return 0;
 }
@@ -1149,12 +1151,12 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy)
 
 	if (policy->policy == CPUFREQ_POLICY_PERFORMANCE &&
 	    policy->max >= policy->cpuinfo.max_freq) {
-		pr_debug("intel_pstate: set performance\n");
+		pr_debug("set performance\n");
 		limits = &performance_limits;
 		goto out;
 	}
 
-	pr_debug("intel_pstate: set powersave\n");
+	pr_debug("set powersave\n");
 	limits = &powersave_limits;
 	limits->min_policy_pct = (policy->min * 100) / policy->cpuinfo.max_freq;
 	limits->min_policy_pct = clamp_t(int, limits->min_policy_pct, 0 , 100);
@@ -1206,7 +1208,7 @@ static void intel_pstate_stop_cpu(struct cpufreq_policy *policy)
 	int cpu_num = policy->cpu;
 	struct cpudata *cpu = all_cpu_data[cpu_num];
 
-	pr_debug("intel_pstate: CPU %d exiting\n", cpu_num);
+	pr_debug("CPU %d exiting\n", cpu_num);
 
 	intel_pstate_clear_update_util_hook(cpu_num);
 
@@ -1451,7 +1453,7 @@ hwp_cpu_matched:
 	if (intel_pstate_platform_pwr_mgmt_exists())
 		return -ENODEV;
 
-	pr_info("Intel P-state driver initializing.\n");
+	pr_info("Intel P-state driver initializing\n");
 
 	all_cpu_data = vzalloc(sizeof(void *) * num_possible_cpus());
 	if (!all_cpu_data)
@@ -1468,7 +1470,7 @@ hwp_cpu_matched:
 	intel_pstate_sysfs_expose_params();
 
 	if (hwp_active)
-		pr_info("intel_pstate: HWP enabled\n");
+		pr_info("HWP enabled\n");
 
 	return rc;
 out:
@@ -1494,7 +1496,7 @@ static int __init intel_pstate_setup(char *str)
 	if (!strcmp(str, "disable"))
 		no_load = 1;
 	if (!strcmp(str, "no_hwp")) {
-		pr_info("intel_pstate: HWP disabled\n");
+		pr_info("HWP disabled\n");
 		no_hwp = 1;
 	}
 	if (!strcmp(str, "force"))
Signature · 1 line
2.8.0.rc4.16.g56331f8
maintainer Acked-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] intel_pstate: Use pr_fmt

Quoted 3 lines · Joe Perches

Prefix the output using the more common kernel style.

Quoted 96 lines

---
 drivers/cpufreq/intel_pstate.c | 18 ++++++++++--------

 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/cpufreq/intel_pstate.c +0 -0
index a382195..e674db8 100644
@@ -10,6 +10,8 @@
   * of the License.
   */

drivers/cpufreq/intel_pstate.c +2 -0
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+

 #include <linux/kernel.h>
 #include <linux/kernel_stat.h>
 #include <linux/module.h>

drivers/cpufreq/intel_pstate.c +0 -0
@@ -436,7 +438,7 @@ static ssize_t store_no_turbo(struct kobject *a,
 struct attribute *b,


  update_turbo_state();
  if (limits->turbo_disabled) {

drivers/cpufreq/intel_pstate.c +0 -1
-		pr_warn("intel_pstate: Turbo disabled by BIOS or

unavailable on processor\n");

drivers/cpufreq/intel_pstate.c +1 -0
+		pr_warn("Turbo disabled by BIOS or unavailable on

processor\n");
  return -EPERM;
  }

drivers/cpufreq/intel_pstate.c +0 -0
@@ -1107,7 +1109,7 @@ static int intel_pstate_init_cpu(unsigned int
 cpunum)


  intel_pstate_busy_pid_reset(cpu);

drivers/cpufreq/intel_pstate.c +1 -1
-	pr_debug("intel_pstate: controlling: cpu %d\n", cpunum);
+	pr_debug("controlling: cpu %d\n", cpunum);


  return 0;
 }

drivers/cpufreq/intel_pstate.c +0 -0
@@ -1149,12 +1151,12 @@ static int intel_pstate_set_policy(struct
 cpufreq_policy *policy)


  if (policy->policy == CPUFREQ_POLICY_PERFORMANCE && policy->max >= policy->cpuinfo.max_freq) {

drivers/cpufreq/intel_pstate.c +1 -1
-		pr_debug("intel_pstate: set performance\n");
+		pr_debug("set performance\n");

  limits = &performance_limits;
  goto out;
  }

drivers/cpufreq/intel_pstate.c +1 -1
-	pr_debug("intel_pstate: set powersave\n");
+	pr_debug("set powersave\n");

  limits = &powersave_limits; limits->min_policy_pct = (policy->min * 100) / policy-

Quoted 1 line

cpuinfo.max_freq;

  limits->min_policy_pct = clamp_t(int, limits-

Quoted 1 line

min_policy_pct, 0 , 100);

drivers/cpufreq/intel_pstate.c +0 -0
@@ -1206,7 +1208,7 @@ static void intel_pstate_stop_cpu(struct
 cpufreq_policy *policy)
  	int cpu_num = policy->cpu;
  	struct cpudata *cpu = all_cpu_data[cpu_num];

drivers/cpufreq/intel_pstate.c +1 -1
-	pr_debug("intel_pstate: CPU %d exiting\n", cpu_num);
+	pr_debug("CPU %d exiting\n", cpu_num);

intel_pstate_clear_update_util_hook(cpu_num);

drivers/cpufreq/intel_pstate.c +0 -0
@@ -1451,7 +1453,7 @@ hwp_cpu_matched:
  	if (intel_pstate_platform_pwr_mgmt_exists())
  		return -ENODEV;

drivers/cpufreq/intel_pstate.c +1 -1
-	pr_info("Intel P-state driver initializing.\n");
+	pr_info("Intel P-state driver initializing\n");


  all_cpu_data = vzalloc(sizeof(void *) *
num_possible_cpus());
  if (!all_cpu_data)

drivers/cpufreq/intel_pstate.c +0 -0
@@ -1468,7 +1470,7 @@ hwp_cpu_matched:
  	intel_pstate_sysfs_expose_params();


  if (hwp_active)

drivers/cpufreq/intel_pstate.c +1 -1
-		pr_info("intel_pstate: HWP enabled\n");
+		pr_info("HWP enabled\n");


  return rc;
 out:

drivers/cpufreq/intel_pstate.c +1 -1
@@ -1494,7 +1496,7 @@ static int __init intel_pstate_setup(char *str)
  	if (!strcmp(str, "disable"))
  		no_load = 1;
  	if (!strcmp(str, "no_hwp")) {
-		pr_info("intel_pstate: HWP disabled\n");
+		pr_info("HWP disabled\n");
  		no_hwp = 1;
  	}
  	if (!strcmp(str, "force"))
#3 lore raw

RE: [PATCH 1/3] intel_pstate: Use pr_fmt

Quoted 8 lines · On 2016.04.05 02:44 Srinivas Pandruvada wrote:
Quoted 3 lines · Joe Perches

Prefix the output using the more common kernel style.

Quoted 3 lines
---
 drivers/cpufreq/intel_pstate.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

...[cut, example left]...

Quoted 4 lines
(quoted diff) +0 -1
-		pr_warn("intel_pstate: Turbo disabled by BIOS or

unavailable on processor\n");

(quoted diff) +1 -0
+		pr_warn("Turbo disabled by BIOS or unavailable on

processor\n");

I do not understand.
The common and unique string "intel_pstate" was added on purpose so as to provide a way to easily extract the related message from an otherwise huge log file.

Reference:
commit f16255eb930173f386db0ce78ed41401aa8a94a6

maintainer
#4 lore raw

Re: [PATCH 1/3] intel_pstate: Use pr_fmt

Quoted 12 lines · Doug Smythies
Quoted 8 lines · On 2016.04.05 02:44 Srinivas Pandruvada wrote:
Quoted 3 lines · Joe Perches

Prefix the output using the more common kernel style.

Quoted 3 lines
---
 drivers/cpufreq/intel_pstate.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

...[cut, example left]...

Quoted 9 lines
Quoted 4 lines
(quoted diff) +0 -1
-		pr_warn("intel_pstate: Turbo disabled by BIOS or

unavailable on processor\n");

(quoted diff) +1 -0
+		pr_warn("Turbo disabled by BIOS or unavailable on

processor\n");

I do not understand.
The common and unique string "intel_pstate" was added on purpose so as to provide a way to easily extract the related message from an otherwise huge log file.

The first line of the patch does this:

+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

which will automagically add name of the current file (intel_pstate) before every print message printed using pr_*() helpers.

Signature · 1 line
viresh
#5 lore raw

Re: [PATCH 1/3] intel_pstate: Use pr_fmt

In reply to Doug Smythies
Quoted 15 lines · Doug Smythies
Quoted 11 lines · On 2016.04.05 02:44 Srinivas Pandruvada wrote:
Quoted 4 lines · Joe Perches

Prefix the output using the more common kernel style.

Quoted 4 lines

---
 drivers/cpufreq/intel_pstate.c | 18 ++++++++++--------

 1 file changed, 10 insertions(+), 8 deletions(-)

...[cut, example left]...

Quoted 1 line
Quoted 9 lines
Quoted 4 lines
(quoted diff) +0 -1
-		pr_warn("intel_pstate: Turbo disabled by BIOS or

unavailable on processor\n");

(quoted diff) +1 -0
+		pr_warn("Turbo disabled by BIOS or unavailable on

processor\n");

I do  not understand.
The common and unique string "intel_pstate" was added on purpose so as to provide a way to easily extract the related message from an otherwise huge log file.

The more common kernel mechanism to prefix messages is using a pr_fmt define like:

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

This style is used ~1000 times in the kernel tree.

All of the pr_<level> macros are defined like:

#define pr_info(fmt, ...) \
	printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)

so this prefixes all messages and means that any new message added later will also be prefixed without copy/paste defects or omission.

#6 lore raw

RE: [PATCH 1/3] intel_pstate: Use pr_fmt

Quoted 4 lines · On 2106.03.06 08:13 Joe Perches wrote:
Quoted 2 lines · Doug Smythies
Quoted 1 line · On 2016.04.05 02:44 Srinivas Pandruvada wrote:

On Tue, 2016-04-05 at 13:28 -0700, Joe Perches wrote:

Quoted 8 lines

The more common kernel mechanism to prefix messages is using a pr_fmt define like:

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

so this prefixes all messages and means that any new message added later will also be prefixed without copy/paste defects or omission.

Ok. Thanks for your reply and education (and Viresh also). And sorry for my the ignorance in my patch submission last May.

... Doug

#8 lore raw

PATCH 2/3 cpufreq: Convert printk(KERN_<LEVEL> to pr_<level>

In reply to Joe Perches

Use the more common logging style.

Miscellanea:

o Coalesce formats
o Realign arguments
o Add a missing space between a coalesced format

---
 drivers/cpufreq/acpi-cpufreq.c            | 10 ++--
 drivers/cpufreq/cpufreq-nforce2.c         | 24 ++++------
 drivers/cpufreq/e_powersaver.c            | 60 ++++++++++-------------
 drivers/cpufreq/elanfreq.c                |  2 +-
 drivers/cpufreq/ia64-acpi-cpufreq.c       |  9 ++--
 drivers/cpufreq/longhaul.c                | 80 +++++++++++++------------------
 drivers/cpufreq/loongson2_cpufreq.c       |  2 +-
 drivers/cpufreq/maple-cpufreq.c           |  9 ++--
 drivers/cpufreq/omap-cpufreq.c            |  4 +-
 drivers/cpufreq/p4-clockmod.c             | 15 ++----
 drivers/cpufreq/pmac32-cpufreq.c          | 12 ++---
 drivers/cpufreq/pmac64-cpufreq.c          | 43 ++++++++---------
 drivers/cpufreq/powernow-k6.c             | 13 ++---
 drivers/cpufreq/powernow-k7.c             | 65 ++++++++++---------------
 drivers/cpufreq/pxa2xx-cpufreq.c          |  7 ++-
 drivers/cpufreq/s3c2412-cpufreq.c         | 13 +++--
 drivers/cpufreq/s3c2440-cpufreq.c         |  4 +-
 drivers/cpufreq/s3c24xx-cpufreq-debugfs.c |  2 +-
 drivers/cpufreq/s3c24xx-cpufreq.c         | 57 +++++++++++-----------
 drivers/cpufreq/s5pv210-cpufreq.c         |  4 +-
 drivers/cpufreq/sc520_freq.c              |  6 +--
 drivers/cpufreq/speedstep-centrino.c      |  3 +-
 drivers/cpufreq/speedstep-ich.c           |  6 +--
 drivers/cpufreq/speedstep-lib.c           |  9 ++--
 drivers/cpufreq/speedstep-smi.c           |  5 +-
 25 files changed, 199 insertions(+), 265 deletions(-)
drivers/cpufreq/acpi-cpufreq.c +3 -7
index 7f38fb5..ed9e93d 100644
@@ -648,10 +648,7 @@ static int acpi_cpufreq_blacklist(struct cpuinfo_x86 *c)
 		if ((c->x86 == 15) &&
 		    (c->x86_model == 6) &&
 		    (c->x86_mask == 8)) {
-			printk(KERN_INFO "acpi-cpufreq: Intel(R) "
-			    "Xeon(R) 7100 Errata AL30, processors may "
-			    "lock up on frequency changes: disabling "
-			    "acpi-cpufreq.\n");
+			pr_info("acpi-cpufreq: Intel(R) Xeon(R) 7100 Errata AL30, processors may lock up on frequency changes: disabling acpi-cpufreq\n");
 			return -ENODEV;
 		    }
 		}
@@ -799,8 +796,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	if (perf->control_register.space_id == ACPI_ADR_SPACE_FIXED_HARDWARE &&
 	    policy->cpuinfo.transition_latency > 20 * 1000) {
 		policy->cpuinfo.transition_latency = 20 * 1000;
-		printk_once(KERN_INFO
-			    "P-state transition latency capped at 20 uS\n");
+		pr_info_once("P-state transition latency capped at 20 uS\n");
 	}
 
 	/* table init */
@@ -822,7 +818,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
 		goto err_freqfree;
 
 	if (perf->states[0].core_frequency * 1000 != policy->cpuinfo.max_freq)
-		printk(KERN_WARNING FW_WARN "P-state 0 is not max freq\n");
+		pr_warn(FW_WARN "P-state 0 is not max freq\n");
 
 	switch (perf->control_register.space_id) {
 	case ACPI_ADR_SPACE_SYSTEM_IO:
drivers/cpufreq/cpufreq-nforce2.c +10 -14
index db69eeb..7da96d5 100644
@@ -174,13 +174,13 @@ static int nforce2_set_fsb(unsigned int fsb)
 	int pll = 0;
 
 	if ((fsb > max_fsb) || (fsb < NFORCE2_MIN_FSB)) {
-		printk(KERN_ERR PFX "FSB %d is out of range!\n", fsb);
+		pr_err(PFX "FSB %d is out of range!\n", fsb);
 		return -EINVAL;
 	}
 
 	tfsb = nforce2_fsb_read(0);
 	if (!tfsb) {
-		printk(KERN_ERR PFX "Error while reading the FSB\n");
+		pr_err(PFX "Error while reading the FSB\n");
 		return -EINVAL;
 	}
 
@@ -276,8 +276,7 @@ static int nforce2_target(struct cpufreq_policy *policy,
 	/* local_irq_save(flags); */
 
 	if (nforce2_set_fsb(target_fsb) < 0)
-		printk(KERN_ERR PFX "Changing FSB to %d failed\n",
-			target_fsb);
+		pr_err(PFX "Changing FSB to %d failed\n", target_fsb);
 	else
 		pr_debug("Changed FSB successfully to %d\n",
 			target_fsb);
@@ -325,8 +324,7 @@ static int nforce2_cpu_init(struct cpufreq_policy *policy)
 	/* FIX: Get FID from CPU */
 	if (!fid) {
 		if (!cpu_khz) {
-			printk(KERN_WARNING PFX
-			"cpu_khz not set, can't calculate multiplier!\n");
+			pr_warn(PFX "cpu_khz not set, can't calculate multiplier!\n");
 			return -ENODEV;
 		}
 
@@ -341,8 +339,8 @@ static int nforce2_cpu_init(struct cpufreq_policy *policy)
 		}
 	}
 
-	printk(KERN_INFO PFX "FSB currently at %i MHz, FID %d.%d\n", fsb,
-	       fid / 10, fid % 10);
+	pr_info(PFX "FSB currently at %i MHz, FID %d.%d\n",
+		fsb, fid / 10, fid % 10);
 
 	/* Set maximum FSB to FSB at boot time */
 	max_fsb = nforce2_fsb_read(1);
@@ -401,11 +399,9 @@ static int nforce2_detect_chipset(void)
 	if (nforce2_dev == NULL)
 		return -ENODEV;
 
-	printk(KERN_INFO PFX "Detected nForce2 chipset revision %X\n",
-	       nforce2_dev->revision);
-	printk(KERN_INFO PFX
-	       "FSB changing is maybe unstable and can lead to "
-	       "crashes and data loss.\n");
+	pr_info(PFX "Detected nForce2 chipset revision %X\n",
+		nforce2_dev->revision);
+	pr_info(PFX "FSB changing is maybe unstable and can lead to crashes and data loss\n");
 
 	return 0;
 }
@@ -423,7 +419,7 @@ static int __init nforce2_init(void)
 
 	/* detect chipset */
 	if (nforce2_detect_chipset()) {
-		printk(KERN_INFO PFX "No nForce2 chipset.\n");
+		pr_info(PFX "No nForce2 chipset\n");
 		return -ENODEV;
 	}
 
drivers/cpufreq/e_powersaver.c +25 -35

146 lines not on this page · raw message

drivers/cpufreq/elanfreq.c +1 -1
index 1c06e78..8f4dded 100644
@@ -185,7 +185,7 @@ static int elanfreq_cpu_init(struct cpufreq_policy *policy)
 static int __init elanfreq_setup(char *str)
 {
 	max_freq = simple_strtoul(str, &str, 0);
-	printk(KERN_WARNING "You're using the deprecated elanfreq command line option. Use elanfreq.max_freq instead, please!\n");
+	pr_warn("You're using the deprecated elanfreq command line option. Use elanfreq.max_freq instead, please!\n");
 	return 1;
 }
 __setup("elanfreq=", elanfreq_setup);
drivers/cpufreq/ia64-acpi-cpufreq.c +4 -5
index 0202429..fd36d6c 100644
@@ -118,8 +118,7 @@ processor_get_freq (
 
 	if (ret) {
 		set_cpus_allowed_ptr(current, &saved_mask);
-		printk(KERN_WARNING "get performance failed with error %d\n",
-		       ret);
+		pr_warn("get performance failed with error %d\n", ret);
 		ret = 0;
 		goto migrate_end;
 	}
@@ -177,7 +176,7 @@ processor_set_freq (
 
 	ret = processor_set_pstate(value);
 	if (ret) {
-		printk(KERN_WARNING "Transition failed with error %d\n", ret);
+		pr_warn("Transition failed with error %d\n", ret);
 		retval = -ENODEV;
 		goto migrate_end;
 	}
@@ -291,8 +290,8 @@ acpi_cpufreq_cpu_init (
 	/* notify BIOS that we exist */
 	acpi_processor_notify_smm(THIS_MODULE);
 
-	printk(KERN_INFO "acpi-cpufreq: CPU%u - ACPI performance management "
-	       "activated.\n", cpu);
+	pr_info("acpi-cpufreq: CPU%u - ACPI performance management activated\n",
+		cpu);
 
 	for (i = 0; i < data->acpi_data.state_count; i++)
 		pr_debug("     %cP%d: %d MHz, %d mW, %d uS, %d uS, 0x%x 0x%x\n",
drivers/cpufreq/longhaul.c +33 -47

223 lines not on this page · raw message

drivers/cpufreq/loongson2_cpufreq.c +1 -1
index cd593c1..93c7928 100644
@@ -76,7 +76,7 @@ static int loongson2_cpufreq_cpu_init(struct cpufreq_policy *policy)
 
 	cpuclk = clk_get(NULL, "cpu_clk");
 	if (IS_ERR(cpuclk)) {
-		printk(KERN_ERR "cpufreq: couldn't get CPU clk\n");
+		pr_err("cpufreq: couldn't get CPU clk\n");
 		return PTR_ERR(cpuclk);
 	}
 
drivers/cpufreq/maple-cpufreq.c +4 -5
index cc3408f..7e55632 100644
@@ -174,7 +174,7 @@ static int __init maple_cpufreq_init(void)
 	/* Get first CPU node */
 	cpunode = of_cpu_device_node_get(0);
 	if (cpunode == NULL) {
-		printk(KERN_ERR "cpufreq: Can't find any CPU 0 node\n");
+		pr_err("cpufreq: Can't find any CPU 0 node\n");
 		goto bail_noprops;
 	}
 
@@ -182,8 +182,7 @@ static int __init maple_cpufreq_init(void)
 	/* we actually don't care on which CPU to access PVR */
 	pvr_hi = PVR_VER(mfspr(SPRN_PVR));
 	if (pvr_hi != 0x3c && pvr_hi != 0x44) {
-		printk(KERN_ERR "cpufreq: Unsupported CPU version (%x)\n",
-				pvr_hi);
+		pr_err("cpufreq: Unsupported CPU version (%x)\n", pvr_hi);
 		goto bail_noprops;
 	}
 
@@ -222,8 +221,8 @@ static int __init maple_cpufreq_init(void)
 	maple_pmode_cur = -1;
 	maple_scom_switch_freq(maple_scom_query_freq());
 
-	printk(KERN_INFO "Registering Maple CPU frequency driver\n");
-	printk(KERN_INFO "Low: %d Mhz, High: %d Mhz, Cur: %d MHz\n",
+	pr_info("Registering Maple CPU frequency driver\n");
+	pr_info("Low: %d Mhz, High: %d Mhz, Cur: %d MHz\n",
 		maple_cpu_freqs[1].frequency/1000,
 		maple_cpu_freqs[0].frequency/1000,
 		maple_cpu_freqs[maple_pmode_cur].frequency/1000);
drivers/cpufreq/omap-cpufreq.c +2 -2
index e3866e0..655fc94 100644
@@ -163,13 +163,13 @@ static int omap_cpufreq_probe(struct platform_device *pdev)
 {
 	mpu_dev = get_cpu_device(0);
 	if (!mpu_dev) {
-		pr_warning("%s: unable to get the mpu device\n", __func__);
+		pr_warn("%s: unable to get the mpu device\n", __func__);
 		return -EINVAL;
 	}
 
 	mpu_reg = regulator_get(mpu_dev, "vcc");
 	if (IS_ERR(mpu_reg)) {
-		pr_warning("%s: unable to get MPU regulator\n", __func__);
+		pr_warn("%s: unable to get MPU regulator\n", __func__);
 		mpu_reg = NULL;
 	} else {
 		/* 
drivers/cpufreq/p4-clockmod.c +3 -12
index 5dd95da..4d1a443 100644
@@ -124,11 +124,7 @@ static unsigned int cpufreq_p4_get_frequency(struct cpuinfo_x86 *c)
 {
 	if (c->x86 == 0x06) {
 		if (cpu_has(c, X86_FEATURE_EST))
-			printk_once(KERN_WARNING PFX "Warning: EST-capable "
-			       "CPU detected. The acpi-cpufreq module offers "
-			       "voltage scaling in addition to frequency "
-			       "scaling. You should use that instead of "
-			       "p4-clockmod, if possible.\n");
+			pr_warn_once(PFX "Warning: EST-capable CPU detected. The acpi-cpufreq module offers voltage scaling in addition to frequency scaling. You should use that instead of p4-clockmod, if possible.\n");
 		switch (c->x86_model) {
 		case 0x0E: /* Core */
 		case 0x0F: /* Core Duo */
@@ -152,11 +148,7 @@ static unsigned int cpufreq_p4_get_frequency(struct cpuinfo_x86 *c)
 	p4clockmod_driver.flags |= CPUFREQ_CONST_LOOPS;
 
 	if (speedstep_detect_processor() == SPEEDSTEP_CPU_P4M) {
-		printk(KERN_WARNING PFX "Warning: Pentium 4-M detected. "
-		       "The speedstep-ich or acpi cpufreq modules offer "
-		       "voltage scaling in addition of frequency scaling. "
-		       "You should use either one instead of p4-clockmod, "
-		       "if possible.\n");
+		pr_warn(PFX "Warning: Pentium 4-M detected. The speedstep-ich or acpi cpufreq modules offer voltage scaling in addition of frequency scaling. You should use either one instead of p4-clockmod, if possible.\n");
 		return speedstep_get_frequency(SPEEDSTEP_CPU_P4M);
 	}
 
@@ -265,8 +257,7 @@ static int __init cpufreq_p4_init(void)
 
 	ret = cpufreq_register_driver(&p4clockmod_driver);
 	if (!ret)
-		printk(KERN_INFO PFX "P4/Xeon(TM) CPU On-Demand Clock "
-				"Modulation available\n");
+		pr_info(PFX "P4/Xeon(TM) CPU On-Demand Clock Modulation available\n");
 
 	return ret;
 }
drivers/cpufreq/pmac32-cpufreq.c +6 -6
index 1f49d97..072d7b3 100644
@@ -481,13 +481,13 @@ static int pmac_cpufreq_init_MacRISC3(struct device_node *cpunode)
 		freqs = of_get_property(cpunode, "bus-frequencies", &lenp);
 		lenp /= sizeof(u32);
 		if (freqs == NULL || lenp != 2) {
-			printk(KERN_ERR "cpufreq: bus-frequencies incorrect or missing\n");
+			pr_err("cpufreq: bus-frequencies incorrect or missing\n");
 			return 1;
 		}
 		ratio = of_get_property(cpunode, "processor-to-bus-ratio*2",
 						NULL);
 		if (ratio == NULL) {
-			printk(KERN_ERR "cpufreq: processor-to-bus-ratio*2 missing\n");
+			pr_err("cpufreq: processor-to-bus-ratio*2 missing\n");
 			return 1;
 		}
 
@@ -550,7 +550,7 @@ static int pmac_cpufreq_init_7447A(struct device_node *cpunode)
 	if (volt_gpio_np)
 		voltage_gpio = read_gpio(volt_gpio_np);
 	if (!voltage_gpio){
-		printk(KERN_ERR "cpufreq: missing cpu-vcore-select gpio\n");
+		pr_err("cpufreq: missing cpu-vcore-select gpio\n");
 		return 1;
 	}
 
@@ -675,9 +675,9 @@ out:
 	pmac_cpu_freqs[CPUFREQ_HIGH].frequency = hi_freq;
 	ppc_proc_freq = cur_freq * 1000ul;
 
-	printk(KERN_INFO "Registering PowerMac CPU frequency driver\n");
-	printk(KERN_INFO "Low: %d Mhz, High: %d Mhz, Boot: %d Mhz\n",
-	       low_freq/1000, hi_freq/1000, cur_freq/1000);
+	pr_info("Registering PowerMac CPU frequency driver\n");
+	pr_info("Low: %d Mhz, High: %d Mhz, Boot: %d Mhz\n",
+		low_freq/1000, hi_freq/1000, cur_freq/1000);
 
 	return cpufreq_register_driver(&pmac_cpufreq_driver);
 }
drivers/cpufreq/pmac64-cpufreq.c +20 -23

127 lines not on this page · raw message

drivers/cpufreq/powernow-k6.c +7 -6
index e6f24b2..981f40b 100644
@@ -141,7 +141,7 @@ static int powernow_k6_target(struct cpufreq_policy *policy,
 {
 
 	if (clock_ratio[best_i].driver_data > max_multiplier) {
-		printk(KERN_ERR PFX "invalid target frequency\n");
+		pr_err(PFX "invalid target frequency\n");
 		return -EINVAL;
 	}
 
@@ -175,13 +175,14 @@ static int powernow_k6_cpu_init(struct cpufreq_policy *policy)
 				max_multiplier = param_max_multiplier;
 				goto have_max_multiplier;
 			}
-		printk(KERN_ERR "powernow-k6: invalid max_multiplier parameter, valid parameters 20, 30, 35, 40, 45, 50, 55, 60\n");
+		pr_err("powernow-k6: invalid max_multiplier parameter, valid parameters 20, 30, 35, 40, 45, 50, 55, 60\n");
 		return -EINVAL;
 	}
 
 	if (!max_multiplier) {
-		printk(KERN_WARNING "powernow-k6: unknown frequency %u, cannot determine current multiplier\n", khz);
-		printk(KERN_WARNING "powernow-k6: use module parameters max_multiplier and bus_frequency\n");
+		pr_warn("powernow-k6: unknown frequency %u, cannot determine current multiplier\n",
+			khz);
+		pr_warn("powernow-k6: use module parameters max_multiplier and bus_frequency\n");
 		return -EOPNOTSUPP;
 	}
 
@@ -193,7 +194,7 @@ have_max_multiplier:
 			busfreq = param_busfreq / 10;
 			goto have_busfreq;
 		}
-		printk(KERN_ERR "powernow-k6: invalid bus_frequency parameter, allowed range 50000 - 150000 kHz\n");
+		pr_err("powernow-k6: invalid bus_frequency parameter, allowed range 50000 - 150000 kHz\n");
 		return -EINVAL;
 	}
 
@@ -275,7 +276,7 @@ static int __init powernow_k6_init(void)
 		return -ENODEV;
 
 	if (!request_region(POWERNOW_IOPORT, 16, "PowerNow!")) {
-		printk(KERN_INFO PFX "PowerNow IOPORT region already used.\n");
+		pr_info(PFX "PowerNow IOPORT region already used\n");
 		return -EIO;
 	}
 
drivers/cpufreq/powernow-k7.c +26 -39

167 lines not on this page · raw message

drivers/cpufreq/pxa2xx-cpufreq.c +3 -4
index 46fee15..8a27667 100644
@@ -233,9 +233,8 @@ static void pxa27x_guess_max_freq(void)
 {
 	if (!pxa27x_maxfreq) {
 		pxa27x_maxfreq = 416000;
-		printk(KERN_INFO "PXA CPU 27x max frequency not defined "
-		       "(pxa27x_maxfreq), assuming pxa271 with %dkHz maxfreq\n",
-		       pxa27x_maxfreq);
+		pr_info("PXA CPU 27x max frequency not defined (pxa27x_maxfreq), assuming pxa271 with %dkHz maxfreq\n",
+			pxa27x_maxfreq);
 	} else {
 		pxa27x_maxfreq *= 1000;
 	}
@@ -417,7 +416,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
 		cpufreq_table_validate_and_show(policy, pxa27x_freq_table);
 	}
 
-	printk(KERN_INFO "PXA CPU frequency change support initialized\n");
+	pr_info("PXA CPU frequency change support initialized\n");
 
 	return 0;
 }
drivers/cpufreq/s3c2412-cpufreq.c +6 -7
index eb26213..f9447ba 100644
@@ -197,21 +197,20 @@ static int s3c2412_cpufreq_add(struct device *dev,
 
 	hclk = clk_get(NULL, "hclk");
 	if (IS_ERR(hclk)) {
-		printk(KERN_ERR "%s: cannot find hclk clock\n", __func__);
+		pr_err("%s: cannot find hclk clock\n", __func__);
 		return -ENOENT;
 	}
 
 	fclk = clk_get(NULL, "fclk");
 	if (IS_ERR(fclk)) {
-		printk(KERN_ERR "%s: cannot find fclk clock\n", __func__);
+		pr_err("%s: cannot find fclk clock\n", __func__);
 		goto err_fclk;
 	}
 
 	fclk_rate = clk_get_rate(fclk);
 	if (fclk_rate > 200000000) {
-		printk(KERN_INFO
-		       "%s: fclk %ld MHz, assuming 266MHz capable part\n",
-		       __func__, fclk_rate / 1000000);
+		pr_info("%s: fclk %ld MHz, assuming 266MHz capable part\n",
+			__func__, fclk_rate / 1000000);
 		s3c2412_cpufreq_info.max.fclk = 266000000;
 		s3c2412_cpufreq_info.max.hclk = 133000000;
 		s3c2412_cpufreq_info.max.pclk =  66000000;
@@ -219,13 +218,13 @@ static int s3c2412_cpufreq_add(struct device *dev,
 
 	armclk = clk_get(NULL, "armclk");
 	if (IS_ERR(armclk)) {
-		printk(KERN_ERR "%s: cannot find arm clock\n", __func__);
+		pr_err("%s: cannot find arm clock\n", __func__);
 		goto err_armclk;
 	}
 
 	xtal = clk_get(NULL, "xtal");
 	if (IS_ERR(xtal)) {
-		printk(KERN_ERR "%s: cannot find xtal clock\n", __func__);
+		pr_err("%s: cannot find xtal clock\n", __func__);
 		goto err_xtal;
 	}
 
drivers/cpufreq/s3c2440-cpufreq.c +2 -2
index 0129f5c..f6cefe3 100644
@@ -66,7 +66,7 @@ static int s3c2440_cpufreq_calcdivs(struct s3c_cpufreq_config *cfg)
 		     __func__, fclk, armclk, hclk_max);
 
 	if (armclk > fclk) {
-		printk(KERN_WARNING "%s: armclk > fclk\n", __func__);
+		pr_warn("%s: armclk > fclk\n", __func__);
 		armclk = fclk;
 	}
 
@@ -273,7 +273,7 @@ static int s3c2440_cpufreq_add(struct device *dev,
 	armclk = s3c_cpufreq_clk_get(NULL, "armclk");
 
 	if (IS_ERR(xtal) || IS_ERR(hclk) || IS_ERR(fclk) || IS_ERR(armclk)) {
-		printk(KERN_ERR "%s: failed to get clocks\n", __func__);
+		pr_err("%s: failed to get clocks\n", __func__);
 		return -ENOENT;
 	}
 
drivers/cpufreq/s3c24xx-cpufreq-debugfs.c +1 -1
index 9b7b428..8182608 100644
@@ -178,7 +178,7 @@ static int __init s3c_freq_debugfs_init(void)
 {
 	dbgfs_root = debugfs_create_dir("s3c-cpufreq", NULL);
 	if (IS_ERR(dbgfs_root)) {
-		printk(KERN_ERR "%s: error creating debugfs root\n", __func__);
+		pr_err("%s: error creating debugfs root\n", __func__);
 		return PTR_ERR(dbgfs_root);
 	}
 
drivers/cpufreq/s3c24xx-cpufreq.c +28 -29

172 lines not on this page · raw message

drivers/cpufreq/s5pv210-cpufreq.c +2 -2
index a145b31..344e584 100644
@@ -205,7 +205,7 @@ static void s5pv210_set_refresh(enum s5pv210_dmc_port ch, unsigned long freq)
 	} else if (ch == DMC1) {
 		reg = (dmc_base[1] + 0x30);
 	} else {
-		printk(KERN_ERR "Cannot find DMC port\n");
+		pr_err("Cannot find DMC port\n");
 		return;
 	}
 
@@ -534,7 +534,7 @@ static int s5pv210_cpu_init(struct cpufreq_policy *policy)
 	mem_type = check_mem_type(dmc_base[0]);
 
 	if ((mem_type != LPDDR) && (mem_type != LPDDR2)) {
-		printk(KERN_ERR "CPUFreq doesn't support this memory type\n");
+		pr_err("CPUFreq doesn't support this memory type\n");
 		ret = -EINVAL;
 		goto out_dmc1;
 	}
drivers/cpufreq/sc520_freq.c +3 -3
index ac84e48..57bbddf 100644
@@ -44,8 +44,8 @@ static unsigned int sc520_freq_get_cpu_frequency(unsigned int cpu)
 
 	switch (clockspeed_reg & 0x03) {
 	default:
-		printk(KERN_ERR PFX "error: cpuctl register has unexpected "
-				"value %02x\n", clockspeed_reg);
+		pr_err(PFX "error: cpuctl register has unexpected value %02x\n",
+		       clockspeed_reg);
 	case 0x01:
 		return 100000;
 	case 0x02:
@@ -112,7 +112,7 @@ static int __init sc520_freq_init(void)
 
 	cpuctl = ioremap((unsigned long)(MMCR_BASE + OFFS_CPUCTL), 1);
 	if (!cpuctl) {
-		printk(KERN_ERR "sc520_freq: error: failed to remap memory\n");
+		pr_err("sc520_freq: error: failed to remap memory\n");
 		return -ENOMEM;
 	}
 
drivers/cpufreq/speedstep-centrino.c +1 -2
index 7d4a315..47df2d6 100644
@@ -386,8 +386,7 @@ static int centrino_cpu_init(struct cpufreq_policy *policy)
 		/* check to see if it stuck */
 		rdmsr(MSR_IA32_MISC_ENABLE, l, h);
 		if (!(l & MSR_IA32_MISC_ENABLE_ENHANCED_SPEEDSTEP)) {
-			printk(KERN_INFO PFX
-				"couldn't enable Enhanced SpeedStep\n");
+			pr_info(PFX "couldn't enable Enhanced SpeedStep\n");
 			return -ENODEV;
 		}
 	}
drivers/cpufreq/speedstep-ich.c +3 -3
index 37555c6..9d00c22 100644
@@ -68,13 +68,13 @@ static int speedstep_find_register(void)
 	/* get PMBASE */
 	pci_read_config_dword(speedstep_chipset_dev, 0x40, &pmbase);
 	if (!(pmbase & 0x01)) {
-		printk(KERN_ERR "speedstep-ich: could not find speedstep register\n");
+		pr_err("speedstep-ich: could not find speedstep register\n");
 		return -ENODEV;
 	}
 
 	pmbase &= 0xFFFFFFFE;
 	if (!pmbase) {
-		printk(KERN_ERR "speedstep-ich: could not find speedstep register\n");
+		pr_err("speedstep-ich: could not find speedstep register\n");
 		return -ENODEV;
 	}
 
@@ -136,7 +136,7 @@ static void speedstep_set_state(unsigned int state)
 		pr_debug("change to %u MHz succeeded\n",
 			speedstep_get_frequency(speedstep_processor) / 1000);
 	else
-		printk(KERN_ERR "cpufreq: change failed - I/O error\n");
+		pr_err("cpufreq: change failed - I/O error\n");
 
 	return;
 }
drivers/cpufreq/speedstep-lib.c +3 -6
index 15d3214..32bdf1d 100644
@@ -153,7 +153,7 @@ static unsigned int pentium_core_get_frequency(void)
 		fsb = 333333;
 		break;
 	default:
-		printk(KERN_ERR "PCORE - MSR_FSB_FREQ undefined value");
+		pr_err("PCORE - MSR_FSB_FREQ undefined value\n");
 	}
 
 	rdmsr(MSR_IA32_EBL_CR_POWERON, msr_lo, msr_tmp);
@@ -453,11 +453,8 @@ unsigned int speedstep_get_freqs(enum speedstep_processor processor,
 		 */
 		if (*transition_latency > 10000000 ||
 		    *transition_latency < 50000) {
-			printk(KERN_WARNING PFX "frequency transition "
-					"measured seems out of range (%u "
-					"nSec), falling back to a safe one of"
-					"%u nSec.\n",
-					*transition_latency, 500000);
+			pr_warn(PFX "frequency transition measured seems out of range (%u nSec), falling back to a safe one of %u nSec\n",
+				*transition_latency, 500000);
 			*transition_latency = 500000;
 		}
 	}
drivers/cpufreq/speedstep-smi.c +2 -3
index 819229e..af32a5f 100644
@@ -204,9 +204,8 @@ static void speedstep_set_state(unsigned int state)
 			(speedstep_freqs[new_state].frequency / 1000),
 			retry, result);
 	else
-		printk(KERN_ERR "cpufreq: change to state %u "
-			"failed with new_state %u and result %u\n",
-			state, new_state, result);
+		pr_err("cpufreq: change to state %u failed with new_state %u and result %u\n",
+		       state, new_state, result);
 
 	return;
 }
Signature · 1 line
2.8.0.rc4.16.g56331f8
maintainer Acked-by on v1 2/3
#9 lore raw

Re: [PATCH 2/3] cpufreq: Convert printk(KERN_<LEVEL> to pr_<level>

Quoted 28 lines · Joe Perches

Use the more common logging style.

Miscellanea:

o Coalesce formats
o Realign arguments
o Add a missing space between a coalesced format

---
 drivers/cpufreq/acpi-cpufreq.c            | 10 ++--
 drivers/cpufreq/cpufreq-nforce2.c         | 24 ++++------
 drivers/cpufreq/e_powersaver.c            | 60 ++++++++++-------------
 drivers/cpufreq/elanfreq.c                |  2 +-
 drivers/cpufreq/ia64-acpi-cpufreq.c       |  9 ++--
 drivers/cpufreq/longhaul.c                | 80 +++++++++++++------------------
 drivers/cpufreq/loongson2_cpufreq.c       |  2 +-
 drivers/cpufreq/maple-cpufreq.c           |  9 ++--
 drivers/cpufreq/omap-cpufreq.c            |  4 +-
 drivers/cpufreq/p4-clockmod.c             | 15 ++----
 drivers/cpufreq/pmac32-cpufreq.c          | 12 ++---
 drivers/cpufreq/pmac64-cpufreq.c          | 43 ++++++++---------
 drivers/cpufreq/powernow-k6.c             | 13 ++---
 drivers/cpufreq/powernow-k7.c             | 65 ++++++++++---------------
 drivers/cpufreq/pxa2xx-cpufreq.c          |  7 ++-
 drivers/cpufreq/s3c2412-cpufreq.c         | 13 +++--
 drivers/cpufreq/s3c2440-cpufreq.c         |  4 +-
 drivers/cpufreq/s3c24xx-cpufreq-debugfs.c |  2 +-
Quoted 8 lines
 drivers/cpufreq/s3c24xx-cpufreq.c         | 57 +++++++++++-----------
 drivers/cpufreq/s5pv210-cpufreq.c         |  4 +-
 drivers/cpufreq/sc520_freq.c              |  6 +--
 drivers/cpufreq/speedstep-centrino.c      |  3 +-
 drivers/cpufreq/speedstep-ich.c           |  6 +--
 drivers/cpufreq/speedstep-lib.c           |  9 ++--
 drivers/cpufreq/speedstep-smi.c           |  5 +-
 25 files changed, 199 insertions(+), 265 deletions(-)
Signature · 1 line
viresh
#10 lore raw

PATCH 3/3 cpufreq: Use consistent prefixing via pr_fmt

In reply to Joe Perches

Use the more common kernel style adding a define for pr_fmt.

Miscellanea:

o Remove now unused PFX defines

---
 drivers/cpufreq/acpi-cpufreq.c            |  8 ++---
 drivers/cpufreq/cpufreq-nforce2.c         | 20 +++++------
 drivers/cpufreq/e_powersaver.c            | 38 ++++++++++----------
 drivers/cpufreq/elanfreq.c                |  2 ++
 drivers/cpufreq/ia64-acpi-cpufreq.c       |  5 +--
 drivers/cpufreq/longhaul.c                | 60 +++++++++++++++----------------
 drivers/cpufreq/loongson2_cpufreq.c       |  7 ++--
 drivers/cpufreq/maple-cpufreq.c           |  6 ++--
 drivers/cpufreq/omap-cpufreq.c            |  5 ++-
 drivers/cpufreq/p4-clockmod.c             | 10 +++---
 drivers/cpufreq/pmac32-cpufreq.c          |  8 +++--
 drivers/cpufreq/pmac64-cpufreq.c          | 28 ++++++++-------
 drivers/cpufreq/powernow-k6.c             | 15 ++++----
 drivers/cpufreq/powernow-k7.c             | 43 +++++++++++-----------
 drivers/cpufreq/pxa2xx-cpufreq.c          | 13 +++----
 drivers/cpufreq/s3c2412-cpufreq.c         | 14 ++++----
 drivers/cpufreq/s3c2440-cpufreq.c         |  2 ++
 drivers/cpufreq/s3c24xx-cpufreq-debugfs.c |  2 ++
 drivers/cpufreq/s3c24xx-cpufreq.c         |  8 +++--
 drivers/cpufreq/s5pv210-cpufreq.c         |  6 ++--
 drivers/cpufreq/sc520_freq.c              |  6 ++--
 drivers/cpufreq/speedstep-centrino.c      |  5 +--
 drivers/cpufreq/speedstep-ich.c           |  8 +++--
 drivers/cpufreq/speedstep-lib.c           |  4 ++-
 drivers/cpufreq/speedstep-smi.c           |  4 ++-
 25 files changed, 181 insertions(+), 146 deletions(-)
drivers/cpufreq/acpi-cpufreq.c +4 -4
index ed9e93d..67a612e 100644
@@ -25,6 +25,8 @@
  * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/init.h>
@@ -50,8 +52,6 @@ MODULE_AUTHOR("Paul Diefenbaugh, Dominik Brodowski");
 MODULE_DESCRIPTION("ACPI Processor P-States Driver");
 MODULE_LICENSE("GPL");
 
-#define PFX "acpi-cpufreq: "
-
 enum {
 	UNDEFINED_CAPABLE = 0,
 	SYSTEM_INTEL_MSR_CAPABLE,
@@ -648,7 +648,7 @@ static int acpi_cpufreq_blacklist(struct cpuinfo_x86 *c)
 		if ((c->x86 == 15) &&
 		    (c->x86_model == 6) &&
 		    (c->x86_mask == 8)) {
-			pr_info("acpi-cpufreq: Intel(R) Xeon(R) 7100 Errata AL30, processors may lock up on frequency changes: disabling acpi-cpufreq\n");
+			pr_info("Intel(R) Xeon(R) 7100 Errata AL30, processors may lock up on frequency changes: disabling acpi-cpufreq\n");
 			return -ENODEV;
 		    }
 		}
@@ -724,7 +724,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
 		cpumask_copy(data->freqdomain_cpus,
 			     topology_sibling_cpumask(cpu));
 		policy->shared_type = CPUFREQ_SHARED_TYPE_HW;
-		pr_info_once(PFX "overriding BIOS provided _PSD data\n");
+		pr_info_once("overriding BIOS provided _PSD data\n");
 	}
 #endif
 
drivers/cpufreq/cpufreq-nforce2.c +10 -10
index 7da96d5..5503d49 100644
@@ -7,6 +7,8 @@
  *  BIG FAT DISCLAIMER: Work in progress code. Possibly *dangerous*
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
@@ -56,8 +58,6 @@ MODULE_PARM_DESC(fid, "CPU multiplier to use (11.5 = 115)");
 MODULE_PARM_DESC(min_fsb,
 		"Minimum FSB to use, if not defined: current FSB - 50");
 
-#define PFX "cpufreq-nforce2: "
-
 /**
  * nforce2_calc_fsb - calculate FSB
  * @pll: PLL value
@@ -174,13 +174,13 @@ static int nforce2_set_fsb(unsigned int fsb)
 	int pll = 0;
 
 	if ((fsb > max_fsb) || (fsb < NFORCE2_MIN_FSB)) {
-		pr_err(PFX "FSB %d is out of range!\n", fsb);
+		pr_err("FSB %d is out of range!\n", fsb);
 		return -EINVAL;
 	}
 
 	tfsb = nforce2_fsb_read(0);
 	if (!tfsb) {
-		pr_err(PFX "Error while reading the FSB\n");
+		pr_err("Error while reading the FSB\n");
 		return -EINVAL;
 	}
 
@@ -276,7 +276,7 @@ static int nforce2_target(struct cpufreq_policy *policy,
 	/* local_irq_save(flags); */
 
 	if (nforce2_set_fsb(target_fsb) < 0)
-		pr_err(PFX "Changing FSB to %d failed\n", target_fsb);
+		pr_err("Changing FSB to %d failed\n", target_fsb);
 	else
 		pr_debug("Changed FSB successfully to %d\n",
 			target_fsb);
@@ -324,7 +324,7 @@ static int nforce2_cpu_init(struct cpufreq_policy *policy)
 	/* FIX: Get FID from CPU */
 	if (!fid) {
 		if (!cpu_khz) {
-			pr_warn(PFX "cpu_khz not set, can't calculate multiplier!\n");
+			pr_warn("cpu_khz not set, can't calculate multiplier!\n");
 			return -ENODEV;
 		}
 
@@ -339,7 +339,7 @@ static int nforce2_cpu_init(struct cpufreq_policy *policy)
 		}
 	}
 
-	pr_info(PFX "FSB currently at %i MHz, FID %d.%d\n",
+	pr_info("FSB currently at %i MHz, FID %d.%d\n",
 		fsb, fid / 10, fid % 10);
 
 	/* Set maximum FSB to FSB at boot time */
@@ -399,9 +399,9 @@ static int nforce2_detect_chipset(void)
 	if (nforce2_dev == NULL)
 		return -ENODEV;
 
-	pr_info(PFX "Detected nForce2 chipset revision %X\n",
+	pr_info("Detected nForce2 chipset revision %X\n",
 		nforce2_dev->revision);
-	pr_info(PFX "FSB changing is maybe unstable and can lead to crashes and data loss\n");
+	pr_info("FSB changing is maybe unstable and can lead to crashes and data loss\n");
 
 	return 0;
 }
@@ -419,7 +419,7 @@ static int __init nforce2_init(void)
 
 	/* detect chipset */
 	if (nforce2_detect_chipset()) {
-		pr_info(PFX "No nForce2 chipset\n");
+		pr_info("No nForce2 chipset\n");
 		return -ENODEV;
 	}
 
drivers/cpufreq/e_powersaver.c +20 -18
index c420f0c..5ec87e3 100644
@@ -6,6 +6,8 @@
  *  BIG FAT DISCLAIMER: Work in progress code. Possibly *dangerous*
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/init.h>
@@ -141,9 +143,9 @@ static int eps_set_state(struct eps_cpu_data *centaur,
 	/* Print voltage and multiplier */
 	rdmsr(MSR_IA32_PERF_STATUS, lo, hi);
 	current_voltage = lo & 0xff;
-	pr_info("eps: Current voltage = %dmV\n", current_voltage * 16 + 700);
+	pr_info("Current voltage = %dmV\n", current_voltage * 16 + 700);
 	current_multiplier = (lo >> 8) & 0xff;
-	pr_info("eps: Current multiplier = %d\n", current_multiplier);
+	pr_info("Current multiplier = %d\n", current_multiplier);
 	}
 #endif
 	return 0;
@@ -164,7 +166,7 @@ static int eps_target(struct cpufreq_policy *policy, unsigned int index)
 	dest_state = centaur->freq_table[index].driver_data & 0xffff;
 	ret = eps_set_state(centaur, policy, dest_state);
 	if (ret)
-		pr_err("eps: Timeout!\n");
+		pr_err("Timeout!\n");
 	return ret;
 }
 
@@ -192,7 +194,7 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
 		return -ENODEV;
 
 	/* Check brand */
-	pr_info("eps: Detected VIA ");
+	pr_info("Detected VIA ");
 
 	switch (c->x86_model) {
 	case 10:
@@ -233,7 +235,7 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
 		/* Can be locked at 0 */
 		rdmsrl(MSR_IA32_MISC_ENABLE, val);
 		if (!(val & MSR_IA32_MISC_ENABLE_ENHANCED_SPEEDSTEP)) {
-			pr_info("eps: Can't enable Enhanced PowerSaver\n");
+			pr_info("Can't enable Enhanced PowerSaver\n");
 			return -ENODEV;
 		}
 	}
@@ -241,19 +243,19 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
 	/* Print voltage and multiplier */
 	rdmsr(MSR_IA32_PERF_STATUS, lo, hi);
 	current_voltage = lo & 0xff;
-	pr_info("eps: Current voltage = %dmV\n", current_voltage * 16 + 700);
+	pr_info("Current voltage = %dmV\n", current_voltage * 16 + 700);
 	current_multiplier = (lo >> 8) & 0xff;
-	pr_info("eps: Current multiplier = %d\n", current_multiplier);
+	pr_info("Current multiplier = %d\n", current_multiplier);
 
 	/* Print limits */
 	max_voltage = hi & 0xff;
-	pr_info("eps: Highest voltage = %dmV\n", max_voltage * 16 + 700);
+	pr_info("Highest voltage = %dmV\n", max_voltage * 16 + 700);
 	max_multiplier = (hi >> 8) & 0xff;
-	pr_info("eps: Highest multiplier = %d\n", max_multiplier);
+	pr_info("Highest multiplier = %d\n", max_multiplier);
 	min_voltage = (hi >> 16) & 0xff;
-	pr_info("eps: Lowest voltage = %dmV\n", min_voltage * 16 + 700);
+	pr_info("Lowest voltage = %dmV\n", min_voltage * 16 + 700);
 	min_multiplier = (hi >> 24) & 0xff;
-	pr_info("eps: Lowest multiplier = %d\n", min_multiplier);
+	pr_info("Lowest multiplier = %d\n", min_multiplier);
 
 	/* Sanity checks */
 	if (current_multiplier == 0 || max_multiplier == 0
@@ -271,13 +273,13 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
 
 	/* Check for systems using underclocked CPU */
 	if (!freq_failsafe_off && max_multiplier != current_multiplier) {
-		pr_info("eps: Your processor is running at different frequency then its maximum. Aborting.\n");
-		pr_info("eps: You can use freq_failsafe_off option to disable this check.\n");
+		pr_info("Your processor is running at different frequency then its maximum. Aborting.\n");
+		pr_info("You can use freq_failsafe_off option to disable this check.\n");
 		return -EINVAL;
 	}
 	if (!voltage_failsafe_off && max_voltage != current_voltage) {
-		pr_info("eps: Your processor is running at different voltage then its maximum. Aborting.\n");
-		pr_info("eps: You can use voltage_failsafe_off option to disable this check.\n");
+		pr_info("Your processor is running at different voltage then its maximum. Aborting.\n");
+		pr_info("You can use voltage_failsafe_off option to disable this check.\n");
 		return -EINVAL;
 	}
 
@@ -288,13 +290,13 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
 	/* Check for ACPI processor speed limit */
 	if (!ignore_acpi_limit && !eps_acpi_init()) {
 		if (!acpi_processor_get_bios_limit(policy->cpu, &limit)) {
-			pr_info("eps: ACPI limit %u.%uGHz\n",
+			pr_info("ACPI limit %u.%uGHz\n",
 				limit/1000000,
 				(limit%1000000)/10000);
 			eps_acpi_exit(policy);
 			/* Check if max_multiplier is in BIOS limits */
 			if (limit && max_multiplier * fsb > limit) {
-				pr_info("eps: Aborting\n");
+				pr_info("Aborting\n");
 				return -EINVAL;
 			}
 		}
@@ -310,7 +312,7 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
 		v = (set_max_voltage - 700) / 16;
 		/* Check if voltage is within limits */
 		if (v >= min_voltage && v <= max_voltage) {
-			pr_info("eps: Setting %dmV as maximum\n", v * 16 + 700);
+			pr_info("Setting %dmV as maximum\n", v * 16 + 700);
 			max_voltage = v;
 		}
 	}
drivers/cpufreq/elanfreq.c +2 -0
index 8f4dded..bfce11c 100644
@@ -16,6 +16,8 @@
  *
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/init.h>
drivers/cpufreq/ia64-acpi-cpufreq.c +3 -2
index fd36d6c..759612d 100644
@@ -8,6 +8,8 @@
  *      Venkatesh Pallipadi <[email protected]>
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/module.h>
@@ -290,8 +292,7 @@ acpi_cpufreq_cpu_init (
 	/* notify BIOS that we exist */
 	acpi_processor_notify_smm(THIS_MODULE);
 
-	pr_info("acpi-cpufreq: CPU%u - ACPI performance management activated\n",
-		cpu);
+	pr_info("CPU%u - ACPI performance management activated\n", cpu);
 
 	for (i = 0; i < data->acpi_data.state_count; i++)
 		pr_debug("     %cP%d: %d MHz, %d mW, %d uS, %d uS, 0x%x 0x%x\n",
drivers/cpufreq/longhaul.c +30 -30

213 lines not on this page · raw message

drivers/cpufreq/loongson2_cpufreq.c +5 -2
index 93c7928..6bbdac1 100644
@@ -10,6 +10,9 @@
  * License.  See the file "COPYING" in the main directory of this archive
  * for more details.
  */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/cpufreq.h>
 #include <linux/module.h>
 #include <linux/err.h>
@@ -76,7 +79,7 @@ static int loongson2_cpufreq_cpu_init(struct cpufreq_policy *policy)
 
 	cpuclk = clk_get(NULL, "cpu_clk");
 	if (IS_ERR(cpuclk)) {
-		pr_err("cpufreq: couldn't get CPU clk\n");
+		pr_err("couldn't get CPU clk\n");
 		return PTR_ERR(cpuclk);
 	}
 
@@ -163,7 +166,7 @@ static int __init cpufreq_init(void)
 	if (ret)
 		return ret;
 
-	pr_info("cpufreq: Loongson-2F CPU frequency driver.\n");
+	pr_info("Loongson-2F CPU frequency driver\n");
 
 	cpufreq_register_notifier(&loongson2_cpufreq_notifier_block,
 				  CPUFREQ_TRANSITION_NOTIFIER);
drivers/cpufreq/maple-cpufreq.c +4 -2
index 7e55632..d9df893 100644
@@ -13,6 +13,8 @@
 
 #undef DEBUG
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/errno.h>
@@ -174,7 +176,7 @@ static int __init maple_cpufreq_init(void)
 	/* Get first CPU node */
 	cpunode = of_cpu_device_node_get(0);
 	if (cpunode == NULL) {
-		pr_err("cpufreq: Can't find any CPU 0 node\n");
+		pr_err("Can't find any CPU 0 node\n");
 		goto bail_noprops;
 	}
 
@@ -182,7 +184,7 @@ static int __init maple_cpufreq_init(void)
 	/* we actually don't care on which CPU to access PVR */
 	pvr_hi = PVR_VER(mfspr(SPRN_PVR));
 	if (pvr_hi != 0x3c && pvr_hi != 0x44) {
-		pr_err("cpufreq: Unsupported CPU version (%x)\n", pvr_hi);
+		pr_err("Unsupported CPU version (%x)\n", pvr_hi);
 		goto bail_noprops;
 	}
 
drivers/cpufreq/omap-cpufreq.c +4 -1
index 655fc94..cead9be 100644
@@ -13,6 +13,9 @@
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
  */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/sched.h>
@@ -163,7 +166,7 @@ static int omap_cpufreq_probe(struct platform_device *pdev)
 {
 	mpu_dev = get_cpu_device(0);
 	if (!mpu_dev) {
-		pr_warn("%s: unable to get the mpu device\n", __func__);
+		pr_warn("%s: unable to get the MPU device\n", __func__);
 		return -EINVAL;
 	}
 
drivers/cpufreq/p4-clockmod.c +5 -5
index 4d1a443..fd77812 100644
@@ -20,6 +20,8 @@
  *
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/init.h>
@@ -35,8 +37,6 @@
 
 #include "speedstep-lib.h"
 
-#define PFX	"p4-clockmod: "
-
 /*
  * Duty Cycle (3bits), note DC_DISABLE is not specified in
  * intel docs i just use it to mean disable
@@ -124,7 +124,7 @@ static unsigned int cpufreq_p4_get_frequency(struct cpuinfo_x86 *c)
 {
 	if (c->x86 == 0x06) {
 		if (cpu_has(c, X86_FEATURE_EST))
-			pr_warn_once(PFX "Warning: EST-capable CPU detected. The acpi-cpufreq module offers voltage scaling in addition to frequency scaling. You should use that instead of p4-clockmod, if possible.\n");
+			pr_warn_once("Warning: EST-capable CPU detected. The acpi-cpufreq module offers voltage scaling in addition to frequency scaling. You should use that instead of p4-clockmod, if possible.\n");
 		switch (c->x86_model) {
 		case 0x0E: /* Core */
 		case 0x0F: /* Core Duo */
@@ -148,7 +148,7 @@ static unsigned int cpufreq_p4_get_frequency(struct cpuinfo_x86 *c)
 	p4clockmod_driver.flags |= CPUFREQ_CONST_LOOPS;
 
 	if (speedstep_detect_processor() == SPEEDSTEP_CPU_P4M) {
-		pr_warn(PFX "Warning: Pentium 4-M detected. The speedstep-ich or acpi cpufreq modules offer voltage scaling in addition of frequency scaling. You should use either one instead of p4-clockmod, if possible.\n");
+		pr_warn("Warning: Pentium 4-M detected. The speedstep-ich or acpi cpufreq modules offer voltage scaling in addition of frequency scaling. You should use either one instead of p4-clockmod, if possible.\n");
 		return speedstep_get_frequency(SPEEDSTEP_CPU_P4M);
 	}
 
@@ -257,7 +257,7 @@ static int __init cpufreq_p4_init(void)
 
 	ret = cpufreq_register_driver(&p4clockmod_driver);
 	if (!ret)
-		pr_info(PFX "P4/Xeon(TM) CPU On-Demand Clock Modulation available\n");
+		pr_info("P4/Xeon(TM) CPU On-Demand Clock Modulation available\n");
 
 	return ret;
 }
drivers/cpufreq/pmac32-cpufreq.c +5 -3
index 072d7b3..b7b576e 100644
@@ -13,6 +13,8 @@
  *
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/errno.h>
@@ -481,13 +483,13 @@ static int pmac_cpufreq_init_MacRISC3(struct device_node *cpunode)
 		freqs = of_get_property(cpunode, "bus-frequencies", &lenp);
 		lenp /= sizeof(u32);
 		if (freqs == NULL || lenp != 2) {
-			pr_err("cpufreq: bus-frequencies incorrect or missing\n");
+			pr_err("bus-frequencies incorrect or missing\n");
 			return 1;
 		}
 		ratio = of_get_property(cpunode, "processor-to-bus-ratio*2",
 						NULL);
 		if (ratio == NULL) {
-			pr_err("cpufreq: processor-to-bus-ratio*2 missing\n");
+			pr_err("processor-to-bus-ratio*2 missing\n");
 			return 1;
 		}
 
@@ -550,7 +552,7 @@ static int pmac_cpufreq_init_7447A(struct device_node *cpunode)
 	if (volt_gpio_np)
 		voltage_gpio = read_gpio(volt_gpio_np);
 	if (!voltage_gpio){
-		pr_err("cpufreq: missing cpu-vcore-select gpio\n");
+		pr_err("missing cpu-vcore-select gpio\n");
 		return 1;
 	}
 
drivers/cpufreq/pmac64-cpufreq.c +15 -13
index 5ffe085..267e089 100644
@@ -12,6 +12,8 @@
 
 #undef DEBUG
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/errno.h>
@@ -138,7 +140,7 @@ static void g5_vdnap_switch_volt(int speed_mode)
 		usleep_range(1000, 1000);
 	}
 	if (done == 0)
-		pr_warn("cpufreq: Timeout in clock slewing !\n");
+		pr_warn("Timeout in clock slewing !\n");
 }
 
 
@@ -266,7 +268,7 @@ static int g5_pfunc_switch_freq(int speed_mode)
 		rc = pmf_call_one(pfunc_cpu_setfreq_low, NULL);
 
 	if (rc)
-		pr_warn("cpufreq: pfunc switch error %d\n", rc);
+		pr_warn("pfunc switch error %d\n", rc);
 
 	/* It's an irq GPIO so we should be able to just block here,
 	 * I'll do that later after I've properly tested the IRQ code for
@@ -282,7 +284,7 @@ static int g5_pfunc_switch_freq(int speed_mode)
 		usleep_range(500, 500);
 	}
 	if (done == 0)
-		pr_warn("cpufreq: Timeout in clock slewing !\n");
+		pr_warn("Timeout in clock slewing !\n");
 
 	/* If frequency is going down, last ramp the voltage */
 	if (speed_mode > g5_pmode_cur)
@@ -368,7 +370,7 @@ static int __init g5_neo2_cpufreq_init(struct device_node *cpunode)
 	}
 	pvr_hi = (*valp) >> 16;
 	if (pvr_hi != 0x3c && pvr_hi != 0x44) {
-		pr_err("cpufreq: Unsupported CPU version\n");
+		pr_err("Unsupported CPU version\n");
 		goto bail_noprops;
 	}
 
@@ -403,7 +405,7 @@ static int __init g5_neo2_cpufreq_init(struct device_node *cpunode)
 
 		root = of_find_node_by_path("/");
 		if (root == NULL) {
-			pr_err("cpufreq: Can't find root of device tree\n");
+			pr_err("Can't find root of device tree\n");
 			goto bail_noprops;
 		}
 		pfunc_set_vdnap0 = pmf_find_function(root, "set-vdnap0");
@@ -411,7 +413,7 @@ static int __init g5_neo2_cpufreq_init(struct device_node *cpunode)
 			pmf_find_function(root, "slewing-done");
 		if (pfunc_set_vdnap0 == NULL ||
 		    pfunc_vdnap0_complete == NULL) {
-			pr_err("cpufreq: Can't find required platform function\n");
+			pr_err("Can't find required platform function\n");
 			goto bail_noprops;
 		}
 
@@ -491,7 +493,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
 	if (cpuid != NULL)
 		eeprom = of_get_property(cpuid, "cpuid", NULL);
 	if (eeprom == NULL) {
-		pr_err("cpufreq: Can't find cpuid EEPROM !\n");
+		pr_err("Can't find cpuid EEPROM !\n");
 		rc = -ENODEV;
 		goto bail;
 	}
@@ -509,7 +511,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
 		break;
 	}
 	if (hwclock == NULL) {
-		pr_err("cpufreq: Can't find i2c clock chip !\n");
+		pr_err("Can't find i2c clock chip !\n");
 		rc = -ENODEV;
 		goto bail;
 	}
@@ -537,7 +539,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
 	/* Check we have minimum requirements */
 	if (pfunc_cpu_getfreq == NULL || pfunc_cpu_setfreq_high == NULL ||
 	    pfunc_cpu_setfreq_low == NULL || pfunc_slewing_done == NULL) {
-		pr_err("cpufreq: Can't find platform functions !\n");
+		pr_err("Can't find platform functions !\n");
 		rc = -ENODEV;
 		goto bail;
 	}
@@ -565,7 +567,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
 	/* Get max frequency from device-tree */
 	valp = of_get_property(cpunode, "clock-frequency", NULL);
 	if (!valp) {
-		pr_err("cpufreq: Can't find CPU frequency !\n");
+		pr_err("Can't find CPU frequency !\n");
 		rc = -ENODEV;
 		goto bail;
 	}
@@ -581,7 +583,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
 
 	/* Check for machines with no useful settings */
 	if (il == ih) {
-		pr_warn("cpufreq: No low frequency mode available on this model !\n");
+		pr_warn("No low frequency mode available on this model !\n");
 		rc = -ENODEV;
 		goto bail;
 	}
@@ -592,7 +594,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
 
 	/* Sanity check */
 	if (min_freq >= max_freq || min_freq < 1000) {
-		pr_err("cpufreq: Can't calculate low frequency !\n");
+		pr_err("Can't calculate low frequency !\n");
 		rc = -ENXIO;
 		goto bail;
 	}
@@ -651,7 +653,7 @@ static int __init g5_cpufreq_init(void)
 	/* Get first CPU node */
 	cpunode = of_cpu_device_node_get(0);
 	if (cpunode == NULL) {
-		pr_err("cpufreq: Can't find any CPU node\n");
+		pr_err("Can't find any CPU node\n");
 		return -ENODEV;
 	}
 
drivers/cpufreq/powernow-k6.c +8 -7
index 981f40b..dedd256 100644
@@ -8,6 +8,8 @@
  *  BIG FAT DISCLAIMER: Work in progress code. Possibly *dangerous*
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/init.h>
@@ -22,7 +24,6 @@
 #define POWERNOW_IOPORT 0xfff0          /* it doesn't matter where, as long
 					   as it is unused */
 
-#define PFX "powernow-k6: "
 static unsigned int                     busfreq;   /* FSB, in 10 kHz */
 static unsigned int                     max_multiplier;
 
@@ -141,7 +142,7 @@ static int powernow_k6_target(struct cpufreq_policy *policy,
 {
 
 	if (clock_ratio[best_i].driver_data > max_multiplier) {
-		pr_err(PFX "invalid target frequency\n");
+		pr_err("invalid target frequency\n");
 		return -EINVAL;
 	}
 
@@ -175,14 +176,14 @@ static int powernow_k6_cpu_init(struct cpufreq_policy *policy)
 				max_multiplier = param_max_multiplier;
 				goto have_max_multiplier;
 			}
-		pr_err("powernow-k6: invalid max_multiplier parameter, valid parameters 20, 30, 35, 40, 45, 50, 55, 60\n");
+		pr_err("invalid max_multiplier parameter, valid parameters 20, 30, 35, 40, 45, 50, 55, 60\n");
 		return -EINVAL;
 	}
 
 	if (!max_multiplier) {
-		pr_warn("powernow-k6: unknown frequency %u, cannot determine current multiplier\n",
+		pr_warn("unknown frequency %u, cannot determine current multiplier\n",
 			khz);
-		pr_warn("powernow-k6: use module parameters max_multiplier and bus_frequency\n");
+		pr_warn("use module parameters max_multiplier and bus_frequency\n");
 		return -EOPNOTSUPP;
 	}
 
@@ -194,7 +195,7 @@ have_max_multiplier:
 			busfreq = param_busfreq / 10;
 			goto have_busfreq;
 		}
-		pr_err("powernow-k6: invalid bus_frequency parameter, allowed range 50000 - 150000 kHz\n");
+		pr_err("invalid bus_frequency parameter, allowed range 50000 - 150000 kHz\n");
 		return -EINVAL;
 	}
 
@@ -276,7 +277,7 @@ static int __init powernow_k6_init(void)
 		return -ENODEV;
 
 	if (!request_region(POWERNOW_IOPORT, 16, "PowerNow!")) {
-		pr_info(PFX "PowerNow IOPORT region already used\n");
+		pr_info("PowerNow IOPORT region already used\n");
 		return -EIO;
 	}
 
drivers/cpufreq/powernow-k7.c +21 -22

147 lines not on this page · raw message

drivers/cpufreq/pxa2xx-cpufreq.c +7 -6
index 8a27667..ce345bf 100644
@@ -29,6 +29,8 @@
  *
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/sched.h>
@@ -186,8 +188,7 @@ static int pxa_cpufreq_change_voltage(const struct pxa_freqs *pxa_freq)
 
 	ret = regulator_set_voltage(vcc_core, vmin, vmax);
 	if (ret)
-		pr_err("cpufreq: Failed to set vcc_core in [%dmV..%dmV]\n",
-		       vmin, vmax);
+		pr_err("Failed to set vcc_core in [%dmV..%dmV]\n", vmin, vmax);
 	return ret;
 }
 
@@ -195,10 +196,10 @@ static void __init pxa_cpufreq_init_voltages(void)
 {
 	vcc_core = regulator_get(NULL, "vcc_core");
 	if (IS_ERR(vcc_core)) {
-		pr_info("cpufreq: Didn't find vcc_core regulator\n");
+		pr_info("Didn't find vcc_core regulator\n");
 		vcc_core = NULL;
 	} else {
-		pr_info("cpufreq: Found vcc_core regulator\n");
+		pr_info("Found vcc_core regulator\n");
 	}
 }
 #else
@@ -407,7 +408,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
 	 */
 	if (cpu_is_pxa25x()) {
 		find_freq_tables(&pxa255_freq_table, &pxa255_freqs);
-		pr_info("PXA255 cpufreq using %s frequency table\n",
+		pr_info("using %s frequency table\n",
 			pxa255_turbo_table ? "turbo" : "run");
 
 		cpufreq_table_validate_and_show(policy, pxa255_freq_table);
@@ -416,7 +417,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
 		cpufreq_table_validate_and_show(policy, pxa27x_freq_table);
 	}
 
-	pr_info("PXA CPU frequency change support initialized\n");
+	pr_info("frequency change support initialized\n");
 
 	return 0;
 }
drivers/cpufreq/s3c2412-cpufreq.c +8 -6
index f9447ba..b04b6f0 100644
@@ -10,6 +10,8 @@
  * published by the Free Software Foundation.
 */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/interrupt.h>
@@ -197,20 +199,20 @@ static int s3c2412_cpufreq_add(struct device *dev,
 
 	hclk = clk_get(NULL, "hclk");
 	if (IS_ERR(hclk)) {
-		pr_err("%s: cannot find hclk clock\n", __func__);
+		pr_err("cannot find hclk clock\n");
 		return -ENOENT;
 	}
 
 	fclk = clk_get(NULL, "fclk");
 	if (IS_ERR(fclk)) {
-		pr_err("%s: cannot find fclk clock\n", __func__);
+		pr_err("cannot find fclk clock\n");
 		goto err_fclk;
 	}
 
 	fclk_rate = clk_get_rate(fclk);
 	if (fclk_rate > 200000000) {
-		pr_info("%s: fclk %ld MHz, assuming 266MHz capable part\n",
-			__func__, fclk_rate / 1000000);
+		pr_info("fclk %ld MHz, assuming 266MHz capable part\n",
+			fclk_rate / 1000000);
 		s3c2412_cpufreq_info.max.fclk = 266000000;
 		s3c2412_cpufreq_info.max.hclk = 133000000;
 		s3c2412_cpufreq_info.max.pclk =  66000000;
@@ -218,13 +220,13 @@ static int s3c2412_cpufreq_add(struct device *dev,
 
 	armclk = clk_get(NULL, "armclk");
 	if (IS_ERR(armclk)) {
-		pr_err("%s: cannot find arm clock\n", __func__);
+		pr_err("cannot find arm clock\n");
 		goto err_armclk;
 	}
 
 	xtal = clk_get(NULL, "xtal");
 	if (IS_ERR(xtal)) {
-		pr_err("%s: cannot find xtal clock\n", __func__);
+		pr_err("cannot find xtal clock\n");
 		goto err_xtal;
 	}
 
drivers/cpufreq/s3c2440-cpufreq.c +2 -0
index f6cefe3..d0d75b6 100644
@@ -11,6 +11,8 @@
  * published by the Free Software Foundation.
 */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/interrupt.h>
drivers/cpufreq/s3c24xx-cpufreq-debugfs.c +2 -0
index 8182608..4d976e8 100644
@@ -10,6 +10,8 @@
  * published by the Free Software Foundation.
 */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/init.h>
 #include <linux/export.h>
 #include <linux/interrupt.h>
drivers/cpufreq/s3c24xx-cpufreq.c +5 -3
index 68f8837..ae8eaed 100644
@@ -10,6 +10,8 @@
  * published by the Free Software Foundation.
 */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/interrupt.h>
@@ -356,7 +358,7 @@ struct clk *s3c_cpufreq_clk_get(struct device *dev, const char *name)
 
 	clk = clk_get(dev, name);
 	if (IS_ERR(clk))
-		pr_err("cpufreq: failed to get clock '%s'\n", name);
+		pr_err("failed to get clock '%s'\n", name);
 
 	return clk;
 }
@@ -665,9 +667,9 @@ int s3c_plltab_register(struct cpufreq_frequency_table *plls,
 		vals += plls_no;
 		vals->frequency = CPUFREQ_TABLE_END;
 
-		pr_info("cpufreq: %d PLL entries\n", plls_no);
+		pr_info("%d PLL entries\n", plls_no);
 	} else
-		pr_err("cpufreq: no memory for PLL tables\n");
+		pr_err("no memory for PLL tables\n");
 
 	return vals ? 0 : -ENOMEM;
 }
drivers/cpufreq/s5pv210-cpufreq.c +4 -2
index 344e584..06d8591 100644
@@ -9,6 +9,8 @@
  * published by the Free Software Foundation.
 */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
@@ -635,13 +637,13 @@ static int s5pv210_cpufreq_probe(struct platform_device *pdev)
 
 	arm_regulator = regulator_get(NULL, "vddarm");
 	if (IS_ERR(arm_regulator)) {
-		pr_err("failed to get regulator vddarm");
+		pr_err("failed to get regulator vddarm\n");
 		return PTR_ERR(arm_regulator);
 	}
 
 	int_regulator = regulator_get(NULL, "vddint");
 	if (IS_ERR(int_regulator)) {
-		pr_err("failed to get regulator vddint");
+		pr_err("failed to get regulator vddint\n");
 		regulator_put(arm_regulator);
 		return PTR_ERR(int_regulator);
 	}
drivers/cpufreq/sc520_freq.c +3 -3
index 57bbddf..4225501 100644
@@ -13,6 +13,8 @@
  *	2005-03-30: - initial revision
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/init.h>
@@ -30,8 +32,6 @@
 
 static __u8 __iomem *cpuctl;
 
-#define PFX "sc520_freq: "
-
 static struct cpufreq_frequency_table sc520_freq_table[] = {
 	{0, 0x01,	100000},
 	{0, 0x02,	133000},
@@ -44,7 +44,7 @@ static unsigned int sc520_freq_get_cpu_frequency(unsigned int cpu)
 
 	switch (clockspeed_reg & 0x03) {
 	default:
-		pr_err(PFX "error: cpuctl register has unexpected value %02x\n",
+		pr_err("error: cpuctl register has unexpected value %02x\n",
 		       clockspeed_reg);
 	case 0x01:
 		return 100000;
drivers/cpufreq/speedstep-centrino.c +3 -2
index 47df2d6..41bc539 100644
@@ -13,6 +13,8 @@
  * Copyright (C) 2003 Jeremy Fitzhardinge <[email protected]>
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/init.h>
@@ -27,7 +29,6 @@
 #include <asm/cpufeature.h>
 #include <asm/cpu_device_id.h>
 
-#define PFX		"speedstep-centrino: "
 #define MAINTAINER	"[email protected]"
 
 #define INTEL_MSR_RANGE	(0xffff)
@@ -386,7 +387,7 @@ static int centrino_cpu_init(struct cpufreq_policy *policy)
 		/* check to see if it stuck */
 		rdmsr(MSR_IA32_MISC_ENABLE, l, h);
 		if (!(l & MSR_IA32_MISC_ENABLE_ENHANCED_SPEEDSTEP)) {
-			pr_info(PFX "couldn't enable Enhanced SpeedStep\n");
+			pr_info("couldn't enable Enhanced SpeedStep\n");
 			return -ENODEV;
 		}
 	}
drivers/cpufreq/speedstep-ich.c +5 -3
index 9d00c22..b86953a 100644
@@ -18,6 +18,8 @@
  *                        SPEEDSTEP - DEFINITIONS                    *
  *********************************************************************/
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/init.h>
@@ -68,13 +70,13 @@ static int speedstep_find_register(void)
 	/* get PMBASE */
 	pci_read_config_dword(speedstep_chipset_dev, 0x40, &pmbase);
 	if (!(pmbase & 0x01)) {
-		pr_err("speedstep-ich: could not find speedstep register\n");
+		pr_err("could not find speedstep register\n");
 		return -ENODEV;
 	}
 
 	pmbase &= 0xFFFFFFFE;
 	if (!pmbase) {
-		pr_err("speedstep-ich: could not find speedstep register\n");
+		pr_err("could not find speedstep register\n");
 		return -ENODEV;
 	}
 
@@ -136,7 +138,7 @@ static void speedstep_set_state(unsigned int state)
 		pr_debug("change to %u MHz succeeded\n",
 			speedstep_get_frequency(speedstep_processor) / 1000);
 	else
-		pr_err("cpufreq: change failed - I/O error\n");
+		pr_err("change failed - I/O error\n");
 
 	return;
 }
drivers/cpufreq/speedstep-lib.c +3 -1
index 32bdf1d..1b80621 100644
@@ -8,6 +8,8 @@
  *  BIG FAT DISCLAIMER: Work in progress code. Possibly *dangerous*
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
@@ -453,7 +455,7 @@ unsigned int speedstep_get_freqs(enum speedstep_processor processor,
 		 */
 		if (*transition_latency > 10000000 ||
 		    *transition_latency < 50000) {
-			pr_warn(PFX "frequency transition measured seems out of range (%u nSec), falling back to a safe one of %u nSec\n",
+			pr_warn("frequency transition measured seems out of range (%u nSec), falling back to a safe one of %u nSec\n",
 				*transition_latency, 500000);
 			*transition_latency = 500000;
 		}
drivers/cpufreq/speedstep-smi.c +3 -1
index af32a5f..770a9ae 100644
@@ -12,6 +12,8 @@
  *                        SPEEDSTEP - DEFINITIONS                    *
  *********************************************************************/
 
+#define pr_fmt(fmt) "cpufreq: " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
@@ -204,7 +206,7 @@ static void speedstep_set_state(unsigned int state)
 			(speedstep_freqs[new_state].frequency / 1000),
 			retry, result);
 	else
-		pr_err("cpufreq: change to state %u failed with new_state %u and result %u\n",
+		pr_err("change to state %u failed with new_state %u and result %u\n",
 		       state, new_state, result);
 
 	return;
Signature · 1 line
2.8.0.rc4.16.g56331f8
maintainer Acked-by on v1 3/3
#11 lore raw

Re: [PATCH 3/3] cpufreq: Use consistent prefixing via pr_fmt

Quoted 26 lines · Joe Perches

Use the more common kernel style adding a define for pr_fmt.

Miscellanea:

o Remove now unused PFX defines

---
 drivers/cpufreq/acpi-cpufreq.c            |  8 ++---
 drivers/cpufreq/cpufreq-nforce2.c         | 20 +++++------
 drivers/cpufreq/e_powersaver.c            | 38 ++++++++++----------
 drivers/cpufreq/elanfreq.c                |  2 ++
 drivers/cpufreq/ia64-acpi-cpufreq.c       |  5 +--
 drivers/cpufreq/longhaul.c                | 60 +++++++++++++++----------------
 drivers/cpufreq/loongson2_cpufreq.c       |  7 ++--
 drivers/cpufreq/maple-cpufreq.c           |  6 ++--
 drivers/cpufreq/omap-cpufreq.c            |  5 ++-
 drivers/cpufreq/p4-clockmod.c             | 10 +++---
 drivers/cpufreq/pmac32-cpufreq.c          |  8 +++--
 drivers/cpufreq/pmac64-cpufreq.c          | 28 ++++++++-------
 drivers/cpufreq/powernow-k6.c             | 15 ++++----
 drivers/cpufreq/powernow-k7.c             | 43 +++++++++++-----------
 drivers/cpufreq/pxa2xx-cpufreq.c          | 13 +++----
 drivers/cpufreq/s3c2412-cpufreq.c         | 14 ++++----
 drivers/cpufreq/s3c2440-cpufreq.c         |  2 ++
 drivers/cpufreq/s3c24xx-cpufreq-debugfs.c |  2 ++
Quoted 8 lines
 drivers/cpufreq/s3c24xx-cpufreq.c         |  8 +++--
 drivers/cpufreq/s5pv210-cpufreq.c         |  6 ++--
 drivers/cpufreq/sc520_freq.c              |  6 ++--
 drivers/cpufreq/speedstep-centrino.c      |  5 +--
 drivers/cpufreq/speedstep-ich.c           |  8 +++--
 drivers/cpufreq/speedstep-lib.c           |  4 ++-
 drivers/cpufreq/speedstep-smi.c           |  4 ++-
 25 files changed, 181 insertions(+), 146 deletions(-)
Signature · 1 line
viresh
#12 lore raw
In reply to Joe Perches
Quoted 26 lines · Joe Perches

Trivial consistency changes.

Joe Perches (3):
intel_pstate: Use pr_fmt
cpufreq: Convert printk(KERN_<LEVEL> to pr_<level>
cpufreq: Use consistent prefixing via pr_fmt

 drivers/cpufreq/acpi-cpufreq.c            | 16 +++---
 drivers/cpufreq/cpufreq-nforce2.c         | 28 +++++------
 drivers/cpufreq/e_powersaver.c            | 62 ++++++++++-------------
 drivers/cpufreq/elanfreq.c                |  4 +-
 drivers/cpufreq/ia64-acpi-cpufreq.c       | 10 ++--
 drivers/cpufreq/intel_pstate.c            | 18 ++++---
 drivers/cpufreq/longhaul.c                | 84 +++++++++++++------------------
 drivers/cpufreq/loongson2_cpufreq.c       |  7 ++-
 drivers/cpufreq/maple-cpufreq.c           | 11 ++--
 drivers/cpufreq/omap-cpufreq.c            |  7 ++-
 drivers/cpufreq/p4-clockmod.c             | 19 ++-----
 drivers/cpufreq/pmac32-cpufreq.c          | 14 +++---
 drivers/cpufreq/pmac64-cpufreq.c          | 47 +++++++++--------
 drivers/cpufreq/powernow-k6.c             | 16 +++---
 drivers/cpufreq/powernow-k7.c             | 70 +++++++++++---------------
 drivers/cpufreq/pxa2xx-cpufreq.c          | 18 +++----
 drivers/cpufreq/s3c2412-cpufreq.c         | 15 +++---
 drivers/cpufreq/s3c2440-cpufreq.c         |  6 ++-
 drivers/cpufreq/s3c24xx-cpufreq-debugfs.c |  4 +-
Quoted 8 lines
 drivers/cpufreq/s3c24xx-cpufreq.c         | 59 +++++++++++-----------
 drivers/cpufreq/s5pv210-cpufreq.c         | 10 ++--
 drivers/cpufreq/sc520_freq.c              | 10 ++--
 drivers/cpufreq/speedstep-centrino.c      |  6 +--
 drivers/cpufreq/speedstep-ich.c           |  8 +--
 drivers/cpufreq/speedstep-lib.c           | 11 ++--
 drivers/cpufreq/speedstep-smi.c           |  7 +--
 26 files changed, 269 insertions(+), 298 deletions(-)

All [1-3/3] applied, thanks!