ARM: zx: zx296702-pm-domain.c: Fix check return value of devm_ioremap_resource

PATCH RESEND New Axel Lin 1 participant 1 message Apr 7, 2016

Subsystems (2)

Arm (32-bit) Arm sub-architectures

lore

Share & tools

lore

Axel Lin

author

2016-04-07 06:28 UTC #0 lore raw

PATCH RESEND 1/1 ARM: zx: zx296702-pm-domain.c: Fix check return value of devm_ioremap_resource

devm_ioremap_resource() returns ERR_PTR on failure. devm_ioremap_resource() will also check res argument and show proper error on error path, so remove the redundant checking for res and error messages.

Signed-off-by Axel Lin <[email protected]>

Reviewed-by Jun Nie <[email protected]>

---
This was sent on
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/370318.html

 arch/arm/mach-zx/zx296702-pm-domain.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

arch/arm/mach-zx/zx296702-pm-domain.c +2 -9

index e08574d..17f778b 100644
@@ -163,16 +163,9 @@ static int zx296702_pd_probe(struct platform_device *pdev)
 	genpd_data->num_domains = ARRAY_SIZE(zx296702_pm_domains);
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res) {
-		dev_err(&pdev->dev, "no memory resource defined\n");
-		return -ENODEV;
-	}
-
 	pcubase = devm_ioremap_resource(&pdev->dev, res);
-	if (!pcubase) {
-		dev_err(&pdev->dev, "ioremap fail.\n");
-		return -EIO;
-	}
+	if (IS_ERR(pcubase))
+		return PTR_ERR(pcubase);
 
 	for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
 		pm_genpd_init(zx296702_pm_domains[i], NULL, false);

Signature · 1 line

2.1.4