Skip to contentSkip to conversation

drm/i915: Use consistent forcewake auto-release timeout across kernel configs

PATCH In review Tvrtko Ursulin 4 participants 8 messages Apr 7, 2016 – Apr 12, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 drm/i915: Use consistent forcewake auto-release timeout across kernel configs

From: Tvrtko Ursulin <[email protected]>

Because it is based on jiffies, current implementation releases the forcewake at any time between straight away and between 1ms and 10ms, depending on the kernel configuration (CONFIG_HZ).

This is probably not what has been desired, since the dynamics of keeping parts of the GPU awake should not be correlated with this kernel configuration parameter.

Change the auto-release mechanism to use hrtimers and set the timeout to 1ms with a 1ms of slack. This should make the GPU power consistent across kernel configs, and timer slack should enable some timer coalescing where multiple force-wake domains exist, or with unrelated timers.

For GlBench/T-Rex this decreases the number of forcewake releases from ~480 to ~300 per second, and for a heavy combined OGL/OCL test from ~670 to ~360 (HZ=1000 kernel).

Even though this reduction can be attributed to the average release period extending from 0-1ms to 1-2ms, as discussed above, it will make the forcewake timeout consistent for different CONFIG_HZ values.

Real life measurements with the above workload has shown that, with this patch, both manage to auto-release the forcewake between 2-4 times per 10ms, even though the number of forcewake gets is dramatically different.

T-Rex requests between 5-10 explicit gets and 5-10 implict gets in each 10ms period, while the OGL/OCL test requests 250 and 380 times in the same period.

The two data points together suggest that the nature of the forwake accesses is bursty and that further changes and potential timeout extensions, or moving the start of timeout from the first to the last automatic forcewake grab, should be carefully measured for power and performance effects.

v2:
* Commit spelling. (Dave Gordon)
* More discussion on numbers in the commit. (Chris Wilson)

---
 drivers/gpu/drm/i915/i915_drv.h     |  2 +-
 drivers/gpu/drm/i915/intel_uncore.c | 25 ++++++++++++++++---------
 2 files changed, 17 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -1
index 4ebd3ff02803..a1dae0d6ba23 100644
@@ -666,7 +666,7 @@ struct intel_uncore {
 		struct drm_i915_private *i915;
 		enum forcewake_domain_id id;
 		unsigned wake_count;
-		struct timer_list timer;
+		struct hrtimer timer;
 		i915_reg_t reg_set;
 		u32 val_set;
 		u32 val_clear;
drivers/gpu/drm/i915/intel_uncore.c +16 -9
index ac2ac07b505b..24bedac64518 100644
@@ -60,7 +60,11 @@ fw_domain_reset(const struct intel_uncore_forcewake_domain *d)
 static inline void
 fw_domain_arm_timer(struct intel_uncore_forcewake_domain *d)
 {
-	mod_timer_pinned(&d->timer, jiffies + 1);
+	d->wake_count++;
+	hrtimer_start_range_ns(&d->timer,
+			       ktime_set(0, NSEC_PER_MSEC),
+			       NSEC_PER_MSEC,
+			       HRTIMER_MODE_REL);
 }
 
 static inline void
@@ -224,9 +228,11 @@ static int __gen6_gt_wait_for_fifo(struct drm_i915_private *dev_priv)
 	return ret;
 }
 
-static void intel_uncore_fw_release_timer(unsigned long arg)
+static enum hrtimer_restart
+intel_uncore_fw_release_timer(struct hrtimer *timer)
 {
-	struct intel_uncore_forcewake_domain *domain = (void *)arg;
+	struct intel_uncore_forcewake_domain *domain =
+	       container_of(timer, struct intel_uncore_forcewake_domain, timer);
 	unsigned long irqflags;
 
 	assert_rpm_device_not_suspended(domain->i915);
@@ -240,6 +246,8 @@ static void intel_uncore_fw_release_timer(unsigned long arg)
 							  1 << domain->id);
 
 	spin_unlock_irqrestore(&domain->i915->uncore.lock, irqflags);
+
+	return HRTIMER_NORESTART;
 }
 
 void intel_uncore_forcewake_reset(struct drm_device *dev, bool restore)
@@ -259,16 +267,16 @@ void intel_uncore_forcewake_reset(struct drm_device *dev, bool restore)
 		active_domains = 0;
 
 		for_each_fw_domain(domain, dev_priv, id) {
-			if (del_timer_sync(&domain->timer) == 0)
+			if (hrtimer_cancel(&domain->timer) == 0)
 				continue;
 
-			intel_uncore_fw_release_timer((unsigned long)domain);
+			intel_uncore_fw_release_timer(&domain->timer);
 		}
 
 		spin_lock_irqsave(&dev_priv->uncore.lock, irqflags);
 
 		for_each_fw_domain(domain, dev_priv, id) {
-			if (timer_pending(&domain->timer))
+			if (hrtimer_active(&domain->timer))
 				active_domains |= (1 << id);
 		}
 
@@ -491,7 +499,6 @@ static void __intel_uncore_forcewake_put(struct drm_i915_private *dev_priv,
 		if (--domain->wake_count)
 			continue;
 
-		domain->wake_count++;
 		fw_domain_arm_timer(domain);
 	}
 }
@@ -732,7 +739,6 @@ static inline void __force_wake_auto(struct drm_i915_private *dev_priv,
 			continue;
 		}
 
-		domain->wake_count++;
 		fw_domain_arm_timer(domain);
 	}
 
@@ -1150,7 +1156,8 @@ static void fw_domain_init(struct drm_i915_private *dev_priv,
 	d->i915 = dev_priv;
 	d->id = domain_id;
 
-	setup_timer(&d->timer, intel_uncore_fw_release_timer, (unsigned long)d);
+	hrtimer_init(&d->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
+	d->timer.function = intel_uncore_fw_release_timer;
 
 	dev_priv->uncore.fw_domains |= (1 << domain_id);
 
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/3 drm/i915: Simplify for_each_fw_domain iterators

From: Tvrtko Ursulin <[email protected]>

As the vast majority of users do not use the domain id variable, we can eliminate it from the iterator and also change the latter using the same principle as was recently done for for_each_engine.

For a couple of callers which do need the domain mask, store it in the domain array (which already has the domain id), then both can be retrieved thence.

Result is clearer code and smaller generated binary, especially in the tight fw get/put loops. Also, relationship between domain id and mask is no longer assumed in the macro.

v2: Improve grammar in the commit message and rename the
iterator to for_each_fw_domain_masked for consistency. (Dave Gordon)

---
 drivers/gpu/drm/i915/i915_debugfs.c |  5 ++---
 drivers/gpu/drm/i915/i915_drv.h     | 17 +++++++-------
 drivers/gpu/drm/i915/intel_uncore.c | 45 +++++++++++++++++--------------------
 3 files changed, 32 insertions(+), 35 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +2 -3
index be4bcdcbb129..18396b23bc56 100644
@@ -1464,12 +1464,11 @@ static int i915_forcewake_domains(struct seq_file *m, void *data)
 	struct drm_device *dev = node->minor->dev;
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct intel_uncore_forcewake_domain *fw_domain;
-	int i;
 
 	spin_lock_irq(&dev_priv->uncore.lock);
-	for_each_fw_domain(fw_domain, dev_priv, i) {
+	for_each_fw_domain(fw_domain, dev_priv) {
 		seq_printf(m, "%s.wake_count = %u\n",
-			   intel_uncore_forcewake_domain_to_str(i),
+			   intel_uncore_forcewake_domain_to_str(fw_domain->id),
 			   fw_domain->wake_count);
 	}
 	spin_unlock_irq(&dev_priv->uncore.lock);
drivers/gpu/drm/i915/i915_drv.h +9 -8
index a1dae0d6ba23..779b934d51b0 100644
@@ -665,6 +665,7 @@ struct intel_uncore {
 	struct intel_uncore_forcewake_domain {
 		struct drm_i915_private *i915;
 		enum forcewake_domain_id id;
+		enum forcewake_domains mask;
 		unsigned wake_count;
 		struct hrtimer timer;
 		i915_reg_t reg_set;
@@ -679,14 +680,14 @@ struct intel_uncore {
 };
 
 /* Iterate over initialised fw domains */
-#define for_each_fw_domain_mask(domain__, mask__, dev_priv__, i__) \
-	for ((i__) = 0, (domain__) = &(dev_priv__)->uncore.fw_domain[0]; \
-	     (i__) < FW_DOMAIN_ID_COUNT; \
-	     (i__)++, (domain__) = &(dev_priv__)->uncore.fw_domain[i__]) \
-		for_each_if (((mask__) & (dev_priv__)->uncore.fw_domains) & (1 << (i__)))
-
-#define for_each_fw_domain(domain__, dev_priv__, i__) \
-	for_each_fw_domain_mask(domain__, FORCEWAKE_ALL, dev_priv__, i__)
+#define for_each_fw_domain_masked(domain__, mask__, dev_priv__) \
+	for ((domain__) = &(dev_priv__)->uncore.fw_domain[0]; \
+	     (domain__) < &(dev_priv__)->uncore.fw_domain[FW_DOMAIN_ID_COUNT]; \
+	     (domain__)++) \
+		for_each_if ((mask__) & (domain__)->mask)
+
+#define for_each_fw_domain(domain__, dev_priv__) \
+	for_each_fw_domain_masked(domain__, FORCEWAKE_ALL, dev_priv__)
 
 #define CSR_VERSION(major, minor)	((major) << 16 | (minor))
 #define CSR_VERSION_MAJOR(version)	((version) >> 16)
drivers/gpu/drm/i915/intel_uncore.c +21 -24

156 lines not on this page · raw message

Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH 3/3 drm/i915: Do not serialize forcewake acquire across domains

In reply to Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

On platforms with multiple forcewake domains it seems more efficient to request all desired ones and then to wait for acks to avoid needlessly serializing on each domain.

v2: Rebase.

---
 drivers/gpu/drm/i915/intel_uncore.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_uncore.c +3 -1
index 963a3875d436..dcf38bb5a097 100644
@@ -115,8 +115,10 @@ fw_domains_get(struct drm_i915_private *dev_priv, enum forcewake_domains fw_doma
 	for_each_fw_domain_masked(d, fw_domains, dev_priv) {
 		fw_domain_wait_ack_clear(d);
 		fw_domain_get(d);
-		fw_domain_wait_ack(d);
 	}
+
+	for_each_fw_domain_masked(d, fw_domains, dev_priv)
+		fw_domain_wait_ack(d);
 }
 
 static void
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

✗ Fi.CI.BAT: failure for series starting with [resend-for-CI,1/3] drm/i915: Use consistent forcewake auto-release timeout across kernel configs

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [resend-for-CI,1/3] drm/i915: Use consistent forcewake auto-release timeout across kernel configs
URL : https://patchwork.freedesktop.org/series/5424/
State : failure

== Summary ==

Series 5424v1 Series without cover letter
http://patchwork.freedesktop.org/api/1.0/series/5424/revisions/1/mbox/

Test drv_getparams_basic:

        Subgroup basic-subslice-total:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test drv_module_reload_basic:
                incomplete -> PASS       (bsw-nuc-2)
Test gem_basic:
        Subgroup bad-close:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup create-close:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup create-fd-close:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test gem_ctx_param_basic:
        Subgroup basic:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup invalid-ctx-set:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup invalid-param-get:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup invalid-param-set:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup root-set:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test gem_ctx_switch:
        Subgroup basic-default:
                skip       -> PASS       (bsw-nuc-2)
Test gem_exec_basic:
        Subgroup basic-blt:
                skip       -> PASS       (bsw-nuc-2)
        Subgroup gtt-bsd:
                skip       -> PASS       (bsw-nuc-2)
        Subgroup readonly-bsd:
                skip       -> PASS       (bsw-nuc-2)
        Subgroup readonly-render:
                skip       -> PASS       (bsw-nuc-2)
        Subgroup readonly-vebox:
                skip       -> PASS       (bsw-nuc-2)
Test gem_exec_store:
        Subgroup basic-bsd:
                skip       -> PASS       (bsw-nuc-2)
        Subgroup basic-default:
                skip       -> PASS       (bsw-nuc-2)
        Subgroup basic-vebox:
                skip       -> PASS       (bsw-nuc-2)
Test gem_exec_whisper:
        Subgroup basic:
                skip       -> PASS       (bsw-nuc-2)
Test gem_mmap:
        Subgroup basic-small-bo:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test gem_mmap_gtt:
        Subgroup basic-write:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup basic-write-gtt:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test gem_ringfill:
        Subgroup basic-default-hang:
                skip       -> PASS       (bsw-nuc-2)
Test gem_sync:
        Subgroup basic-blt:
                skip       -> PASS       (bsw-nuc-2)
        Subgroup basic-vebox:
                skip       -> PASS       (bsw-nuc-2)
Test gem_tiled_pread_basic:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test kms_addfb_basic:
        Subgroup addfb25-modifier-no-flag:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup addfb25-y-tiled:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup bad-pitch-65536:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup basic-x-tiled:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup framebuffer-vs-set-tiling:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup too-wide:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE
        Subgroup basic-flip-vs-wf_vblank:
                dmesg-fail -> PASS       (bsw-nuc-2)
Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-c-frame-sequence:
                dmesg-fail -> PASS       (bsw-nuc-2)
        Subgroup suspend-read-crc-pipe-c:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test prime_self_import:
        Subgroup basic-with_fd_dup:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup basic-with_one_bo_two_files:
                dmesg-warn -> PASS       (bsw-nuc-2)
bdw-ultra        total:196  pass:175  dwarn:0   dfail:0   fail:0   skip:21 
bsw-nuc-2        total:196  pass:158  dwarn:1   dfail:0   fail:0   skip:37 
byt-nuc          total:196  pass:161  dwarn:0   dfail:0   fail:0   skip:35 
hsw-brixbox      total:196  pass:174  dwarn:0   dfail:0   fail:0   skip:22 
hsw-gt2          total:196  pass:179  dwarn:0   dfail:0   fail:0   skip:17 
ilk-hp8440p      total:196  pass:131  dwarn:1   dfail:0   fail:0   skip:64 
skl-i7k-2        total:196  pass:173  dwarn:0   dfail:0   fail:0   skip:23 
snb-dellxps      total:196  pass:162  dwarn:0   dfail:0   fail:0   skip:34 

BOOT FAILED for bdw-nuci7

Results at /archive/results/CI_IGT_test/Patchwork_1835/

851708c7e97537ed618fadbe5d342eaf8fa5146d drm-intel-nightly: 2016y-04m-07d-13h-56m-00s UTC integration manifest 92e5b39bf422197014aa097e20e66bdaa93af717 drm/i915: Do not serialize forcewake acquire across domains e55b59fd4e7f7999f9d4d6def7bcb009285237bc drm/i915: Simplify for_each_fw_domain iterators a2f0e7b42549d8061709fdd3a715614e8677e178 drm/i915: Use consistent forcewake auto-release timeout across kernel configs

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Re: ✗ Fi.CI.BAT: failure for series starting with [resend-for-CI,1/3] drm/i915: Use consistent forcewake auto-release timeout across kernel configs

Quoted 6 lines · Patchwork

== Series Details ==

Series: series starting with [resend-for-CI,1/3] drm/i915: Use consistent forcewake auto-release timeout across kernel configs
URL : https://patchwork.freedesktop.org/series/5424/
State : failure

Quoted 8 lines

== Summary ==

Series 5424v1 Series without cover letter
http://patchwork.freedesktop.org/api/1.0/series/5424/revisions/1/mbox/

Test drv_getparams_basic:

        Subgroup basic-subslice-total:
                dmesg-warn -> PASS       (bsw-nuc-2)

Even though bsw is (currently) unstable, this is a good result as it means that the change is not fundamentally broken on Braswell! -Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

Re: ✗ Fi.CI.BAT: failure for series starting with [resend-for-CI,1/3] drm/i915: Use consistent forcewake auto-release timeout across kernel configs

In reply to Patchwork
Quoted 84 lines · Patchwork

== Series Details ==

Series: series starting with [resend-for-CI,1/3] drm/i915: Use consistent forcewake auto-release timeout across kernel configs
URL : https://patchwork.freedesktop.org/series/5424/
State : failure

== Summary ==

Series 5424v1 Series without cover letter
http://patchwork.freedesktop.org/api/1.0/series/5424/revisions/1/mbox/

Test drv_getparams_basic:

         Subgroup basic-subslice-total:
                 dmesg-warn -> PASS       (bsw-nuc-2)
Test drv_module_reload_basic:
                 incomplete -> PASS       (bsw-nuc-2)
Test gem_basic:
         Subgroup bad-close:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup create-close:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup create-fd-close:
                 dmesg-warn -> PASS       (bsw-nuc-2)
Test gem_ctx_param_basic:
         Subgroup basic:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup invalid-ctx-set:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup invalid-param-get:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup invalid-param-set:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup root-set:
                 dmesg-warn -> PASS       (bsw-nuc-2)
Test gem_ctx_switch:
         Subgroup basic-default:
                 skip       -> PASS       (bsw-nuc-2)
Test gem_exec_basic:
         Subgroup basic-blt:
                 skip       -> PASS       (bsw-nuc-2)
         Subgroup gtt-bsd:
                 skip       -> PASS       (bsw-nuc-2)
         Subgroup readonly-bsd:
                 skip       -> PASS       (bsw-nuc-2)
         Subgroup readonly-render:
                 skip       -> PASS       (bsw-nuc-2)
         Subgroup readonly-vebox:
                 skip       -> PASS       (bsw-nuc-2)
Test gem_exec_store:
         Subgroup basic-bsd:
                 skip       -> PASS       (bsw-nuc-2)
         Subgroup basic-default:
                 skip       -> PASS       (bsw-nuc-2)
         Subgroup basic-vebox:
                 skip       -> PASS       (bsw-nuc-2)
Test gem_exec_whisper:
         Subgroup basic:
                 skip       -> PASS       (bsw-nuc-2)
Test gem_mmap:
         Subgroup basic-small-bo:
                 dmesg-warn -> PASS       (bsw-nuc-2)
Test gem_mmap_gtt:
         Subgroup basic-write:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup basic-write-gtt:
                 dmesg-warn -> PASS       (bsw-nuc-2)
Test gem_ringfill:
         Subgroup basic-default-hang:
                 skip       -> PASS       (bsw-nuc-2)
Test gem_sync:
         Subgroup basic-blt:
                 skip       -> PASS       (bsw-nuc-2)
         Subgroup basic-vebox:
                 skip       -> PASS       (bsw-nuc-2)
Test gem_tiled_pread_basic:
                 dmesg-warn -> PASS       (bsw-nuc-2)
Test kms_addfb_basic:
         Subgroup addfb25-modifier-no-flag:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup addfb25-y-tiled:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup bad-pitch-65536:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup basic-x-tiled:
Quoted 8 lines
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup framebuffer-vs-set-tiling:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup too-wide:
                 dmesg-warn -> PASS       (bsw-nuc-2)
Test kms_flip:
         Subgroup basic-flip-vs-dpms:
                 pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE

Old friend unclaimed access prior to suspending: https://bugs.freedesktop.org/show_bug.cgi?id=94164

Quoted 21 lines
         Subgroup basic-flip-vs-wf_vblank:
                 dmesg-fail -> PASS       (bsw-nuc-2)
Test kms_pipe_crc_basic:
         Subgroup read-crc-pipe-c-frame-sequence:
                 dmesg-fail -> PASS       (bsw-nuc-2)
         Subgroup suspend-read-crc-pipe-c:
                 dmesg-warn -> PASS       (bsw-nuc-2)
Test prime_self_import:
         Subgroup basic-with_fd_dup:
                 dmesg-warn -> PASS       (bsw-nuc-2)
         Subgroup basic-with_one_bo_two_files:
                 dmesg-warn -> PASS       (bsw-nuc-2)
bdw-ultra        total:196  pass:175  dwarn:0   dfail:0   fail:0   skip:21
bsw-nuc-2        total:196  pass:158  dwarn:1   dfail:0   fail:0   skip:37
byt-nuc          total:196  pass:161  dwarn:0   dfail:0   fail:0   skip:35
hsw-brixbox      total:196  pass:174  dwarn:0   dfail:0   fail:0   skip:22
hsw-gt2          total:196  pass:179  dwarn:0   dfail:0   fail:0   skip:17
ilk-hp8440p      total:196  pass:131  dwarn:1   dfail:0   fail:0   skip:64
skl-i7k-2        total:196  pass:173  dwarn:0   dfail:0   fail:0   skip:23
snb-dellxps      total:196  pass:162  dwarn:0   dfail:0   fail:0   skip:34
Quoted 8 lines

BOOT FAILED for bdw-nuci7

Results at /archive/results/CI_IGT_test/Patchwork_1835/

851708c7e97537ed618fadbe5d342eaf8fa5146d drm-intel-nightly: 2016y-04m-07d-13h-56m-00s UTC integration manifest 92e5b39bf422197014aa097e20e66bdaa93af717 drm/i915: Do not serialize forcewake acquire across domains e55b59fd4e7f7999f9d4d6def7bcb009285237bc drm/i915: Simplify for_each_fw_domain iterators a2f0e7b42549d8061709fdd3a715614e8677e178 drm/i915: Use consistent forcewake auto-release timeout across kernel configs

Series merged (on the basis it does not break even BSW) - thanks for the review!

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Re: ✗ Fi.CI.BAT: failure for series starting with [resend-for-CI,1/3] drm/i915: Use consistent forcewake auto-release timeout across kernel configs

Quoted 8 lines · Tvrtko Ursulin
Quoted 3 lines · Patchwork

Test kms_flip:

         Subgroup basic-flip-vs-dpms:
                 pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE

Old friend unclaimed access prior to suspending:
https://bugs.freedesktop.org/show_bug.cgi?id=94164

o_O

ILK doesn't even have a way to detect such things.

Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw

Re: ✗ Fi.CI.BAT: failure for series starting with [resend-for-CI,1/3] drm/i915: Use consistent forcewake auto-release timeout across kernel configs

Quoted 7 lines · Ville Syrjälä
Quoted 6 lines · Tvrtko Ursulin
Quoted 3 lines · Patchwork

Test kms_flip:

          Subgroup basic-flip-vs-dpms:
                  pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE
Quoted 6 lines
Quoted 2 lines

Old friend unclaimed access prior to suspending:
https://bugs.freedesktop.org/show_bug.cgi?id=94164

o_O

ILK doesn't even have a way to detect such things.

:D No idea, must be copy and paste error, wrong tab, stack overflow on (mental) context switching..

Real one is sporadic fifo underrun: https://bugs.freedesktop.org/show_bug.cgi?id=93787

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx