Skip to contentSkip to conversation

ne10: use bb.debug for debug messages

PATCH In review Denys Dmytriyenko 3 participants 5 messages Apr 7, 2016 – Apr 22, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ne10: use bb.debug for debug messages

From: Denys Dmytriyenko <[email protected]>

Moreover, the messages are misleading, saying "Building for arch blah", even when this recipe is not being built. It merely checks if the recipe is cmaptible with the currently used architecture.

---
 meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-support/ne10/ne10_1.2.1.bb +2 -2
index 4d753a0..de97982 100644
@@ -20,10 +20,10 @@ COMPATIBLE_MACHINE_armv7a = "(.*)"
 python () {
     if any(t.startswith('armv7') for t in d.getVar('TUNE_FEATURES', True).split()):
         d.setVar('NE10_TARGET_ARCH', 'armv7')
-        bb.note('Building Ne10 for armv7')
+        bb.debug(2, 'Building Ne10 for armv7')
     elif any(t.startswith('aarch64') for t in d.getVar('TUNE_FEATURES', True).split()):
         d.setVar('NE10_TARGET_ARCH', 'aarch64')
-        bb.note('Building Ne10 for aarch64')
+        bb.debug(2, 'Building Ne10 for aarch64')
     else:
         raise bb.parse.SkipPackage("Incompatible with archs other than armv7 and aarch64")
 }
Signature · 1 line
2.2.0
#1 lore raw
Quoted 6 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

Moreover, the messages are misleading, saying "Building for arch blah", even when this recipe is not being built. It merely checks if the recipe is cmaptible with the currently used architecture.

LGTM, I have been seeing these notes too.

Quoted 30 lines
---
 meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-support/ne10/ne10_1.2.1.bb +2 -3
index 4d753a0..de97982 100644
@@ -20,10 +20,10 @@ COMPATIBLE_MACHINE_armv7a = "(.*)"
 python () {
     if any(t.startswith('armv7') for t in d.getVar('TUNE_FEATURES', True).split()):
         d.setVar('NE10_TARGET_ARCH', 'armv7')
-        bb.note('Building Ne10 for armv7')
+        bb.debug(2, 'Building Ne10 for armv7')
     elif any(t.startswith('aarch64') for t in d.getVar('TUNE_FEATURES', True).split()):
         d.setVar('NE10_TARGET_ARCH', 'aarch64')
-        bb.note('Building Ne10 for aarch64')
+        bb.debug(2, 'Building Ne10 for aarch64')
     else:
         raise bb.parse.SkipPackage("Incompatible with archs other than armv7 and aarch64")
 }
--

2.2.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw
In reply to Denys Dmytriyenko

Ping. Also in master-next for over a week - how often does it get merged to master?

Quoted 36 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

Moreover, the messages are misleading, saying "Building for arch blah", even when this recipe is not being built. It merely checks if the recipe is cmaptible with the currently used architecture.

---
 meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-support/ne10/ne10_1.2.1.bb +2 -2
index 4d753a0..de97982 100644
@@ -20,10 +20,10 @@ COMPATIBLE_MACHINE_armv7a = "(.*)"
 python () {
     if any(t.startswith('armv7') for t in d.getVar('TUNE_FEATURES', True).split()):
         d.setVar('NE10_TARGET_ARCH', 'armv7')
-        bb.note('Building Ne10 for armv7')
+        bb.debug(2, 'Building Ne10 for armv7')
     elif any(t.startswith('aarch64') for t in d.getVar('TUNE_FEATURES', True).split()):
         d.setVar('NE10_TARGET_ARCH', 'aarch64')
-        bb.note('Building Ne10 for aarch64')
+        bb.debug(2, 'Building Ne10 for aarch64')
     else:
         raise bb.parse.SkipPackage("Incompatible with archs other than armv7 and aarch64")
 }
Signature · 7 lines
2.2.0

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
#3 lore raw

When everything is at least once tested in my jenkins builds and I've time to go through the list of pending changes.

I was away from computers almost whole previous week, so there is longer delay now.

Quoted 51 lines · Denys Dmytriyenko

Ping. Also in master-next for over a week - how often does it get merged to master?

Quoted 6 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

Moreover, the messages are misleading, saying "Building for arch blah", even when this recipe is not being built. It merely checks if the recipe is cmaptible with the currently used architecture.

Review

Quoted 6 lines
---
 meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb

meta-oe/recipes-support/ne10/ne10_1.2.1.bb COMPATIBLE_MACHINE_armv7a = "(.*)" · line 21

Quoted 6 lines

index 4d753a0..de97982 100644

meta-oe/recipes-support/ne10/ne10_1.2.1.bb +0 -0
@@ -20,10 +20,10 @@ COMPATIBLE_MACHINE_armv7a = "(.*)"
 python () {
     if any(t.startswith('armv7') for t in d.getVar('TUNE_FEATURES',

True).split()):

meta-oe/recipes-support/ne10/ne10_1.2.1.bb COMPATIBLE_MACHINE_armv7a = "(.*)"

Quoted 4 lines
meta-oe/recipes-support/ne10/ne10_1.2.1.bb +1 -1
         d.setVar('NE10_TARGET_ARCH', 'armv7')
-        bb.note('Building Ne10 for armv7')
+        bb.debug(2, 'Building Ne10 for armv7')
     elif any(t.startswith('aarch64') for t in d.getVar('TUNE_FEATURES',

True).split()):

meta-oe/recipes-support/ne10/ne10_1.2.1.bb COMPATIBLE_MACHINE_armv7a = "(.*)"

Quoted 5 lines
meta-oe/recipes-support/ne10/ne10_1.2.1.bb +1 -1
         d.setVar('NE10_TARGET_ARCH', 'aarch64')
-        bb.note('Building Ne10 for aarch64')
+        bb.debug(2, 'Building Ne10 for aarch64')
     else:
         raise bb.parse.SkipPackage("Incompatible with archs other than

armv7 and aarch64")

Quoted 9 lines
meta-oe/recipes-support/ne10/ne10_1.2.1.bb +0 -1
 }
--

2.2.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw
Quoted 5 lines · Martin Jansa

When everything is at least once tested in my jenkins builds and I've time to go through the list of pending changes.

I was away from computers almost whole previous week, so there is longer delay now.

Thanks, no problem and congrats!

Quoted 58 lines · Denys Dmytriyenko
Quoted 52 lines

Ping. Also in master-next for over a week - how often does it get merged to master?

Quoted 6 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

Moreover, the messages are misleading, saying "Building for arch blah", even when this recipe is not being built. It merely checks if the recipe is cmaptible with the currently used architecture.

Review

Quoted 6 lines
---
 meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb

meta-oe/recipes-support/ne10/ne10_1.2.1.bb COMPATIBLE_MACHINE_armv7a = "(.*)" · line 21

Quoted 6 lines

index 4d753a0..de97982 100644

meta-oe/recipes-support/ne10/ne10_1.2.1.bb +0 -0
@@ -20,10 +20,10 @@ COMPATIBLE_MACHINE_armv7a = "(.*)"
 python () {
     if any(t.startswith('armv7') for t in d.getVar('TUNE_FEATURES',

True).split()):

meta-oe/recipes-support/ne10/ne10_1.2.1.bb COMPATIBLE_MACHINE_armv7a = "(.*)"

Quoted 4 lines
meta-oe/recipes-support/ne10/ne10_1.2.1.bb +1 -1
         d.setVar('NE10_TARGET_ARCH', 'armv7')
-        bb.note('Building Ne10 for armv7')
+        bb.debug(2, 'Building Ne10 for armv7')
     elif any(t.startswith('aarch64') for t in d.getVar('TUNE_FEATURES',

True).split()):

meta-oe/recipes-support/ne10/ne10_1.2.1.bb COMPATIBLE_MACHINE_armv7a = "(.*)"

Quoted 5 lines
meta-oe/recipes-support/ne10/ne10_1.2.1.bb +1 -1
         d.setVar('NE10_TARGET_ARCH', 'aarch64')
-        bb.note('Building Ne10 for aarch64')
+        bb.debug(2, 'Building Ne10 for aarch64')
     else:
         raise bb.parse.SkipPackage("Incompatible with archs other than

armv7 and aarch64")

Quoted 9 lines
meta-oe/recipes-support/ne10/ne10_1.2.1.bb +0 -1
 }
--

2.2.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel