arc: Add virt_to_phys() stub

PATCH New Alexey Brodkin 2 participants 7 messages Apr 8, 2016 – Apr 11, 2016 Synopsys ARC architecture

lore

Share & tools

lore

Alexey Brodkin

author

2016-04-08 17:00 UTC #0 lore raw

PATCH 1/1 arc: Add virt_to_phys() stub

Commit cf7c93cdd755 "usb: ehci: Implement V2P mapping" introduced usage of virt_to_phys() in ehci-hcd.

Since there was no implementation of virt_to_phys() for ARC compilation of the ehci-generic driver failed.

This change adds virt_to_phys() stub for ARC so now USB driver for AXS101 board could be built again.

Signed-off-by Alexey Brodkin <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Daniel Schwierzeck <[email protected]>

Cc Hans de Goede <[email protected]>

---
 arch/arc/include/asm/io.h | 5 +++++
 1 file changed, 5 insertions(+)

arch/arc/include/asm/io.h +5 -0

index 281682c..b6f7724 100644
@@ -239,4 +239,9 @@ static inline int __raw_writesl(unsigned int addr, void *data, int longlen)
 #define setbits_8(addr, set) setbits(8, addr, set)
 #define clrsetbits_8(addr, clear, set) clrsetbits(8, addr, clear, set)
 
+static inline phys_addr_t virt_to_phys(void *vaddr)
+{
+	return (phys_addr_t)((unsigned long)vaddr);
+}
+
 #endif	/* __ASM_ARC_IO_H */

Signature · 1 line

2.5.5

Marek Vasut

2016-04-08 17:05 UTC #1 lore raw

PATCH 1/1 arc: Add virt_to_phys() stub

Quoted 23 lines · Alexey Brodkin

Commit cf7c93cdd755 "usb: ehci: Implement V2P mapping" introduced usage of virt_to_phys() in ehci-hcd.
Since there was no implementation of virt_to_phys() for ARC compilation of the ehci-generic driver failed.
This change adds virt_to_phys() stub for ARC so now USB driver for AXS101 board could be built again.
Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Hans de Goede <[email protected]>
---
 arch/arc/include/asm/io.h | 5 +++++
 1 file changed, 5 insertions(+)
arch/arc/include/asm/io.h +0 -0
index 281682c..b6f7724 100644

arch/arc/include/asm/io.h static inline int __raw_writesl(unsigned int addr, void *data, int longlen) · line 247

Quoted 9 lines

arch/arc/include/asm/io.h +5 -0

@@ -239,4 +239,9 @@ static inline int __raw_writesl(unsigned int addr, void *data, int longlen)
 #define setbits_8(addr, set) setbits(8, addr, set)
 #define clrsetbits_8(addr, clear, set) clrsetbits(8, addr, clear, set)
 
+static inline phys_addr_t virt_to_phys(void *vaddr)
+{
+	return (phys_addr_t)((unsigned long)vaddr);
+}
+
 #endif	/* __ASM_ARC_IO_H */

Sorry for breaking your arch.

Acked-by Marek Vasut <[email protected]>

Signature · 2 lines

Best regards,
Marek Vasut

Alexey Brodkin

author

2016-04-08 17:08 UTC #2 lore raw

PATCH 1/1 arc: Add virt_to_phys() stub

Hi Marek,

Quoted 19 lines · Marek Vasut

Quoted 18 lines · Alexey Brodkin
Commit cf7c93cdd755 "usb: ehci: Implement V2P mapping" introduced usage of virt_to_phys() in ehci-hcd.
Since there was no implementation of virt_to_phys() for ARC compilation of the ehci-generic driver failed.
This change adds virt_to_phys() stub for ARC so now USB driver for AXS101 board could be built again.
Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Hans de Goede <[email protected]>
---
?arch/arc/include/asm/io.h | 5 +++++
?1 file changed, 5 insertions(+)

Quoted 16 lines

Quoted 13 lines

arch/arc/include/asm/io.h +0 -0

index 281682c..b6f7724 100644
@@ -239,4 +239,9 @@ static inline int __raw_writesl(unsigned int addr, void *data, int longlen)
 ?#define setbits_8(addr, set) setbits(8, addr, set)
 ?#define clrsetbits_8(addr, clear, set) clrsetbits(8, addr, clear, set)

arch/arc/include/asm/io.h +5 -0

+static inline phys_addr_t virt_to_phys(void *vaddr)
+{
+	return (phys_addr_t)((unsigned long)vaddr);
+}
+

Quoted 2 lines

?#endif /* __ASM_ARC_IO_H */

Sorry for breaking your arch.

That happens. No problem.
Real problem though is we still don't have autobuilder that catches these kinds of trivial flaws.

I don't build for all arches as well before submitting patches so before autobuilder is there we'll see more issues of that kind :)

-Alexey

Marek Vasut

2016-04-08 17:23 UTC #3 lore raw

PATCH 1/1 arc: Add virt_to_phys() stub

Quoted 39 lines · Alexey Brodkin

Hi Marek,
Quoted 27 lines · Marek Vasut
Quoted 26 lines · Alexey Brodkin
Commit cf7c93cdd755 "usb: ehci: Implement V2P mapping" introduced usage of virt_to_phys() in ehci-hcd.
Since there was no implementation of virt_to_phys() for ARC compilation of the ehci-generic driver failed.
This change adds virt_to_phys() stub for ARC so now USB driver for AXS101 board could be built again.
Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Hans de Goede <[email protected]>
---
 arch/arc/include/asm/io.h | 5 +++++
 1 file changed, 5 insertions(+)
arch/arc/include/asm/io.h +0 -0
index 281682c..b6f7724 100644
@@ -239,4 +239,9 @@ static inline int __raw_writesl(unsigned int addr, void *data, int longlen)
 #define setbits_8(addr, set) setbits(8, addr, set)
 #define clrsetbits_8(addr, clear, set) clrsetbits(8, addr, clear, set)
 
Quoted 8 lines
arch/arc/include/asm/io.h static inline int __raw_writesl(unsigned int addr, void *data, int longlen) · line 247
Quoted 7 lines
arch/arc/include/asm/io.h +5 -0
+static inline phys_addr_t virt_to_phys(void *vaddr)
+{
+	return (phys_addr_t)((unsigned long)vaddr);
+}
+
 #endif	/* __ASM_ARC_IO_H */
Sorry for breaking your arch.

Quoted 3 lines

That happens. No problem.
Real problem though is we still don't have autobuilder that catches these kinds of trivial flaws.

Synopsys can sponsor one , anytime ;-)

Quoted 2 lines

I don't build for all arches as well before submitting patches so before autobuilder is there we'll see more issues of that kind :)

buildman can help you here.

Quoted 2 lines

-Alexey

Signature · 2 lines

Best regards,
Marek Vasut

Alexey Brodkin

author

2016-04-08 17:26 UTC #4 lore raw

PATCH 1/1 arc: Add virt_to_phys() stub

Hi Marek,

Quoted 42 lines · Marek Vasut

Quoted 41 lines · Alexey Brodkin
Hi Marek,
Quoted 37 lines · Marek Vasut
Quoted 32 lines · Alexey Brodkin
Commit cf7c93cdd755 "usb: ehci: Implement V2P mapping" introduced usage of virt_to_phys() in ehci-hcd.
Since there was no implementation of virt_to_phys() for ARC compilation of the ehci-generic driver failed.
This change adds virt_to_phys() stub for ARC so now USB driver for AXS101 board could be built again.
Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Hans de Goede <[email protected]>
---
?arch/arc/include/asm/io.h | 5 +++++
?1 file changed, 5 insertions(+)
arch/arc/include/asm/io.h +0 -0
index 281682c..b6f7724 100644
@@ -239,4 +239,9 @@ static inline int __raw_writesl(unsigned int addr, void *data, int longlen)
 ?#define setbits_8(addr, set) setbits(8, addr, set)
 ?#define clrsetbits_8(addr, clear, set) clrsetbits(8, addr, clear, set)
?
arch/arc/include/asm/io.h +5 -0
+static inline phys_addr_t virt_to_phys(void *vaddr)
+{
+	return (phys_addr_t)((unsigned long)vaddr);
+}
+
Quoted 2 lines
?#endif /* __ASM_ARC_IO_H */
Sorry for breaking your arch.

Quoted 4 lines

Quoted 3 lines
That happens. No problem.
Real problem though is we still don't have autobuilder that catches these kinds of trivial flaws.
Synopsys can sponsor one , anytime ;-)

Ok I'll discuss this with my manager :)

Quoted 3 lines

Quoted 2 lines
I don't build for all arches as well before submitting patches so before autobuilder is there we'll see more issues of that kind :)
buildman can help you here.

Oh cool... I didn't know about it. Do you really use it? (kidding)

For the record could you please ack this change so I may go forward and apply it to my tree?

-Alexey

Marek Vasut

2016-04-08 17:27 UTC #5 lore raw

PATCH 1/1 arc: Add virt_to_phys() stub

In reply to Alexey Brodkin

Quoted 22 lines · Alexey Brodkin

Commit cf7c93cdd755 "usb: ehci: Implement V2P mapping" introduced usage of virt_to_phys() in ehci-hcd.
Since there was no implementation of virt_to_phys() for ARC compilation of the ehci-generic driver failed.
This change adds virt_to_phys() stub for ARC so now USB driver for AXS101 board could be built again.
Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Hans de Goede <[email protected]>
---
 arch/arc/include/asm/io.h | 5 +++++
 1 file changed, 5 insertions(+)
arch/arc/include/asm/io.h +0 -0
index 281682c..b6f7724 100644

arch/arc/include/asm/io.h static inline int __raw_writesl(unsigned int addr, void *data, int longlen) · line 247

Quoted 9 lines

arch/arc/include/asm/io.h +5 -0

@@ -239,4 +239,9 @@ static inline int __raw_writesl(unsigned int addr, void *data, int longlen)
 #define setbits_8(addr, set) setbits(8, addr, set)
 #define clrsetbits_8(addr, clear, set) clrsetbits(8, addr, clear, set)
 
+static inline phys_addr_t virt_to_phys(void *vaddr)
+{
+	return (phys_addr_t)((unsigned long)vaddr);
+}
+
 #endif	/* __ASM_ARC_IO_H */

Acked-by Marek Vasut <[email protected]>

Signature · 2 lines

Best regards,
Marek Vasut

Alexey Brodkin

author

2016-04-11 17:25 UTC #6 lore raw

PATCH 1/1 arc: Add virt_to_phys() stub

Hi,

Quoted 8 lines · Marek Vasut

Quoted 7 lines · Alexey Brodkin
Commit cf7c93cdd755 "usb: ehci: Implement V2P mapping" introduced usage of virt_to_phys() in ehci-hcd.
Since there was no implementation of virt_to_phys() for ARC compilation of the ehci-generic driver failed.

Quoted 7 lines

Quoted 7 lines
This change adds virt_to_phys() stub for ARC so now USB driver for AXS101 board could be built again.
Signed-off-by Alexey Brodkin <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
Cc Hans de Goede <[email protected]>

Applied to u-boot-arc, thanks.

-Alexey